Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560172 > unrolled thread

[PATCH] power: supply: fix platform_no_drv_owner.cocci warnings

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] power: supply: fix platform_no_drv_owner.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2017-01-17 00:50 +0100
    Re: [PATCH] power: supply: fix platform_no_drv_owner.cocci warnings Sebastian Reichel <sre@kernel.org> - 2017-01-17 01:20 +0100

#1560172 — [PATCH] power: supply: fix platform_no_drv_owner.cocci warnings

drivers/power/supply/max14656_charger_detector.c:317:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Alexander Kurz <akurz@blala.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 max14656_charger_detector.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/power/supply/max14656_charger_detector.c
+++ b/drivers/power/supply/max14656_charger_detector.c
@@ -314,7 +314,6 @@ static const struct of_device_id max1465
 static struct i2c_driver max14656_i2c_driver = {
 	.driver = {
 		.name	= "max14656",
-		.owner	= THIS_MODULE,
 		.of_match_table = max14656_match_table,
 	},
 	.probe		= max14656_probe,

[toc] | [next] | [standalone]

#1560177

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Tue, Jan 17, 2017 at 07:47:56AM +0800, kbuild test robot wrote:
> drivers/power/supply/max14656_charger_detector.c:317:3-8: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Alexander Kurz <akurz@blala.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  max14656_charger_detector.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/power/supply/max14656_charger_detector.c
> +++ b/drivers/power/supply/max14656_charger_detector.c
> @@ -314,7 +314,6 @@ static const struct of_device_id max1465
>  static struct i2c_driver max14656_i2c_driver = {
>  	.driver = {
>  		.name	= "max14656",
> -		.owner	= THIS_MODULE,
>  		.of_match_table = max14656_match_table,
>  	},
>  	.probe		= max14656_probe,

Thanks, queued.

-- Sebastian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web