Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1558889 > unrolled thread
| Started by | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| First post | 2017-01-14 10:20 +0100 |
| Last post | 2017-01-16 22:10 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-14 10:20 +0100
Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err Josh Triplett <josh@joshtriplett.org> - 2017-01-16 09:00 +0100
Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-17 02:40 +0100
Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err Peter Zijlstra <peterz@infradead.org> - 2017-01-16 18:30 +0100
Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-16 22:10 +0100
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-14 10:20 +0100 |
| Subject | [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err |
| Message-ID | <sZsFc-49R-23@gated-at.bofh.it> |
This commit switches RCU suspicious-access splats use pr_err()
instead of the current INFO printk()s. This change makes it easier
to automatically classify splats.
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
kernel/locking/lockdep.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 7c38f8f3d97b..844cd04bb453 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -4412,13 +4412,13 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s)
#endif /* #ifdef CONFIG_PROVE_RCU_REPEATEDLY */
/* Note: the following can be executed concurrently, so be careful. */
printk("\n");
- printk("===============================\n");
- printk("[ INFO: suspicious RCU usage. ]\n");
+ pr_err("===============================\n");
+ pr_err("suspicious RCU usage. ]\n");
print_kernel_ident();
- printk("-------------------------------\n");
- printk("%s:%d %s!\n", file, line, s);
- printk("\nother info that might help us debug this:\n\n");
- printk("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
+ pr_err("-------------------------------\n");
+ pr_err("%s:%d %s!\n", file, line, s);
+ pr_err("\nother info that might help us debug this:\n\n");
+ pr_err("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
!rcu_lockdep_current_cpu_online()
? "RCU used illegally from offline CPU!\n"
: !rcu_is_watching()
--
2.5.2
[toc] | [next] | [standalone]
| From | Josh Triplett <josh@joshtriplett.org> |
|---|---|
| Date | 2017-01-16 09:00 +0100 |
| Subject | Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err |
| Message-ID | <t0amS-5yy-9@gated-at.bofh.it> |
| In reply to | #1558889 |
On Sat, Jan 14, 2017 at 01:13:03AM -0800, Paul E. McKenney wrote:
> This commit switches RCU suspicious-access splats use pr_err()
> instead of the current INFO printk()s. This change makes it easier
> to automatically classify splats.
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
One comment below.
> kernel/locking/lockdep.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 7c38f8f3d97b..844cd04bb453 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -4412,13 +4412,13 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s)
> #endif /* #ifdef CONFIG_PROVE_RCU_REPEATEDLY */
> /* Note: the following can be executed concurrently, so be careful. */
> printk("\n");
> - printk("===============================\n");
> - printk("[ INFO: suspicious RCU usage. ]\n");
> + pr_err("===============================\n");
> + pr_err("suspicious RCU usage. ]\n");
This message change seems unrelated, and potentially unintentional.
> print_kernel_ident();
> - printk("-------------------------------\n");
> - printk("%s:%d %s!\n", file, line, s);
> - printk("\nother info that might help us debug this:\n\n");
> - printk("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
> + pr_err("-------------------------------\n");
> + pr_err("%s:%d %s!\n", file, line, s);
> + pr_err("\nother info that might help us debug this:\n\n");
> + pr_err("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
> !rcu_lockdep_current_cpu_online()
> ? "RCU used illegally from offline CPU!\n"
> : !rcu_is_watching()
> --
> 2.5.2
>
[toc] | [prev] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-17 02:40 +0100 |
| Subject | Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err |
| Message-ID | <t0qUF-pj-7@gated-at.bofh.it> |
| In reply to | #1559504 |
On Sun, Jan 15, 2017 at 11:53:02PM -0800, Josh Triplett wrote:
> On Sat, Jan 14, 2017 at 01:13:03AM -0800, Paul E. McKenney wrote:
> > This commit switches RCU suspicious-access splats use pr_err()
> > instead of the current INFO printk()s. This change makes it easier
> > to automatically classify splats.
> >
> > Reported-by: Dmitry Vyukov <dvyukov@google.com>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> One comment below.
Good catch, fixed!
Thanx, Paul
> > kernel/locking/lockdep.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> > index 7c38f8f3d97b..844cd04bb453 100644
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -4412,13 +4412,13 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s)
> > #endif /* #ifdef CONFIG_PROVE_RCU_REPEATEDLY */
> > /* Note: the following can be executed concurrently, so be careful. */
> > printk("\n");
> > - printk("===============================\n");
> > - printk("[ INFO: suspicious RCU usage. ]\n");
> > + pr_err("===============================\n");
> > + pr_err("suspicious RCU usage. ]\n");
>
> This message change seems unrelated, and potentially unintentional.
>
> > print_kernel_ident();
> > - printk("-------------------------------\n");
> > - printk("%s:%d %s!\n", file, line, s);
> > - printk("\nother info that might help us debug this:\n\n");
> > - printk("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
> > + pr_err("-------------------------------\n");
> > + pr_err("%s:%d %s!\n", file, line, s);
> > + pr_err("\nother info that might help us debug this:\n\n");
> > + pr_err("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
> > !rcu_lockdep_current_cpu_online()
> > ? "RCU used illegally from offline CPU!\n"
> > : !rcu_is_watching()
> > --
> > 2.5.2
> >
>
[toc] | [prev] | [next] | [standalone]
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2017-01-16 18:30 +0100 |
| Subject | Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err |
| Message-ID | <t0jgu-3vr-21@gated-at.bofh.it> |
| In reply to | #1558889 |
On Sat, Jan 14, 2017 at 01:13:03AM -0800, Paul E. McKenney wrote:
> This commit switches RCU suspicious-access splats use pr_err()
> instead of the current INFO printk()s. This change makes it easier
> to automatically classify splats.
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
> kernel/locking/lockdep.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 7c38f8f3d97b..844cd04bb453 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -4412,13 +4412,13 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s)
> #endif /* #ifdef CONFIG_PROVE_RCU_REPEATEDLY */
> /* Note: the following can be executed concurrently, so be careful. */
> printk("\n");
> - printk("===============================\n");
> - printk("[ INFO: suspicious RCU usage. ]\n");
> + pr_err("===============================\n");
> + pr_err("suspicious RCU usage. ]\n");
> print_kernel_ident();
> - printk("-------------------------------\n");
> - printk("%s:%d %s!\n", file, line, s);
> - printk("\nother info that might help us debug this:\n\n");
> - printk("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
> + pr_err("-------------------------------\n");
> + pr_err("%s:%d %s!\n", file, line, s);
> + pr_err("\nother info that might help us debug this:\n\n");
> + pr_err("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
> !rcu_lockdep_current_cpu_online()
> ? "RCU used illegally from offline CPU!\n"
> : !rcu_is_watching()
This makes it inconsistent with the rest of lockdep; why are these more
important?
[toc] | [prev] | [next] | [standalone]
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-01-16 22:10 +0100 |
| Subject | Re: [PATCH tip/core/rcu 02/20] lockdep: Make RCU suspicious-access splats use pr_err |
| Message-ID | <t0mHo-6bh-7@gated-at.bofh.it> |
| In reply to | #1559933 |
On Mon, Jan 16, 2017 at 06:21:29PM +0100, Peter Zijlstra wrote:
> On Sat, Jan 14, 2017 at 01:13:03AM -0800, Paul E. McKenney wrote:
> > This commit switches RCU suspicious-access splats use pr_err()
> > instead of the current INFO printk()s. This change makes it easier
> > to automatically classify splats.
> >
> > Reported-by: Dmitry Vyukov <dvyukov@google.com>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > ---
> > kernel/locking/lockdep.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> > index 7c38f8f3d97b..844cd04bb453 100644
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -4412,13 +4412,13 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s)
> > #endif /* #ifdef CONFIG_PROVE_RCU_REPEATEDLY */
> > /* Note: the following can be executed concurrently, so be careful. */
> > printk("\n");
> > - printk("===============================\n");
> > - printk("[ INFO: suspicious RCU usage. ]\n");
> > + pr_err("===============================\n");
> > + pr_err("suspicious RCU usage. ]\n");
> > print_kernel_ident();
> > - printk("-------------------------------\n");
> > - printk("%s:%d %s!\n", file, line, s);
> > - printk("\nother info that might help us debug this:\n\n");
> > - printk("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
> > + pr_err("-------------------------------\n");
> > + pr_err("%s:%d %s!\n", file, line, s);
> > + pr_err("\nother info that might help us debug this:\n\n");
> > + pr_err("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
> > !rcu_lockdep_current_cpu_online()
> > ? "RCU used illegally from offline CPU!\n"
> > : !rcu_is_watching()
>
>
> This makes it inconsistent with the rest of lockdep; why are these more
> important?
No idea. The checkpatch script whined piteously so I changed them.
Thanx, Paul
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web