Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1559738 > unrolled thread
| Started by | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| First post | 2017-01-16 14:40 +0100 |
| Last post | 2017-01-16 20:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] x86/ioapic: Return suitable error code in mp_map_gsi_to_irq() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-16 14:40 +0100
Re: [PATCH 1/1] x86/ioapic: Return suitable error code in mp_map_gsi_to_irq() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-16 19:00 +0100
Re: [PATCH 1/1] x86/ioapic: Return suitable error code in mp_map_gsi_to_irq() Thomas Gleixner <tglx@linutronix.de> - 2017-01-16 20:00 +0100
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2017-01-16 14:40 +0100 |
| Subject | [PATCH 1/1] x86/ioapic: Return suitable error code in mp_map_gsi_to_irq() |
| Message-ID | <t0fFU-10y-15@gated-at.bofh.it> |
mp_map_gsi_to_irq() in some cases might return legacy -1, which would be wrongly interpreted as -EPERM. Correct those cases to return proper error codes. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- arch/x86/kernel/apic/io_apic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 945e512a112a..99cee86b7d17 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1107,12 +1107,12 @@ int mp_map_gsi_to_irq(u32 gsi, unsigned int flags, struct irq_alloc_info *info) ioapic = mp_find_ioapic(gsi); if (ioapic < 0) - return -1; + return -EINVAL; pin = mp_find_ioapic_pin(ioapic, gsi); idx = find_irq_entry(ioapic, pin, mp_INT); if ((flags & IOAPIC_MAP_CHECK) && idx < 0) - return -1; + return -ENODEV; return mp_map_pin_to_irq(gsi, idx, ioapic, pin, flags, info); } -- 2.11.0
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2017-01-16 19:00 +0100 |
| Subject | Re: [PATCH 1/1] x86/ioapic: Return suitable error code in mp_map_gsi_to_irq() |
| Message-ID | <t0jJw-3Hq-29@gated-at.bofh.it> |
| In reply to | #1559738 |
On Mon, 2017-01-16 at 15:30 +0200, Andy Shevchenko wrote: > mp_map_gsi_to_irq() in some cases might return legacy -1, which would > be > wrongly interpreted as -EPERM. > > Correct those cases to return proper error codes. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/x86/kernel/apic/io_apic.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/apic/io_apic.c > b/arch/x86/kernel/apic/io_apic.c > index 945e512a112a..99cee86b7d17 100644 > --- a/arch/x86/kernel/apic/io_apic.c > +++ b/arch/x86/kernel/apic/io_apic.c > @@ -1107,12 +1107,12 @@ int mp_map_gsi_to_irq(u32 gsi, unsigned int > flags, struct irq_alloc_info *info) > > ioapic = mp_find_ioapic(gsi); > if (ioapic < 0) > - return -1; > + return -EINVAL; > > pin = mp_find_ioapic_pin(ioapic, gsi); > idx = find_irq_entry(ioapic, pin, mp_INT); > if ((flags & IOAPIC_MAP_CHECK) && idx < 0) > - return -1; > + return -ENODEV; Looking one more time... Or should it be other way around: -ENODEV (ioapic < 0), -EINVAL (here)? > > return mp_map_pin_to_irq(gsi, idx, ioapic, pin, flags, info); > } -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
[toc] | [prev] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2017-01-16 20:00 +0100 |
| Subject | Re: [PATCH 1/1] x86/ioapic: Return suitable error code in mp_map_gsi_to_irq() |
| Message-ID | <t0kFz-4uU-15@gated-at.bofh.it> |
| In reply to | #1559956 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, 16 Jan 2017, Andy Shevchenko wrote: > On Mon, 2017-01-16 at 15:30 +0200, Andy Shevchenko wrote: > > mp_map_gsi_to_irq() in some cases might return legacy -1, which would > > be > > wrongly interpreted as -EPERM. > > > > Correct those cases to return proper error codes. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > arch/x86/kernel/apic/io_apic.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/kernel/apic/io_apic.c > > b/arch/x86/kernel/apic/io_apic.c > > index 945e512a112a..99cee86b7d17 100644 > > --- a/arch/x86/kernel/apic/io_apic.c > > +++ b/arch/x86/kernel/apic/io_apic.c > > @@ -1107,12 +1107,12 @@ int mp_map_gsi_to_irq(u32 gsi, unsigned int > > flags, struct irq_alloc_info *info) > > > > ioapic = mp_find_ioapic(gsi); > > if (ioapic < 0) > > - return -1; > > + return -EINVAL; > > > > pin = mp_find_ioapic_pin(ioapic, gsi); > > idx = find_irq_entry(ioapic, pin, mp_INT); > > if ((flags & IOAPIC_MAP_CHECK) && idx < 0) > > - return -1; > > + return -ENODEV; > > Looking one more time... > Or should it be other way around: -ENODEV (ioapic < 0), -EINVAL (here)? ENODEV for both cases I think,
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web