Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559854 > unrolled thread

[PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-16 17:00 +0100
    [PATCH 2/3] iio: potentiometer: mcp4531: Export OF device ID table as module aliases Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-16 17:00 +0100
      Re: [PATCH 2/3] iio: potentiometer: mcp4531: Export OF device ID  table as module aliases Jonathan Cameron <jic23@kernel.org> - 2017-01-21 15:30 +0100
    [PATCH 3/3] iio: adc: max1363: Export OF device ID table as module aliases Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-16 17:00 +0100
      Re: [PATCH 3/3] iio: adc: max1363: Export OF device ID table as  module aliases Jonathan Cameron <jic23@kernel.org> - 2017-01-21 15:30 +0100
    Re: [PATCH 1/3] iio: light: opt3001: Export OF device ID table as  module aliases Jonathan Cameron <jic23@kernel.org> - 2017-01-21 15:30 +0100

#1559854 — [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases

The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/iio/light/opt3001.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
index 78c9b3a6453a..b91ebc3483ce 100644
--- a/drivers/iio/light/opt3001.c
+++ b/drivers/iio/light/opt3001.c
@@ -840,6 +840,7 @@ static const struct of_device_id opt3001_of_match[] = {
 	{ .compatible = "ti,opt3001" },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, opt3001_of_match);
 
 static struct i2c_driver opt3001_driver = {
 	.probe = opt3001_probe,
-- 
2.7.4

[toc] | [next] | [standalone]

#1559855 — [PATCH 2/3] iio: potentiometer: mcp4531: Export OF device ID table as module aliases

The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/iio/potentiometer/mcp4531.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/potentiometer/mcp4531.c b/drivers/iio/potentiometer/mcp4531.c
index 0d1bcf89ae17..314353d7ab59 100644
--- a/drivers/iio/potentiometer/mcp4531.c
+++ b/drivers/iio/potentiometer/mcp4531.c
@@ -284,6 +284,7 @@ static const struct of_device_id mcp4531_of_match[] = {
 	MCP4531_COMPATIBLE("microchip,mcp4662-104", MCP466x_104),
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, mcp4531_of_match);
 #endif
 
 static int mcp4531_probe(struct i2c_client *client,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1564126 — Re: [PATCH 2/3] iio: potentiometer: mcp4531: Export OF device ID table as module aliases

On 16/01/17 15:50, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied.
> ---
> 
>  drivers/iio/potentiometer/mcp4531.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/potentiometer/mcp4531.c b/drivers/iio/potentiometer/mcp4531.c
> index 0d1bcf89ae17..314353d7ab59 100644
> --- a/drivers/iio/potentiometer/mcp4531.c
> +++ b/drivers/iio/potentiometer/mcp4531.c
> @@ -284,6 +284,7 @@ static const struct of_device_id mcp4531_of_match[] = {
>  	MCP4531_COMPATIBLE("microchip,mcp4662-104", MCP466x_104),
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, mcp4531_of_match);
>  #endif
>  
>  static int mcp4531_probe(struct i2c_client *client,
> 

[toc] | [prev] | [next] | [standalone]

#1559859 — [PATCH 3/3] iio: adc: max1363: Export OF device ID table as module aliases

The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/iio/adc/max1363.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index 841a13c9b6ea..c6c12feb4a08 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -1567,6 +1567,7 @@ static const struct of_device_id max1363_of_match[] = {
 	MAX1363_COMPATIBLE("maxim,max11647", max11647),
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, max1363_of_match);
 #endif
 
 static int max1363_probe(struct i2c_client *client,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1564124 — Re: [PATCH 3/3] iio: adc: max1363: Export OF device ID table as module aliases

On 16/01/17 15:50, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied.

Thanks,

Jonathan
> ---
> 
>  drivers/iio/adc/max1363.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index 841a13c9b6ea..c6c12feb4a08 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -1567,6 +1567,7 @@ static const struct of_device_id max1363_of_match[] = {
>  	MAX1363_COMPATIBLE("maxim,max11647", max11647),
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, max1363_of_match);
>  #endif
>  
>  static int max1363_probe(struct i2c_client *client,
> 

[toc] | [prev] | [next] | [standalone]

#1564122 — Re: [PATCH 1/3] iio: light: opt3001: Export OF device ID table as module aliases

On 16/01/17 15:50, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan
> ---
> 
>  drivers/iio/light/opt3001.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
> index 78c9b3a6453a..b91ebc3483ce 100644
> --- a/drivers/iio/light/opt3001.c
> +++ b/drivers/iio/light/opt3001.c
> @@ -840,6 +840,7 @@ static const struct of_device_id opt3001_of_match[] = {
>  	{ .compatible = "ti,opt3001" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, opt3001_of_match);
>  
>  static struct i2c_driver opt3001_driver = {
>  	.probe = opt3001_probe,
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web