Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1559703 > unrolled thread

[PATCH] of: Add EXPORT_SYMBOL for of_device_compatible_match

Started byNeil Armstrong <narmstrong@baylibre.com>
First post2017-01-16 14:20 +0100
Last post2017-01-16 16:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] of: Add EXPORT_SYMBOL for of_device_compatible_match Neil Armstrong <narmstrong@baylibre.com> - 2017-01-16 14:20 +0100
    Re: [PATCH] of: Add EXPORT_SYMBOL for of_device_compatible_match Rob Herring <robh+dt@kernel.org> - 2017-01-16 16:40 +0100

#1559703 — [PATCH] of: Add EXPORT_SYMBOL for of_device_compatible_match

FromNeil Armstrong <narmstrong@baylibre.com>
Date2017-01-16 14:20 +0100
Subject[PATCH] of: Add EXPORT_SYMBOL for of_device_compatible_match
Message-ID<t0fmx-Sv-1@gated-at.bofh.it>
Add missing EXPORT_SYMBOL for of_device_compatible_match function.

Fixes: b9c13fe32faa ("dt: Add of_device_compatible_match()")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/of/base.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index d4bea3c..dfbcf17 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -523,6 +523,7 @@ int of_device_compatible_match(struct device_node *device,
 
 	return score;
 }
+EXPORT_SYMBOL(of_device_compatible_match);
 
 /**
  * of_machine_is_compatible - Test root of device tree for a given compatible value
-- 
1.9.1

[toc] | [next] | [standalone]


#1559841

FromRob Herring <robh+dt@kernel.org>
Date2017-01-16 16:40 +0100
Message-ID<t0hy2-2jl-5@gated-at.bofh.it>
In reply to#1559703
On Mon, Jan 16, 2017 at 7:11 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> Add missing EXPORT_SYMBOL for of_device_compatible_match function.

It's not missing because no modules use it. It's generally preferred
to use a match table and of_match_node.

Rob

>
> Fixes: b9c13fe32faa ("dt: Add of_device_compatible_match()")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/of/base.c | 1 +
>  1 file changed, 1 insertion(+)

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web