Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1558888 > unrolled thread

[PATCH tip/core/rcu 08/20] rcu: Add long-term CPU kicking

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH tip/core/rcu 08/20] rcu: Add long-term CPU kicking "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-14 10:20 +0100
    Re: [PATCH tip/core/rcu 08/20] rcu: Add long-term CPU kicking Josh Triplett <josh@joshtriplett.org> - 2017-01-16 09:00 +0100
      Re: [PATCH tip/core/rcu 08/20] rcu: Add long-term CPU kicking "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-17 02:10 +0100

#1558888 — [PATCH tip/core/rcu 08/20] rcu: Add long-term CPU kicking

Commit d2db185bfee8 ("rcu: Remove short-term CPU kicking") removed
frequent calls to resched_cpu(), which means that the only time
resched_cpu() is invoked is after an RCU CPU stall warning.  Although
this is good from an avoid-IPIs perspective, we should try to break
things loose -before- splatting.  This commit therefore starts invoking
resched_cpu() for each holdout at each force-quiescent-state interval
that is more than halfway through the stall-warning interval.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/rcu/tree.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 3c0d6c129718..5a4aaad75e76 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1220,6 +1220,13 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp,
 		rdp->rsp->jiffies_resched += 5; /* Re-enable beating. */
 	}
 
+	/*
+	 * If more than halfway to RCU CPU stall-warning time, do
+	 * a resched_cpu() to try to loosen things up a bit.
+	 */
+	if (jiffies - rdp->rsp->gp_start > rcu_jiffies_till_stall_check() / 2)
+		resched_cpu(rdp->cpu);
+
 	return 0;
 }
 
-- 
2.5.2

[toc] | [next] | [standalone]

#1559502

On Sat, Jan 14, 2017 at 01:13:09AM -0800, Paul E. McKenney wrote:
> Commit d2db185bfee8 ("rcu: Remove short-term CPU kicking") removed
> frequent calls to resched_cpu(), which means that the only time
> resched_cpu() is invoked is after an RCU CPU stall warning.  Although
> this is good from an avoid-IPIs perspective, we should try to break
> things loose -before- splatting.  This commit therefore starts invoking
> resched_cpu() for each holdout at each force-quiescent-state interval
> that is more than halfway through the stall-warning interval.
> 
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Could you please reverse the order of patches 7 and 8, so that
unnecessary splats don't occur between the two?

For the patch itself:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  kernel/rcu/tree.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 3c0d6c129718..5a4aaad75e76 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -1220,6 +1220,13 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp,
>  		rdp->rsp->jiffies_resched += 5; /* Re-enable beating. */
>  	}
>  
> +	/*
> +	 * If more than halfway to RCU CPU stall-warning time, do
> +	 * a resched_cpu() to try to loosen things up a bit.
> +	 */
> +	if (jiffies - rdp->rsp->gp_start > rcu_jiffies_till_stall_check() / 2)
> +		resched_cpu(rdp->cpu);
> +
>  	return 0;
>  }
>  
> -- 
> 2.5.2
> 

[toc] | [prev] | [next] | [standalone]

#1560198

On Sun, Jan 15, 2017 at 11:58:07PM -0800, Josh Triplett wrote:
> On Sat, Jan 14, 2017 at 01:13:09AM -0800, Paul E. McKenney wrote:
> > Commit d2db185bfee8 ("rcu: Remove short-term CPU kicking") removed
> > frequent calls to resched_cpu(), which means that the only time
> > resched_cpu() is invoked is after an RCU CPU stall warning.  Although
> > this is good from an avoid-IPIs perspective, we should try to break
> > things loose -before- splatting.  This commit therefore starts invoking
> > resched_cpu() for each holdout at each force-quiescent-state interval
> > that is more than halfway through the stall-warning interval.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> 
> Could you please reverse the order of patches 7 and 8, so that
> unnecessary splats don't occur between the two?

Done!

							Thanx, Paul

> For the patch itself:
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> 
> >  kernel/rcu/tree.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > index 3c0d6c129718..5a4aaad75e76 100644
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -1220,6 +1220,13 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp,
> >  		rdp->rsp->jiffies_resched += 5; /* Re-enable beating. */
> >  	}
> >  
> > +	/*
> > +	 * If more than halfway to RCU CPU stall-warning time, do
> > +	 * a resched_cpu() to try to loosen things up a bit.
> > +	 */
> > +	if (jiffies - rdp->rsp->gp_start > rcu_jiffies_till_stall_check() / 2)
> > +		resched_cpu(rdp->cpu);
> > +
> >  	return 0;
> >  }
> >  
> > -- 
> > 2.5.2
> > 
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web