Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561709 > unrolled thread

[RFC PATCH 0/3] Remove some dummy set_power callbacks

Back to article view | Back to linux.kernel

Contents

  [RFC PATCH 0/3] Remove some dummy set_power callbacks Baolin Wang <baolin.wang@linaro.org> - 2017-01-18 13:30 +0100
    [RFC PATCH 2/3] usb: phy: msm: Remove the set_power callback Baolin Wang <baolin.wang@linaro.org> - 2017-01-18 13:30 +0100

#1561709 — [RFC PATCH 0/3] Remove some dummy set_power callbacks

In future we plan to introduce USB charger to set PMIC current drawn from
USB configuration, instead of using set_power callback in phy driver. Moreover
in these 3 phy drivers, the set_power callback did not implement anything
to set PMIC current, thus we should remove them.

Baolin Wang (3):
  usb: phy: ab8500: Remove the set_power callback
  usb: phy: msm: Remove the set_power callback
  usb: phy: fsl: Remove the set_power callback

 drivers/usb/phy/phy-ab8500-usb.c |   20 --------------------
 drivers/usb/phy/phy-fsl-usb.c    |   12 ------------
 drivers/usb/phy/phy-msm-usb.c    |   18 ------------------
 3 files changed, 50 deletions(-)

-- 
1.7.9.5

[toc] | [next] | [standalone]

#1561714 — [RFC PATCH 2/3] usb: phy: msm: Remove the set_power callback

Since it will not set the PMIC current drawn from USB configuration by
set_power callback, then remove it.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
 drivers/usb/phy/phy-msm-usb.c |   18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 8a34759..9e52890 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -842,23 +842,6 @@ static void msm_otg_notify_charger(struct msm_otg *motg, unsigned mA)
 	motg->cur_power = mA;
 }
 
-static int msm_otg_set_power(struct usb_phy *phy, unsigned mA)
-{
-	struct msm_otg *motg = container_of(phy, struct msm_otg, phy);
-
-	/*
-	 * Gadget driver uses set_power method to notify about the
-	 * available current based on suspend/configured states.
-	 *
-	 * IDEV_CHG can be drawn irrespective of suspend/un-configured
-	 * states when CDP/ACA is connected.
-	 */
-	if (motg->chg_type == USB_SDP_CHARGER)
-		msm_otg_notify_charger(motg, mA);
-
-	return 0;
-}
-
 static void msm_otg_start_host(struct usb_phy *phy, int on)
 {
 	struct msm_otg *motg = container_of(phy, struct msm_otg, phy);
@@ -1950,7 +1933,6 @@ static int msm_otg_probe(struct platform_device *pdev)
 	}
 
 	phy->init = msm_phy_init;
-	phy->set_power = msm_otg_set_power;
 	phy->notify_disconnect = msm_phy_notify_disconnect;
 	phy->type = USB_PHY_TYPE_USB2;
 
-- 
1.7.9.5

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web