Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1561699 > unrolled thread

Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias string

Started byJiri Olsa <jolsa@redhat.com>
First post2017-01-18 13:30 +0100
Last post2017-01-18 17:30 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias  string Jiri Olsa <jolsa@redhat.com> - 2017-01-18 13:30 +0100
    Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias  string Andi Kleen <ak@linux.intel.com> - 2017-01-18 16:50 +0100
      Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias  string Jiri Olsa <jolsa@redhat.com> - 2017-01-18 17:30 +0100

#1561699 — Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias string

FromJiri Olsa <jolsa@redhat.com>
Date2017-01-18 13:30 +0100
SubjectRe: [PATCH 06/11] perf, tools: Add debug support for outputing alias string
Message-ID<t0Xxg-430-9@gated-at.bofh.it>
On Tue, Jan 03, 2017 at 07:08:28AM -0800, Andi Kleen wrote:

SNIP

> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 4bfc98953aba..e0c43698fd62 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -275,6 +275,8 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
>  		snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
>  	}
>  	alias->per_pkg = perpkg && sscanf(perpkg, "%d", &num) == 1 && num == 1;
> +	alias->str = strdup(val);

where's this one released?

jirka

[toc] | [next] | [standalone]


#1561908

FromAndi Kleen <ak@linux.intel.com>
Date2017-01-18 16:50 +0100
Message-ID<t10EO-5Sv-5@gated-at.bofh.it>
In reply to#1561699
On Wed, Jan 18, 2017 at 01:16:06PM +0100, Jiri Olsa wrote:
> On Tue, Jan 03, 2017 at 07:08:28AM -0800, Andi Kleen wrote:
> 
> SNIP
> 
> > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > index 4bfc98953aba..e0c43698fd62 100644
> > --- a/tools/perf/util/pmu.c
> > +++ b/tools/perf/util/pmu.c
> > @@ -275,6 +275,8 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> >  		snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
> >  	}
> >  	alias->per_pkg = perpkg && sscanf(perpkg, "%d", &num) == 1 && num == 1;
> > +	alias->str = strdup(val);
> 
> where's this one released?

Aliases are never released AFAIK?

-Andi

[toc] | [prev] | [next] | [standalone]


#1561938

FromJiri Olsa <jolsa@redhat.com>
Date2017-01-18 17:30 +0100
Message-ID<t11hw-6lt-15@gated-at.bofh.it>
In reply to#1561908
On Wed, Jan 18, 2017 at 07:45:09AM -0800, Andi Kleen wrote:
> On Wed, Jan 18, 2017 at 01:16:06PM +0100, Jiri Olsa wrote:
> > On Tue, Jan 03, 2017 at 07:08:28AM -0800, Andi Kleen wrote:
> > 
> > SNIP
> > 
> > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > > index 4bfc98953aba..e0c43698fd62 100644
> > > --- a/tools/perf/util/pmu.c
> > > +++ b/tools/perf/util/pmu.c
> > > @@ -275,6 +275,8 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> > >  		snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
> > >  	}
> > >  	alias->per_pkg = perpkg && sscanf(perpkg, "%d", &num) == 1 && num == 1;
> > > +	alias->str = strdup(val);
> > 
> > where's this one released?
> 
> Aliases are never released AFAIK?

ok, I misplaced that one with the one from sevent struct.. sry

jirka

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web