Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560891 > unrolled thread

Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF Mark Brown <broonie@kernel.org> - 2017-01-17 19:20 +0100
    Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF Code Kipper <codekipper@gmail.com> - 2017-01-18 08:20 +0100
      Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to  SPDIF Mark Brown <broonie@kernel.org> - 2017-01-19 18:10 +0100
        Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF Code Kipper <codekipper@gmail.com> - 2017-01-19 22:40 +0100

#1560891 — Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jan 12, 2017 at 06:33:43PM +0100, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
> 
> The H3 SoC uses the same SPDIF block as found in earlier SoCs, but the
> transmit fifo is at a different address.
> 
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
>  Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt | 1 +
>  1 file changed, 1 insertion(+)

This is fine but it doesn't actually add the compatible string to the
driver which I'd expect.

[toc] | [next] | [standalone]

#1561331 — Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

On 17 January 2017 at 19:15, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Jan 12, 2017 at 06:33:43PM +0100, codekipper@gmail.com wrote:
>> From: Marcus Cooper <codekipper@gmail.com>
>>
>> The H3 SoC uses the same SPDIF block as found in earlier SoCs, but the
>> transmit fifo is at a different address.
>>
>> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/sound/sunxi,sun4i-spdif.txt | 1 +
>>  1 file changed, 1 insertion(+)
>
> This is fine but it doesn't actually add the compatible string to the
> driver which I'd expect.
Hi Mark,
I missed the binding documentation on the patch for the driver so I
pushed it separately instead of pushing a new patch version.
You can find it under the subject heading 'ASoC: sun4i-spdif: Add
support for the H3 SoC' and Maxime has ACK it (on the condition that I
add the binding doc).
BR,
CK
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[toc] | [prev] | [next] | [standalone]

#1562941 — Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jan 18, 2017 at 08:09:00AM +0100, Code Kipper wrote:

> I missed the binding documentation on the patch for the driver so I
> pushed it separately instead of pushing a new patch version.
> You can find it under the subject heading 'ASoC: sun4i-spdif: Add
> support for the H3 SoC' and Maxime has ACK it (on the condition that I
> add the binding doc).

I don't seem to have that patch.  If Maxime said it needed changes for
him to ack it there's every chance I just deleted it waiting for you to
resend, it's certainly confusing to see a patch like this without the
matching code.

[toc] | [prev] | [next] | [standalone]

#1563110 — Re: [linux-sunxi] Re: [PATCH] ASoC: sunxi: Add bindings for sun8i to SPDIF

On 19 January 2017 at 18:03, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jan 18, 2017 at 08:09:00AM +0100, Code Kipper wrote:
>
>> I missed the binding documentation on the patch for the driver so I
>> pushed it separately instead of pushing a new patch version.
>> You can find it under the subject heading 'ASoC: sun4i-spdif: Add
>> support for the H3 SoC' and Maxime has ACK it (on the condition that I
>> add the binding doc).
>
> I don't seem to have that patch.  If Maxime said it needed changes for
> him to ack it there's every chance I just deleted it waiting for you to
> resend, it's certainly confusing to see a patch like this without the
> matching code.
No worries...I'll squash this patch into it and send as a V2.
CK

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web