Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1561198 > unrolled thread

[PATCH] ARM: dts: sun6i: sina31s: Enable USB OTG controller in peripheral mode

Started byChen-Yu Tsai <wens@csie.org>
First post2017-01-18 02:10 +0100
Last post2017-01-18 08:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] ARM: dts: sun6i: sina31s: Enable USB OTG controller in peripheral mode Chen-Yu Tsai <wens@csie.org> - 2017-01-18 02:10 +0100
    Re: [PATCH] ARM: dts: sun6i: sina31s: Enable USB OTG controller in  peripheral mode Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-01-18 08:50 +0100

#1561198 — [PATCH] ARM: dts: sun6i: sina31s: Enable USB OTG controller in peripheral mode

FromChen-Yu Tsai <wens@csie.org>
Date2017-01-18 02:10 +0100
Subject[PATCH] ARM: dts: sun6i: sina31s: Enable USB OTG controller in peripheral mode
Message-ID<t0MVb-5Vf-9@gated-at.bofh.it>
While the SinA31s does have a proper 5-pin mini USB OTG port, the ID
pin does not seem to work. The pin used in the schematics is always low,
regardless of the attached OTG cable or SoC internal pin bias settings.

The v1.5 board is missing bias resistors shown in the schematics for
earlier revisions, and the connections of the remaining one does not
match the schematics either.

In addition, VBUS for this port is disconnected from the board's 5V
power rail. The board features a pad to solder jumper pins to connect
VBUS to 5V manually.

Given the above and the fact that the board has 5 more USB host ports,
it makes more sense to have the OTG port work in peripheral mode.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
index 8743aeed1275..7ff68bdd7109 100644
--- a/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
+++ b/arch/arm/boot/dts/sun6i-a31s-sina31s.dts
@@ -153,6 +153,11 @@
 	regulator-name = "vcc-gmac-phy";
 };
 
+&usb_otg {
+	dr_mode = "peripheral";
+	status = "okay";
+};
+
 &usbphy {
 	status = "okay";
 };
-- 
2.11.0

[toc] | [next] | [standalone]


#1561341 — Re: [PATCH] ARM: dts: sun6i: sina31s: Enable USB OTG controller in peripheral mode

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-01-18 08:50 +0100
SubjectRe: [PATCH] ARM: dts: sun6i: sina31s: Enable USB OTG controller in peripheral mode
Message-ID<t0Tah-1cB-5@gated-at.bofh.it>
In reply to#1561198

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jan 18, 2017 at 09:01:05AM +0800, Chen-Yu Tsai wrote:
> While the SinA31s does have a proper 5-pin mini USB OTG port, the ID
> pin does not seem to work. The pin used in the schematics is always low,
> regardless of the attached OTG cable or SoC internal pin bias settings.
> 
> The v1.5 board is missing bias resistors shown in the schematics for
> earlier revisions, and the connections of the remaining one does not
> match the schematics either.
> 
> In addition, VBUS for this port is disconnected from the board's 5V
> power rail. The board features a pad to solder jumper pins to connect
> VBUS to 5V manually.
> 
> Given the above and the fact that the board has 5 more USB host ports,
> it makes more sense to have the OTG port work in peripheral mode.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web