Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560362 > unrolled thread

[PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem Michal Hocko <mhocko@kernel.org> - 2017-01-17 10:20 +0100
    Re: [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-17 10:40 +0100
    Re: [PATCH 1/4] mm, page_alloc: do not report all nodes in  show_mem David Rientjes <rientjes@google.com> - 2017-01-18 00:00 +0100

#1560362 — [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem

From: Michal Hocko <mhocko@suse.com>

599d0c954f91 ("mm, vmscan: move LRU lists to node") has added per numa
node statistics to show_mem but it forgot to add skip_free_areas_node
to fileter out nodes which are outside of the allocating task numa
policy. Add this check to not pollute the output with the pointless
information.

Acked-by: Mel Gorman <mgorman@suse.de>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 mm/page_alloc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 8ff25883c172..8f4f306d804c 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4345,6 +4345,9 @@ void show_free_areas(unsigned int filter)
 		global_page_state(NR_FREE_CMA_PAGES));
 
 	for_each_online_pgdat(pgdat) {
+		if (skip_free_areas_node(filter, pgdat->node_id))
+			continue;
+
 		printk("Node %d"
 			" active_anon:%lukB"
 			" inactive_anon:%lukB"
-- 
2.11.0

[toc] | [next] | [standalone]

#1560396

On Tuesday, January 17, 2017 5:16 PM Michal Hocko wrote: 
> 
> From: Michal Hocko <mhocko@suse.com>
> 
> 599d0c954f91 ("mm, vmscan: move LRU lists to node") has added per numa
> node statistics to show_mem but it forgot to add skip_free_areas_node
> to fileter out nodes which are outside of the allocating task numa
> policy. Add this check to not pollute the output with the pointless
> information.
> 
> Acked-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>

>  mm/page_alloc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 8ff25883c172..8f4f306d804c 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4345,6 +4345,9 @@ void show_free_areas(unsigned int filter)
>  		global_page_state(NR_FREE_CMA_PAGES));
> 
>  	for_each_online_pgdat(pgdat) {
> +		if (skip_free_areas_node(filter, pgdat->node_id))
> +			continue;
> +
>  		printk("Node %d"
>  			" active_anon:%lukB"
>  			" inactive_anon:%lukB"
> --
> 2.11.0

[toc] | [prev] | [next] | [standalone]

#1561077 — Re: [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem

On Tue, 17 Jan 2017, Michal Hocko wrote:

> From: Michal Hocko <mhocko@suse.com>
> 
> 599d0c954f91 ("mm, vmscan: move LRU lists to node") has added per numa
> node statistics to show_mem but it forgot to add skip_free_areas_node
> to fileter out nodes which are outside of the allocating task numa
> policy. Add this check to not pollute the output with the pointless
> information.
> 
> Acked-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Michal Hocko <mhocko@suse.com>

s/fileter/filter/

Acked-by: David Rientjes <rientjes@google.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web