Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1560051 > unrolled thread
| Started by | Vineet Gupta <Vineet.Gupta1@synopsys.com> |
|---|---|
| First post | 2017-01-16 22:00 +0100 |
| Last post | 2017-01-17 21:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores when one halts Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-01-16 22:00 +0100
RE: [PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores when one halts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-01-17 21:20 +0100
| From | Vineet Gupta <Vineet.Gupta1@synopsys.com> |
|---|---|
| Date | 2017-01-16 22:00 +0100 |
| Subject | [PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores when one halts |
| Message-ID | <t0mxI-5SC-11@gated-at.bofh.it> |
This was really usefull when doing initial bringup and also for
occassional debug of software and hardware bugs. However in the new
smp-boot regime, non masters will "self" halt even for run-on-reset
configs. This will misinteract with the debug feature as in even master
will get halted when the non masters self halt.
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
arch/arc/kernel/mcip.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arc/kernel/mcip.c b/arch/arc/kernel/mcip.c
index f39142acc89e..933382e0edd0 100644
--- a/arch/arc/kernel/mcip.c
+++ b/arch/arc/kernel/mcip.c
@@ -101,11 +101,6 @@ static void mcip_probe_n_setup(void)
IS_AVAIL1(mp.gfrc, "GFRC"));
cpuinfo_arc700[0].extn.gfrc = mp.gfrc;
-
- if (mp.dbg) {
- __mcip_cmd_data(CMD_DEBUG_SET_SELECT, 0, 0xf);
- __mcip_cmd_data(CMD_DEBUG_SET_MASK, 0xf, 0xf);
- }
}
struct plat_smp_ops plat_smp_ops = {
--
2.7.4
[toc] | [next] | [standalone]
| From | Alexey Brodkin <Alexey.Brodkin@synopsys.com> |
|---|---|
| Date | 2017-01-17 21:20 +0100 |
| Subject | RE: [PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores when one halts |
| Message-ID | <t0Ioy-38E-23@gated-at.bofh.it> |
| In reply to | #1560051 |
Hi Vineet,
> -----Original Message-----
> From: Vineet Gupta
> Sent: Monday, January 16, 2017 11:58 PM
> To: linux-snps-arc@lists.infradead.org; Alexey Brodkin
> <abrodkin@synopsys.com>
> Cc: linux-kernel@vger.kernel.org; Vineet Gupta <vgupta@synopsys.com>
> Subject: [PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores
> when one halts
>
> This was really usefull when doing initial bringup and also for occassional
> debug of software and hardware bugs. However in the new smp-boot
> regime, non masters will "self" halt even for run-on-reset configs. This will
> misinteract with the debug feature as in even master will get halted when
> the non masters self halt.
>
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> ---
> arch/arc/kernel/mcip.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arc/kernel/mcip.c b/arch/arc/kernel/mcip.c index
> f39142acc89e..933382e0edd0 100644
> --- a/arch/arc/kernel/mcip.c
> +++ b/arch/arc/kernel/mcip.c
> @@ -101,11 +101,6 @@ static void mcip_probe_n_setup(void)
> IS_AVAIL1(mp.gfrc, "GFRC"));
>
> cpuinfo_arc700[0].extn.gfrc = mp.gfrc;
> -
> - if (mp.dbg) {
> - __mcip_cmd_data(CMD_DEBUG_SET_SELECT, 0, 0xf);
> - __mcip_cmd_data(CMD_DEBUG_SET_MASK, 0xf, 0xf);
> - }
> }
I've been doing that for quite some time locally because that used to be a must
for execution of SMP vmlinux in "pseudo"-UP mode, i.e. on SMP hardware but
with only 1 core being used.
I'm really happy to see this commit upstream - will definitely make life a bit simpler.
-Alexey
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web