Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515066 > unrolled thread
| Started by | Maninder Singh <maninder.s2@samsung.com> |
|---|---|
| First post | 2016-11-04 09:10 +0100 |
| Last post | 2016-11-04 10:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: st-cec: add parentheses around complex macros Maninder Singh <maninder.s2@samsung.com> - 2016-11-04 09:10 +0100
Re: [PATCH] staging: st-cec: add parentheses around complex macros Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2016-11-04 10:10 +0100
| From | Maninder Singh <maninder.s2@samsung.com> |
|---|---|
| Date | 2016-11-04 09:10 +0100 |
| Subject | [PATCH] staging: st-cec: add parentheses around complex macros |
| Message-ID | <szHJv-7wH-13@gated-at.bofh.it> |
This patch fixes the following checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Maninder Singh <maninder.s2@samsung.com> --- drivers/staging/media/st-cec/stih-cec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c index 2143448..b22394a 100644 --- a/drivers/staging/media/st-cec/stih-cec.c +++ b/drivers/staging/media/st-cec/stih-cec.c @@ -108,11 +108,11 @@ /* Constants for CEC_BIT_TOUT_THRESH register */ #define CEC_SBIT_TOUT_47MS BIT(1) -#define CEC_SBIT_TOUT_48MS BIT(0) | BIT(1) +#define CEC_SBIT_TOUT_48MS (BIT(0) | BIT(1)) #define CEC_SBIT_TOUT_50MS BIT(2) #define CEC_DBIT_TOUT_27MS BIT(0) #define CEC_DBIT_TOUT_28MS BIT(1) -#define CEC_DBIT_TOUT_29MS BIT(0) | BIT(1) +#define CEC_DBIT_TOUT_29MS (BIT(0) | BIT(1)) /* Constants for CEC_BIT_PULSE_THRESH register */ #define CEC_BIT_LPULSE_03MS BIT(1) -- 1.7.9.5
[toc] | [next] | [standalone]
| From | Benjamin Gaignard <benjamin.gaignard@linaro.org> |
|---|---|
| Date | 2016-11-04 10:10 +0100 |
| Message-ID | <szIFA-87W-9@gated-at.bofh.it> |
| In reply to | #1515066 |
Thanks, Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> 2016-11-04 8:58 GMT+01:00 Maninder Singh <maninder.s2@samsung.com>: > This patch fixes the following checkpatch.pl error: > ERROR: Macros with complex values should be enclosed in parentheses > > Signed-off-by: Maninder Singh <maninder.s2@samsung.com> > --- > drivers/staging/media/st-cec/stih-cec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c > index 2143448..b22394a 100644 > --- a/drivers/staging/media/st-cec/stih-cec.c > +++ b/drivers/staging/media/st-cec/stih-cec.c > @@ -108,11 +108,11 @@ > > /* Constants for CEC_BIT_TOUT_THRESH register */ > #define CEC_SBIT_TOUT_47MS BIT(1) > -#define CEC_SBIT_TOUT_48MS BIT(0) | BIT(1) > +#define CEC_SBIT_TOUT_48MS (BIT(0) | BIT(1)) > #define CEC_SBIT_TOUT_50MS BIT(2) > #define CEC_DBIT_TOUT_27MS BIT(0) > #define CEC_DBIT_TOUT_28MS BIT(1) > -#define CEC_DBIT_TOUT_29MS BIT(0) | BIT(1) > +#define CEC_DBIT_TOUT_29MS (BIT(0) | BIT(1)) > > /* Constants for CEC_BIT_PULSE_THRESH register */ > #define CEC_BIT_LPULSE_03MS BIT(1) > -- > 1.7.9.5 > -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web