Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1511555 > unrolled thread

[PATCH 16/60] block: pktcdvd: comment on direct access to bvec table

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 16/60] block: pktcdvd: comment on direct access to bvec table Ming Lei <tom.leiming@gmail.com> - 2016-10-29 10:20 +0200
    Re: [PATCH 16/60] block: pktcdvd: comment on direct access to bvec  table Christoph Hellwig <hch@infradead.org> - 2016-10-31 16:40 +0100
      Re: [PATCH 16/60] block: pktcdvd: comment on direct access to bvec table Ming Lei <tom.leiming@gmail.com> - 2016-11-01 00:10 +0100

#1511555 — [PATCH 16/60] block: pktcdvd: comment on direct access to bvec table

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 drivers/block/pktcdvd.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 90fa4ac149db..817d2cc17d01 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -1298,6 +1298,11 @@ static int pkt_handle_queue(struct pktcdvd_device *pd)
 static void pkt_start_write(struct pktcdvd_device *pd, struct packet_data *pkt)
 {
 	int f;
+
+	/*
+	 * Need to fix this usage for supporting multipage bvecs,
+	 * because the table can be changed in pkt_make_local_copy().
+	 */
 	struct bio_vec *bvec = pkt->w_bio->bi_io_vec;
 
 	bio_reset(pkt->w_bio);
-- 
2.7.4

[toc] | [next] | [standalone]

#1512625 — Re: [PATCH 16/60] block: pktcdvd: comment on direct access to bvec table

Please pick up my "pktcdvd: don't scribble over the bvec array"
patch instead of the pktcdvd patches in this series.

[toc] | [prev] | [next] | [standalone]

#1512983

On Mon, Oct 31, 2016 at 11:33 PM, Christoph Hellwig <hch@infradead.org> wrote:
> Please pick up my "pktcdvd: don't scribble over the bvec array"
> patch instead of the pktcdvd patches in this series.

OK.

Thanks,
Ming Lei

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web