Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512859 > unrolled thread

[PATCH] platform/x86/asus-nb-wmi.c: Add X45U quirk

Back to article view | Back to linux.kernel

Contents

  [PATCH] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-10-31 21:30 +0100
    Re: [PATCH] platform/x86/asus-nb-wmi.c: Add X45U quirk Greg KH <gregkh@linuxfoundation.org> - 2016-10-31 22:40 +0100
    Re: [PATCH] platform/x86/asus-nb-wmi.c: Add X45U quirk Darren Hart <dvhart@infradead.org> - 2016-10-31 23:20 +0100
      Re: [PATCH] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-11-01 01:30 +0100
      Re: [PATCH] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-11-01 03:10 +0100

#1512859 — [PATCH] platform/x86/asus-nb-wmi.c: Add X45U quirk

Without this patch, the Asus X45U wireless card can't be turned
on (hard-blocked), but after a suspend/resume it just starts working.

Following this bug report[1], there are other cases like this one, but
this Asus is the only model that I can test.

[1] https://ubuntuforums.org/showthread.php?t=2181558

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 26e4cbc..6032b70 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -175,6 +175,15 @@ static const struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X45U",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X45U"),
+		},
+		.driver_data = &quirk_asus_wapf4,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. X456UA",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
2.7.4

[toc] | [next] | [standalone]

#1512922

On Mon, Oct 31, 2016 at 06:21:12PM -0200, Marcos Paulo de Souza wrote:
> Without this patch, the Asus X45U wireless card can't be turned
> on (hard-blocked), but after a suspend/resume it just starts working.
> 
> Following this bug report[1], there are other cases like this one, but
> this Asus is the only model that I can test.
> 
> [1] https://ubuntuforums.org/showthread.php?t=2181558
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

[toc] | [prev] | [next] | [standalone]

#1512944

On Mon, Oct 31, 2016 at 06:21:12PM -0200, Marcos Paulo de Souza wrote:
> Without this patch, the Asus X45U wireless card can't be turned
> on (hard-blocked), but after a suspend/resume it just starts working.
> 
> Following this bug report[1], there are other cases like this one, but
> this Asus is the only model that I can test.
> 
> [1] https://ubuntuforums.org/showthread.php?t=2181558
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Thanks Marcos,

As Greg pointed out, if you want this to go back to stable, you need to
add the Cc: stable tag below your Signed-off-by. I also ask that you
attempt to apply this yourself before sending it back to stable. Does it
apply to 4.8? 4.1? 3.18? How far back do you want to see this backported
to stable?

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1513008

Hi Daren and Greg,

On Mon, Oct 31, 2016 at 03:14:05PM -0700, Darren Hart wrote:
> On Mon, Oct 31, 2016 at 06:21:12PM -0200, Marcos Paulo de Souza wrote:
> > Without this patch, the Asus X45U wireless card can't be turned
> > on (hard-blocked), but after a suspend/resume it just starts working.
> > 
> > Following this bug report[1], there are other cases like this one, but
> > this Asus is the only model that I can test.
> > 
> > [1] https://ubuntuforums.org/showthread.php?t=2181558
> > 
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> 
> Thanks Marcos,
> 
> As Greg pointed out, if you want this to go back to stable, you need to
> add the Cc: stable tag below your Signed-off-by. I also ask that you
> attempt to apply this yourself before sending it back to stable. Does it
> apply to 4.8? 4.1? 3.18? How far back do you want to see this backported
> to stable?

Sorry, first time sending a patch to stable. I'm cloning stable here to check if this patch applies smoothly on 4.8 and 4.1, and then resend it to stable. This patch was based in 4.9-rc3, so it can be queued to rc4, since it fixes a problem to all users of this model.

Thanks Daren and Greg for guiding me in the right path of stable :)

> 
> -- 
> Darren Hart
> Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1513047

Hi Darren and Greg,

On Mon, Oct 31, 2016 at 03:14:05PM -0700, Darren Hart wrote:
> On Mon, Oct 31, 2016 at 06:21:12PM -0200, Marcos Paulo de Souza wrote:
> > Without this patch, the Asus X45U wireless card can't be turned
> > on (hard-blocked), but after a suspend/resume it just starts working.
> > 
> > Following this bug report[1], there are other cases like this one, but
> > this Asus is the only model that I can test.
> > 
> > [1] https://ubuntuforums.org/showthread.php?t=2181558
> > 
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> 
> Thanks Marcos,
> 
> As Greg pointed out, if you want this to go back to stable, you need to
> add the Cc: stable tag below your Signed-off-by. I also ask that you
> attempt to apply this yourself before sending it back to stable. Does it
> apply to 4.8? 4.1? 3.18? How far back do you want to see this backported
> to stable?
> 

I sent a new version right now, specifying 4.8.6 and 4.4.29. Hope it's correct now!

Thanks,

> -- 
> Darren Hart
> Intel Open Source Technology Center

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web