Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512585 > unrolled thread

[PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-31 15:50 +0100
    Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-31 21:30 +0100
      Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes Kevin Hilman <khilman@baylibre.com> - 2016-10-31 21:50 +0100

#1512585 — [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes

Enable the MSTPRI configuration and DDR2/mDDR memory controller
nodes on da850-lcdk. This is needed in order to adjust the memory
throughput constraints for better tilcdc support.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index 4747629..b39796e 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -243,3 +243,11 @@
 		};
 	};
 };
+
+&mstpri {
+	status = "okay";
+};
+
+&ddrctl {
+	status = "okay";
+};
-- 
2.9.3

[toc] | [next] | [standalone]

#1512855

Hi Bartosz,

Thank you for the patch.

On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote:
> Enable the MSTPRI configuration and DDR2/mDDR memory controller
> nodes on da850-lcdk. This is needed in order to adjust the memory
> throughput constraints for better tilcdc support.

Is there a reason not to enable these unconditionally in da850.dtsi (or rather 
not disabling them) instead of handling it per board ?

> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/da850-lcdk.dts
> b/arch/arm/boot/dts/da850-lcdk.dts index 4747629..b39796e 100644
> --- a/arch/arm/boot/dts/da850-lcdk.dts
> +++ b/arch/arm/boot/dts/da850-lcdk.dts
> @@ -243,3 +243,11 @@
>  		};
>  	};
>  };
> +
> +&mstpri {
> +	status = "okay";
> +};
> +
> +&ddrctl {
> +	status = "okay";
> +};

-- 
Regards,

Laurent Pinchart

[toc] | [prev] | [next] | [standalone]

#1512889

Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:

> Hi Bartosz,
>
> Thank you for the patch.
>
> On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote:
>> Enable the MSTPRI configuration and DDR2/mDDR memory controller
>> nodes on da850-lcdk. This is needed in order to adjust the memory
>> throughput constraints for better tilcdc support.
>
> Is there a reason not to enable these unconditionally in da850.dtsi (or rather 
> not disabling them) instead of handling it per board ?

Right.  They should be enabled by default in DT.  The drivers already
have board-specific compatible checks.

Kevin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web