Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1512814 > unrolled thread

[PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity

Started byHannes Reinecke <hare@suse.de>
First post2016-10-31 20:40 +0100
Last post2016-10-31 22:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity Hannes Reinecke <hare@suse.de> - 2016-10-31 20:40 +0100
    Re: [PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity Ming Lei <tom.leiming@gmail.com> - 2016-10-31 22:30 +0100

#1512814 — [PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity

FromHannes Reinecke <hare@suse.de>
Date2016-10-31 20:40 +0100
Subject[PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity
Message-ID<syqB3-6Fs-3@gated-at.bofh.it>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 drivers/block/loop.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index fa1b7a9..3008dec 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1298,7 +1298,7 @@ loop_get_status64(struct loop_device *lo, struct loop_info64 __user *arg) {
 	return err;
 }
 
-static int loop_set_capacity(struct loop_device *lo, struct block_device *bdev)
+static int loop_set_capacity(struct loop_device *lo)
 {
 	if (unlikely(lo->lo_state != Lo_bound))
 		return -ENXIO;
@@ -1361,7 +1361,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode,
 	case LOOP_SET_CAPACITY:
 		err = -EPERM;
 		if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN))
-			err = loop_set_capacity(lo, bdev);
+			err = loop_set_capacity(lo);
 		break;
 	case LOOP_SET_DIRECT_IO:
 		err = -EPERM;
-- 
2.6.6

[toc] | [next] | [standalone]


#1512913

FromMing Lei <tom.leiming@gmail.com>
Date2016-10-31 22:30 +0100
Message-ID<sysjv-7Pf-13@gated-at.bofh.it>
In reply to#1512814
On Tue, Nov 1, 2016 at 3:37 AM, Hannes Reinecke <hare@suse.de> wrote:
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/block/loop.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index fa1b7a9..3008dec 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1298,7 +1298,7 @@ loop_get_status64(struct loop_device *lo, struct loop_info64 __user *arg) {
>         return err;
>  }
>
> -static int loop_set_capacity(struct loop_device *lo, struct block_device *bdev)
> +static int loop_set_capacity(struct loop_device *lo)
>  {
>         if (unlikely(lo->lo_state != Lo_bound))
>                 return -ENXIO;
> @@ -1361,7 +1361,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode,
>         case LOOP_SET_CAPACITY:
>                 err = -EPERM;
>                 if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN))
> -                       err = loop_set_capacity(lo, bdev);
> +                       err = loop_set_capacity(lo);
>                 break;
>         case LOOP_SET_DIRECT_IO:
>                 err = -EPERM;

Reviewed-by: Ming Lei <tom.leiming@gmail.com>


thanks,
Ming Lei

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web