Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1512682 > unrolled thread
| Started by | "Maciej W. Rozycki" <macro@imgtec.com> |
|---|---|
| First post | 2016-10-31 17:30 +0100 |
| Last post | 2016-11-01 10:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling "Maciej W. Rozycki" <macro@imgtec.com> - 2016-10-31 17:30 +0100
Re: [PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling Paul Burton <paul.burton@imgtec.com> - 2016-11-01 10:30 +0100
| From | "Maciej W. Rozycki" <macro@imgtec.com> |
|---|---|
| Date | 2016-10-31 17:30 +0100 |
| Subject | [PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling |
| Message-ID | <synDc-4Pf-21@gated-at.bofh.it> |
Complement commit 0ae8dceaebe3 ("Merge with 2.3.10.") and use the local
`fault' handler to recover from FP sigcontext access violation faults,
like corresponding code does in r4k_fpu.S. The `bad_stack' handler is
in syscall.c and is not suitable here as we want to propagate the error
condition up through the caller rather than killing the thread outright.
Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
---
I guess it hardly ever triggers and code still builds, so it has aged so
well...
Maciej
linux-mips-isa1-sig-fp-context-fault.patch
Index: linux-sfr-test/arch/mips/kernel/r2300_fpu.S
===================================================================
--- linux-sfr-test.orig/arch/mips/kernel/r2300_fpu.S 2016-10-22 02:36:46.000000000 +0100
+++ linux-sfr-test/arch/mips/kernel/r2300_fpu.S 2016-10-22 02:37:20.891186000 +0100
@@ -21,7 +21,7 @@
#define EX(a,b) \
9: a,##b; \
.section __ex_table,"a"; \
- PTR 9b,bad_stack; \
+ PTR 9b,fault; \
.previous
.set noreorder
[toc] | [next] | [standalone]
| From | Paul Burton <paul.burton@imgtec.com> |
|---|---|
| Date | 2016-11-01 10:30 +0100 |
| Subject | Re: [PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling |
| Message-ID | <syDyi-6N8-51@gated-at.bofh.it> |
| In reply to | #1512682 |
[Multipart message — attachments visible in raw view] — view raw
On Monday, 31 October 2016 16:25:44 GMT Maciej W. Rozycki wrote:
> Complement commit 0ae8dceaebe3 ("Merge with 2.3.10.") and use the local
> `fault' handler to recover from FP sigcontext access violation faults,
> like corresponding code does in r4k_fpu.S. The `bad_stack' handler is
> in syscall.c and is not suitable here as we want to propagate the error
> condition up through the caller rather than killing the thread outright.
>
> Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
> ---
> I guess it hardly ever triggers and code still builds, so it has aged so
> well...
>
> Maciej
>
> linux-mips-isa1-sig-fp-context-fault.patch
> Index: linux-sfr-test/arch/mips/kernel/r2300_fpu.S
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/kernel/r2300_fpu.S 2016-10-22
> 02:36:46.000000000 +0100 +++
> linux-sfr-test/arch/mips/kernel/r2300_fpu.S 2016-10-22 02:37:20.891186000
> +0100 @@ -21,7 +21,7 @@
> #define EX(a,b) \
> 9: a,##b; \
> .section __ex_table,"a"; \
> - PTR 9b,bad_stack; \
> + PTR 9b,fault; \
> .previous
>
> .set noreorder
Hi Maciej,
Looks good to me:
Reviewed-by: Paul Burton <paul.burton@imgtec.com>
Thanks,
Paul
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web