Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1511595 > unrolled thread
| Started by | Ming Lei <tom.leiming@gmail.com> |
|---|---|
| First post | 2016-10-29 10:40 +0200 |
| Last post | 2016-11-01 00:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 04/60] block: floppy: use bio_add_page() Ming Lei <tom.leiming@gmail.com> - 2016-10-29 10:40 +0200
Re: [PATCH 04/60] block: floppy: use bio_add_page() Christoph Hellwig <hch@infradead.org> - 2016-10-31 16:30 +0100
Re: [PATCH 04/60] block: floppy: use bio_add_page() Ming Lei <tom.leiming@gmail.com> - 2016-11-01 00:00 +0100
| From | Ming Lei <tom.leiming@gmail.com> |
|---|---|
| Date | 2016-10-29 10:40 +0200 |
| Subject | [PATCH 04/60] block: floppy: use bio_add_page() |
| Message-ID | <sxxlf-3Nw-1@gated-at.bofh.it> |
Signed-off-by: Ming Lei <tom.leiming@gmail.com> --- drivers/block/floppy.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index cdc916a95137..999099d9509d 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -3807,11 +3807,6 @@ static int __floppy_read_block_0(struct block_device *bdev, int drive) cbdata.drive = drive; bio_init_with_vec_table(&bio, &bio_vec, 1); - bio_vec.bv_page = page; - bio_vec.bv_len = size; - bio_vec.bv_offset = 0; - bio.bi_vcnt = 1; - bio.bi_iter.bi_size = size; bio.bi_bdev = bdev; bio.bi_iter.bi_sector = 0; bio.bi_flags |= (1 << BIO_QUIET); @@ -3819,6 +3814,8 @@ static int __floppy_read_block_0(struct block_device *bdev, int drive) bio.bi_end_io = floppy_rb0_cb; bio_set_op_attrs(&bio, REQ_OP_READ, 0); + bio_add_page(&bio, page, size, 0); + submit_bio(&bio); process_fd_request(); -- 2.7.4
[toc] | [next] | [standalone]
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Date | 2016-10-31 16:30 +0100 |
| Message-ID | <symH8-4bf-29@gated-at.bofh.it> |
| In reply to | #1511595 |
Why not keep the bio_add_page in the same spot as direct assignments were before?
[toc] | [prev] | [next] | [standalone]
| From | Ming Lei <tom.leiming@gmail.com> |
|---|---|
| Date | 2016-11-01 00:00 +0100 |
| Message-ID | <sytIB-bU-19@gated-at.bofh.it> |
| In reply to | #1512621 |
On Mon, Oct 31, 2016 at 11:26 PM, Christoph Hellwig <hch@infradead.org> wrote: > Why not keep the bio_add_page in the same spot as direct assignments > were before? I just want to put adding page after setting bi_bdev. Thanks, Ming Lei
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web