Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1513661 > unrolled thread
| Started by | Axl-zhang <hao5781286@gmail.com> |
|---|---|
| First post | 2016-11-02 06:40 +0100 |
| Last post | 2016-11-02 20:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v1] ARM:dmaengine:sun6i:fix the uninitialized value for v_lli Axl-zhang <hao5781286@gmail.com> - 2016-11-02 06:40 +0100
Re: [PATCH v1] ARM:dmaengine:sun6i:fix the uninitialized value for v_lli Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-02 20:00 +0100
| From | Axl-zhang <hao5781286@gmail.com> |
|---|---|
| Date | 2016-11-02 06:40 +0100 |
| Subject | [PATCH v1] ARM:dmaengine:sun6i:fix the uninitialized value for v_lli |
| Message-ID | <syWrf-24J-3@gated-at.bofh.it> |
dma_pool_alloc does not initialize the value of the newly allocated block for the v_lli, and the uninitilize value make the tests failed which is on pine64 with dmatest. we can fix it just change the "|=" to "=" for the v_lli->cfg. Signed-off-by: Hao Zhang <hao5781286@gmail.com> --- drivers/dma/sun6i-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index 3835fcd..52b48eb 100644 --- a/drivers/dma/sun6i-dma.c +++ b/drivers/dma/sun6i-dma.c @@ -578,7 +578,7 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_memcpy( burst = convert_burst(8); width = convert_buswidth(DMA_SLAVE_BUSWIDTH_4_BYTES); - v_lli->cfg |= DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) | + v_lli->cfg = DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) | DMA_CHAN_CFG_DST_DRQ(DRQ_SDRAM) | DMA_CHAN_CFG_DST_LINEAR_MODE | DMA_CHAN_CFG_SRC_LINEAR_MODE | -- 2.7.4
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-11-02 20:00 +0100 |
| Subject | Re: [PATCH v1] ARM:dmaengine:sun6i:fix the uninitialized value for v_lli |
| Message-ID | <sz8Vr-1yo-1@gated-at.bofh.it> |
| In reply to | #1513661 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Nov 02, 2016 at 01:31:12PM +0800, Axl-zhang wrote: > dma_pool_alloc does not initialize the value of the newly allocated > block for the v_lli, and the uninitilize value make the tests failed > which is on pine64 with dmatest. > we can fix it just change the "|=" to "=" for the v_lli->cfg. > > Signed-off-by: Hao Zhang <hao5781286@gmail.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web