Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1513470 > unrolled thread

[PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding Jon Mason <jon.mason@broadcom.com> - 2016-11-01 21:10 +0100
    Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap  binding Andrew Lunn <andrew@lunn.ch> - 2016-11-01 21:50 +0100
      Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap  binding Jon Mason <jon.mason@broadcom.com> - 2016-11-01 22:00 +0100
        Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap  binding Scott Branden <scott.branden@broadcom.com> - 2016-11-01 22:10 +0100
          Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap  binding Andrew Lunn <andrew@lunn.ch> - 2016-11-01 22:20 +0100

#1513470 — [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

Add the documentation for PHY lane swapping.  This is a boolean entry to
notify the phy device drivers that the TX/RX lanes need to be swapped.

Signed-off-by: Jon Mason <jon.mason@broadcom.com>
---
 Documentation/devicetree/bindings/net/phy.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt
index bc1c3c8..3dce607 100644
--- a/Documentation/devicetree/bindings/net/phy.txt
+++ b/Documentation/devicetree/bindings/net/phy.txt
@@ -35,6 +35,9 @@ Optional Properties:
 - broken-turn-around: If set, indicates the PHY device does not correctly
   release the turn around line low at the end of a MDIO transaction.
 
+- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the
+  TX/RX lanes to function properly.
+
 Example:
 
 ethernet-phy@0 {
-- 
2.7.4

[toc] | [next] | [standalone]

#1513495 — Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

> +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the
> +  TX/RX lanes to function properly.

Is 'requires' the right word here? The PHY performs the actual swap of
the Tx/Rx lanes.

    Andrew

[toc] | [prev] | [next] | [standalone]

#1513503 — Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote:
> > +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the
> > +  TX/RX lanes to function properly.
> 
> Is 'requires' the right word here? The PHY performs the actual swap of
> the Tx/Rx lanes.

What I'm trying to say here is that without the lane swapping, the PHY
will not function properly.  Thus, those PHYs require this parameter
to work.  I am open to suggestions to reword the sentence to make it
clearer.

Thanks,
Jon

> 
>     Andrew

[toc] | [prev] | [next] | [standalone]

#1513506 — Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

On 16-11-01 01:59 PM, Jon Mason wrote:
> On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote:
>>> +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping the
>>> +  TX/RX lanes to function properly.
>>
>> Is 'requires' the right word here? The PHY performs the actual swap of
>> the Tx/Rx lanes.
>
> What I'm trying to say here is that without the lane swapping, the PHY
> will not function properly.  Thus, those PHYs require this parameter
> to work.  I am open to suggestions to reword the sentence to make it
> clearer.
If set, indicates the PHY will swap the TX/RX lanes to compensate for 
the board being designed with the lanes swapped.
>
> Thanks,
> Jon
>
>>
>>     Andrew

[toc] | [prev] | [next] | [standalone]

#1513527 — Re: [PATCH v4 2/7] Documentation: devicetree: add PHY lane swap binding

> If set, indicates the PHY will swap the TX/RX lanes to compensate
> for the board being designed with the lanes swapped.

Thanks, much better.

	Andrew

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web