Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1513119 > unrolled thread
| Started by | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| First post | 2016-11-01 08:20 +0100 |
| Last post | 2016-11-01 19:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net/mlx5: Simplify a test Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-11-01 08:20 +0100
Re: [PATCH] net/mlx5: Simplify a test David Miller <davem@davemloft.net> - 2016-11-01 19:20 +0100
| From | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| Date | 2016-11-01 08:20 +0100 |
| Subject | [PATCH] net/mlx5: Simplify a test |
| Message-ID | <syBwt-5xk-7@gated-at.bofh.it> |
'create_root_ns()' does not return an error pointer, so the test can be
simplified to be more consistent.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index 904853f9cf7a..330955f6badc 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -1833,7 +1833,7 @@ static int init_root_ns(struct mlx5_flow_steering *steering)
{
steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX);
- if (IS_ERR_OR_NULL(steering->root_ns))
+ if (!steering->root_ns)
goto cleanup;
if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node))
--
2.9.3
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-11-01 19:20 +0100 |
| Message-ID | <syLPd-3J3-55@gated-at.bofh.it> |
| In reply to | #1513119 |
From: Matan Barak <matanb@mellanox.com>
Date: Tue, 1 Nov 2016 11:38:18 +0200
> On 01/11/2016 09:10, Christophe JAILLET wrote:
>> 'create_root_ns()' does not return an error pointer, so the test can
>> be
>> simplified to be more consistent.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
>> b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
>> index 904853f9cf7a..330955f6badc 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
>> @@ -1833,7 +1833,7 @@ static int init_root_ns(struct
>> mlx5_flow_steering *steering)
>> {
>>
>> steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX);
>> - if (IS_ERR_OR_NULL(steering->root_ns))
>> + if (!steering->root_ns)
>> goto cleanup;
>>
>> if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node))
>>
>
> Thanks.
> Acked-by: Matan Barak <matanb@mellanox.com>
>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web