Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1513212 > unrolled thread
| Started by | Johan Hovold <johan@kernel.org> |
|---|---|
| First post | 2016-11-01 12:00 +0100 |
| Last post | 2016-11-02 10:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] PM / sleep: fix device reference leak in test_suspend Johan Hovold <johan@kernel.org> - 2016-11-01 12:00 +0100
Re: [PATCH] PM / sleep: fix device reference leak in test_suspend Pavel Machek <pavel@ucw.cz> - 2016-11-02 10:00 +0100
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Date | 2016-11-01 12:00 +0100 |
| Subject | [PATCH] PM / sleep: fix device reference leak in test_suspend |
| Message-ID | <syEXn-7Bz-3@gated-at.bofh.it> |
Make sure to drop the reference taken by class_find_device() after
opening the rtc device.
Fixes: 77437fd4e61f ("pm: boot time suspend selftest")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
kernel/power/suspend_test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c
index 084452e34a12..bdff5ed57f10 100644
--- a/kernel/power/suspend_test.c
+++ b/kernel/power/suspend_test.c
@@ -203,8 +203,10 @@ static int __init test_suspend(void)
/* RTCs have initialized by now too ... can we use one? */
dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
- if (dev)
+ if (dev) {
rtc = rtc_class_open(dev_name(dev));
+ put_device(dev);
+ }
if (!rtc) {
printk(warn_no_rtc);
return 0;
--
2.7.3
[toc] | [next] | [standalone]
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2016-11-02 10:00 +0100 |
| Message-ID | <syZyO-40k-21@gated-at.bofh.it> |
| In reply to | #1513212 |
[Multipart message — attachments visible in raw view] — view raw
On Tue 2016-11-01 11:49:56, Johan Hovold wrote:
> Make sure to drop the reference taken by class_find_device() after
> opening the rtc device.
>
> Fixes: 77437fd4e61f ("pm: boot time suspend selftest")
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> kernel/power/suspend_test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c
> index 084452e34a12..bdff5ed57f10 100644
> --- a/kernel/power/suspend_test.c
> +++ b/kernel/power/suspend_test.c
> @@ -203,8 +203,10 @@ static int __init test_suspend(void)
>
> /* RTCs have initialized by now too ... can we use one? */
> dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
> - if (dev)
> + if (dev) {
> rtc = rtc_class_open(dev_name(dev));
> + put_device(dev);
> + }
> if (!rtc) {
> printk(warn_no_rtc);
> return 0;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web