Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1512586 > unrolled thread
| Started by | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| First post | 2016-10-31 15:50 +0100 |
| Last post | 2016-11-01 11:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 5/5] ARM: dts: da850-lcdk: add tilcdc panel node Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-31 15:50 +0100
Re: [PATCH v2 5/5] ARM: dts: da850-lcdk: add tilcdc panel node Sekhar Nori <nsekhar@ti.com> - 2016-11-01 11:30 +0100
Re: [PATCH v2 5/5] ARM: dts: da850-lcdk: add tilcdc panel node Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-11-01 11:40 +0100
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2016-10-31 15:50 +0100 |
| Subject | [PATCH v2 5/5] ARM: dts: da850-lcdk: add tilcdc panel node |
| Message-ID | <sym4q-3HL-23@gated-at.bofh.it> |
The tilcdc driver is not yet ready for working together with the
dumb-vga-dac drm bridge. While the work on enabling drm_bridge
support in tilcdc continues, enable the VGA connector on da850-lcdk
with the following workaround: use the tilcdc-panel driver with
a set of common (and tested) resolutions.
Once the drm bridge support is complete, we'll remove the node added
by this patch and use the correct solution. This change will be
transparent for the user.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/boot/dts/da850-lcdk.dts | 63 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index b39796e..df582c6 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -62,6 +62,65 @@
regulator-max-microvolt = <5000000>;
};
+ /*
+ * Remove this node once the tilcdc driver gets support for
+ * drm bridge modules.
+ */
+ panel {
+ compatible = "ti,tilcdc,panel";
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_pins>;
+ status = "okay";
+
+ panel-info {
+ ac-bias = <0>;
+ ac-bias-intrpt = <0>;
+ dma-burst-sz = <16>;
+ bpp = <16>;
+ fdd = <255>;
+ sync-edge = <0>;
+ sync-ctrl = <0>;
+ raster-order = <0>;
+ fifo-th = <5>;
+ };
+
+ display-timings {
+ native-mode = <&svga_timings>;
+ vga_timings: 640x480@60 {
+ clock-frequency = <27500000>;
+ hactive = <640>;
+ hback-porch = <90>;
+ hfront-porch = <40>;
+ hsync-len = <128>;
+ vactive = <480>;
+ vback-porch = <23>;
+ vfront-porch = <1>;
+ vsync-len = <4>;
+ };
+ vga_timings_hf: 640x480@75 {
+ clock-frequency = <34000000>;
+ hactive = <640>;
+ hback-porch = <90>;
+ hfront-porch = <40>;
+ hsync-len = <128>;
+ vactive = <480>;
+ vback-porch = <23>;
+ vfront-porch = <1>;
+ vsync-len = <4>;
+ };
+ svga_timings: 800x600@56 {
+ clock-frequency = <37500000>;
+ hactive = <800>;
+ hback-porch = <140>;
+ hfront-porch = <40>;
+ hsync-len = <128>;
+ vactive = <600>;
+ vback-porch = <23>;
+ vfront-porch = <1>;
+ vsync-len = <4>;
+ };
+ };
+ };
};
&pmx_core {
@@ -251,3 +310,7 @@
&ddrctl {
status = "okay";
};
+
+&display {
+ status = "okay";
+};
--
2.9.3
[toc] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2016-11-01 11:30 +0100 |
| Message-ID | <syEum-7r4-35@gated-at.bofh.it> |
| In reply to | #1512586 |
On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: > The tilcdc driver is not yet ready for working together with the > dumb-vga-dac drm bridge. While the work on enabling drm_bridge > support in tilcdc continues, enable the VGA connector on da850-lcdk > with the following workaround: use the tilcdc-panel driver with > a set of common (and tested) resolutions. > > Once the drm bridge support is complete, we'll remove the node added > by this patch and use the correct solution. This change will be > transparent for the user. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> I dont think this can be applied. If this goes in v4.10, then the DT blob becomes an ABI and driver will have to support tilcdc-panel driver for DA850 forever. Its probably better to wait for the proper driver support to arrive. Thanks, Sekhar
[toc] | [prev] | [next] | [standalone]
| From | Tomi Valkeinen <tomi.valkeinen@ti.com> |
|---|---|
| Date | 2016-11-01 11:40 +0100 |
| Message-ID | <syEE2-7uL-9@gated-at.bofh.it> |
| In reply to | #1513203 |
[Multipart message — attachments visible in raw view] — view raw
On 01/11/16 12:26, Sekhar Nori wrote: > On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: >> The tilcdc driver is not yet ready for working together with the >> dumb-vga-dac drm bridge. While the work on enabling drm_bridge >> support in tilcdc continues, enable the VGA connector on da850-lcdk >> with the following workaround: use the tilcdc-panel driver with >> a set of common (and tested) resolutions. >> >> Once the drm bridge support is complete, we'll remove the node added >> by this patch and use the correct solution. This change will be >> transparent for the user. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I dont think this can be applied. If this goes in v4.10, then the DT > blob becomes an ABI and driver will have to support tilcdc-panel driver > for DA850 forever. > > Its probably better to wait for the proper driver support to arrive. Agreed, NAK for this. Tomi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web