Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512047 > unrolled thread

[PATCH] idle/i7300: Add CONFIG_PCI dependency

Started byBorislav Petkov <bp@alien8.de>
First post2016-10-30 12:50 +0100
Last post2016-10-30 17:40 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] idle/i7300: Add CONFIG_PCI dependency Borislav Petkov <bp@alien8.de> - 2016-10-30 12:50 +0100
    Re: [PATCH] idle/i7300: Add CONFIG_PCI dependency Randy Dunlap <rdunlap@infradead.org> - 2016-10-30 16:00 +0100
      Re: [PATCH] idle/i7300: Add CONFIG_PCI dependency Borislav Petkov <bp@alien8.de> - 2016-10-30 17:40 +0100

#1512047 — [PATCH] idle/i7300: Add CONFIG_PCI dependency

FromBorislav Petkov <bp@alien8.de>
Date2016-10-30 12:50 +0100
Subject[PATCH] idle/i7300: Add CONFIG_PCI dependency
Message-ID<sxWMF-45D-5@gated-at.bofh.it>
From: Borislav Petkov <bp@suse.de>

... in order to fix this randconfig build warning:

  drivers/idle/i7300_idle.c: In function ‘i7300_idle_stop’:
  ./include/asm-generic/bug.h:117:24: warning: ‘got_ctl’ is used uninitialized in this function [-Wuninitialized]
    int __ret_warn_once = !!(condition);   \
                          ^
  drivers/idle/i7300_idle.c:415:5: note: ‘got_ctl’ was declared here
    u8 got_ctl;
       ^

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Henroid <andrew.d.henroid@intel.com>
Cc: linux-pm@vger.kernel.org
---
 drivers/idle/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/idle/Kconfig b/drivers/idle/Kconfig
index 4732dfc15447..c11ee3e657a6 100644
--- a/drivers/idle/Kconfig
+++ b/drivers/idle/Kconfig
@@ -18,6 +18,7 @@ config I7300_IDLE_IOAT_CHANNEL
 config I7300_IDLE
 	tristate "Intel chipset idle memory power saving driver"
 	select I7300_IDLE_IOAT_CHANNEL
+	depends on CONFIG_PCI
 	help
 	  Enable memory power savings when idle with certain Intel server
 	  chipsets. The chipset must have I/O AT support, such as the
-- 
2.10.0

[toc] | [next] | [standalone]

#1512079

FromRandy Dunlap <rdunlap@infradead.org>
Date2016-10-30 16:00 +0100
Message-ID<sxZKy-5YO-5@gated-at.bofh.it>
In reply to#1512047
On 10/30/16 04:42, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> ... in order to fix this randconfig build warning:
> 
>   drivers/idle/i7300_idle.c: In function ‘i7300_idle_stop’:
>   ./include/asm-generic/bug.h:117:24: warning: ‘got_ctl’ is used uninitialized in this function [-Wuninitialized]
>     int __ret_warn_once = !!(condition);   \
>                           ^
>   drivers/idle/i7300_idle.c:415:5: note: ‘got_ctl’ was declared here
>     u8 got_ctl;
>        ^
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Andy Henroid <andrew.d.henroid@intel.com>
> Cc: linux-pm@vger.kernel.org
> ---
>  drivers/idle/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/idle/Kconfig b/drivers/idle/Kconfig
> index 4732dfc15447..c11ee3e657a6 100644
> --- a/drivers/idle/Kconfig
> +++ b/drivers/idle/Kconfig
> @@ -18,6 +18,7 @@ config I7300_IDLE_IOAT_CHANNEL
>  config I7300_IDLE
>  	tristate "Intel chipset idle memory power saving driver"
>  	select I7300_IDLE_IOAT_CHANNEL
> +	depends on CONFIG_PCI

	depends on PCI
(no CONFIG_ prefix)

>  	help
>  	  Enable memory power savings when idle with certain Intel server
>  	  chipsets. The chipset must have I/O AT support, such as the
> 


-- 
~Randy

[toc] | [prev] | [next] | [standalone]

#1512111

FromBorislav Petkov <bp@alien8.de>
Date2016-10-30 17:40 +0100
Message-ID<sy1jk-74B-37@gated-at.bofh.it>
In reply to#1512079
On Sun, Oct 30, 2016 at 07:54:44AM -0700, Randy Dunlap wrote:
> 	depends on PCI
> (no CONFIG_ prefix)

Whoops!

Thanks. FWIW, it didn't fire even with "depends on CONFIG_PCI" anymore.
Didn't investigate why though...

---
From: Borislav Petkov <bp@suse.de>
Date: Sun, 30 Oct 2016 14:39:28 +0100
Subject: [PATCH] idle/i7300: Add CONFIG_PCI dependency
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

... in order to fix this randconfig build warning:

  drivers/idle/i7300_idle.c: In function ‘i7300_idle_stop’:
  ./include/asm-generic/bug.h:117:24: warning: ‘got_ctl’ is used uninitialized in this function [-Wuninitialized]
    int __ret_warn_once = !!(condition);   \
                          ^
  drivers/idle/i7300_idle.c:415:5: note: ‘got_ctl’ was declared here
    u8 got_ctl;
       ^

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Henroid <andrew.d.henroid@intel.com>
Cc: linux-pm@vger.kernel.org
---
 drivers/idle/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/idle/Kconfig b/drivers/idle/Kconfig
index 4732dfc15447..a066fca3688f 100644
--- a/drivers/idle/Kconfig
+++ b/drivers/idle/Kconfig
@@ -18,6 +18,7 @@ config I7300_IDLE_IOAT_CHANNEL
 config I7300_IDLE
 	tristate "Intel chipset idle memory power saving driver"
 	select I7300_IDLE_IOAT_CHANNEL
+	depends on PCI
 	help
 	  Enable memory power savings when idle with certain Intel server
 	  chipsets. The chipset must have I/O AT support, such as the
-- 
2.10.0

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web