Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1511993 > unrolled thread
| Started by | Eric Wheeler <bcache@lists.ewheeler.net> |
|---|---|
| First post | 2016-10-30 02:40 +0100 |
| Last post | 2016-11-01 03:40 +0100 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PULL] bcache: multiple updates Eric Wheeler <bcache@lists.ewheeler.net> - 2016-10-30 02:40 +0100
Re: [PULL] bcache: multiple updates Davidlohr Bueso <dave@stgolabs.net> - 2016-10-30 04:50 +0100
Re: [PULL] bcache: multiple updates Kent Overstreet <kent.overstreet@gmail.com> - 2016-10-30 15:10 +0100
Re: [PULL] bcache: multiple updates Jens Axboe <axboe@kernel.dk> - 2016-10-30 16:10 +0100
Re: [PULL] bcache: multiple updates Eric Wheeler <bcache@lists.ewheeler.net> - 2016-11-01 03:40 +0100
| From | Eric Wheeler <bcache@lists.ewheeler.net> |
|---|---|
| Date | 2016-10-30 02:40 +0100 |
| Subject | Re: [PULL] bcache: multiple updates |
| Message-ID | <sxNgl-6ca-5@gated-at.bofh.it> |
On Thu, 27 Oct 2016, Jens Axboe wrote: > On 10/27/2016 05:27 PM, Eric Wheeler wrote: > > Hi Jens, > > > > Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3: > > (You may disregard the previous -rc1-based request.) > > > > git pull https://bitbucket.org/ewheelerinc/linux.git > > v4.9-rc2-bcache-updates > > > > Thank you! > > > > -- > > Eric Wheeler > > > > ]# git log --oneline v4.9-rc2..HEAD > > bd532a6 bcache: partition support: add 16 minors per bcacheN device > > 3312845 bcache: Make gc wakeup sane, remove set_task_state() > > 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints > > 3d58a09 bcache: documentation for ioprio cache hinting > > 2e8884b bcache: introduce per-process ioprio-based bypass/writeback hints > > How many of these are applicable to 4.9-rc3? I took a quick look at > them, and some of them look like they should go into the 4.10 branch > instead. We're after the merge window, so only strict fixes. Cleanups > and no features, no go. 3312845 might need to be in 4.9. Not sure, kent asked me to pick it up in my next pull request. 4.10 is fine for the rest. Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason? See this thread: Re: ciao set_task_state() (was Re: [PATCH -v4 6/8] locking/mutex: Restructure wait loop) http://www.gossamer-threads.com/lists/linux/kernel/2550193 -- Eric Wheeler > > -- > Jens Axboe > > >
[toc] | [next] | [standalone]
| From | Davidlohr Bueso <dave@stgolabs.net> |
|---|---|
| Date | 2016-10-30 04:50 +0100 |
| Message-ID | <sxPi9-7CO-13@gated-at.bofh.it> |
| In reply to | #1511993 |
On Sat, 29 Oct 2016, Eric Wheeler wrote: >Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason? No, not particularly. I can do my stuff whenever this is ends up being merged. Thanks, Davidlohr
[toc] | [prev] | [next] | [standalone]
| From | Kent Overstreet <kent.overstreet@gmail.com> |
|---|---|
| Date | 2016-10-30 15:10 +0100 |
| Message-ID | <sxYY9-5Fp-1@gated-at.bofh.it> |
| In reply to | #1511993 |
On Sat, Oct 29, 2016 at 06:32:38PM -0700, Eric Wheeler wrote: > On Thu, 27 Oct 2016, Jens Axboe wrote: > > > On 10/27/2016 05:27 PM, Eric Wheeler wrote: > > > Hi Jens, > > > > > > Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3: > > > (You may disregard the previous -rc1-based request.) > > > > > > git pull https://bitbucket.org/ewheelerinc/linux.git > > > v4.9-rc2-bcache-updates > > > > > > Thank you! > > > > > > -- > > > Eric Wheeler > > > > > > ]# git log --oneline v4.9-rc2..HEAD > > > bd532a6 bcache: partition support: add 16 minors per bcacheN device > > > 3312845 bcache: Make gc wakeup sane, remove set_task_state() > > > 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints > > > 3d58a09 bcache: documentation for ioprio cache hinting > > > 2e8884b bcache: introduce per-process ioprio-based bypass/writeback hints > > > > How many of these are applicable to 4.9-rc3? I took a quick look at > > them, and some of them look like they should go into the 4.10 branch > > instead. We're after the merge window, so only strict fixes. Cleanups > > and no features, no go. > > 3312845 might need to be in 4.9. Not sure, kent asked me to pick it up in > my next pull request. 4.10 is fine for the rest. > > Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason? No, that can wait until 4.10.
[toc] | [prev] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2016-10-30 16:10 +0100 |
| Message-ID | <sxZUd-6he-5@gated-at.bofh.it> |
| In reply to | #1512072 |
On 10/30/2016 08:00 AM, Kent Overstreet wrote:
> On Sat, Oct 29, 2016 at 06:32:38PM -0700, Eric Wheeler wrote:
>> On Thu, 27 Oct 2016, Jens Axboe wrote:
>>
>>> On 10/27/2016 05:27 PM, Eric Wheeler wrote:
>>>> Hi Jens,
>>>>
>>>> Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3:
>>>> (You may disregard the previous -rc1-based request.)
>>>>
>>>> git pull https://bitbucket.org/ewheelerinc/linux.git
>>>> v4.9-rc2-bcache-updates
>>>>
>>>> Thank you!
>>>>
>>>> --
>>>> Eric Wheeler
>>>>
>>>> ]# git log --oneline v4.9-rc2..HEAD
>>>> bd532a6 bcache: partition support: add 16 minors per bcacheN device
>>>> 3312845 bcache: Make gc wakeup sane, remove set_task_state()
>>>> 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
>>>> 3d58a09 bcache: documentation for ioprio cache hinting
>>>> 2e8884b bcache: introduce per-process ioprio-based bypass/writeback hints
>>>
>>> How many of these are applicable to 4.9-rc3? I took a quick look at
>>> them, and some of them look like they should go into the 4.10 branch
>>> instead. We're after the merge window, so only strict fixes. Cleanups
>>> and no features, no go.
>>
>> 3312845 might need to be in 4.9. Not sure, kent asked me to pick it up in
>> my next pull request. 4.10 is fine for the rest.
>>
>> Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason?
>
> No, that can wait until 4.10.
Great, that's what it looked like.
Eric, three things. The first is that you based this branch as if it was
going into 4.9, which means if I pull it into my 4.10 branch, I get a
ton of extra stuff that has been added to master since. Not a huge
problem, I can just generate the patches and apply them.
Secondly, you are depending on REQ_THROTTLED, which in the 4.10 series,
has been modified:
commit 8d2bbd4c8236e9e38e6b36ac9e2c54fdcfe5b335
Author: Christoph Hellwig <hch@lst.de>
Date: Thu Oct 20 15:12:12 2016 +0200
block: replace REQ_THROTTLED with a bio flag
And lastly, would you mind using the regular git request-pull to
generate your pull requests? It's what everybody else is using, and
honestly I think it's a lot more readable than the oneline thing you are
doing.
Please resend the series against for-4.10/block and we can get it
applied, thanks.
--
Jens Axboe
[toc] | [prev] | [next] | [standalone]
| From | Eric Wheeler <bcache@lists.ewheeler.net> |
|---|---|
| Date | 2016-11-01 03:40 +0100 |
| Message-ID | <syx9v-2u4-1@gated-at.bofh.it> |
| In reply to | #1512082 |
On Sun, 30 Oct 2016, Jens Axboe wrote: > On 10/30/2016 08:00 AM, Kent Overstreet wrote: > > On Sat, Oct 29, 2016 at 06:32:38PM -0700, Eric Wheeler wrote: > > > On Thu, 27 Oct 2016, Jens Axboe wrote: > > > > > > > On 10/27/2016 05:27 PM, Eric Wheeler wrote: > > > > > Hi Jens, > > > > > > > > > > Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3: > > > > > (You may disregard the previous -rc1-based request.) > > > > > > > > > > git pull https://bitbucket.org/ewheelerinc/linux.git > > > > > v4.9-rc2-bcache-updates > > > > > > > > > > Thank you! > > > > > > > > > > -- > > > > > Eric Wheeler > > > > > > > > > > ]# git log --oneline v4.9-rc2..HEAD > > > > > bd532a6 bcache: partition support: add 16 minors per bcacheN device > > > > > 3312845 bcache: Make gc wakeup sane, remove set_task_state() > > > > > 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints > > > > > 3d58a09 bcache: documentation for ioprio cache hinting > > > > > 2e8884b bcache: introduce per-process ioprio-based bypass/writeback > > > > > hints > > > > > > > > How many of these are applicable to 4.9-rc3? I took a quick look at > > > > them, and some of them look like they should go into the 4.10 branch > > > > instead. We're after the merge window, so only strict fixes. Cleanups > > > > and no features, no go. > > > > > > 3312845 might need to be in 4.9. Not sure, kent asked me to pick it up in > > > my next pull request. 4.10 is fine for the rest. > > > > > > Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason? > > > > No, that can wait until 4.10. > > Great, that's what it looked like. > > Eric, three things. The first is that you based this branch as if it was > going into 4.9, which means if I pull it into my 4.10 branch, I get a > ton of extra stuff that has been added to master since. Not a huge > problem, I can just generate the patches and apply them. > > Secondly, you are depending on REQ_THROTTLED, which in the 4.10 series, > has been modified: > > commit 8d2bbd4c8236e9e38e6b36ac9e2c54fdcfe5b335 > Author: Christoph Hellwig <hch@lst.de> > Date: Thu Oct 20 15:12:12 2016 +0200 > > block: replace REQ_THROTTLED with a bio flag > > And lastly, would you mind using the regular git request-pull to > generate your pull requests? It's what everybody else is using, and > honestly I think it's a lot more readable than the oneline thing you are > doing. > > Please resend the series against for-4.10/block and we can get it > applied, thanks. Will do, thanks! -Eric -- Eric Wheeler > > -- > Jens Axboe > > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web