Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1511830 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2016-10-29 18:20 +0200 |
| Last post | 2016-10-30 10:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -next] brd: make symbol rd_size static Wei Yongjun <weiyj.lk@gmail.com> - 2016-10-29 18:20 +0200
Re: [PATCH -next] brd: make symbol rd_size static Jens Axboe <axboe@kernel.dk> - 2016-10-30 05:00 +0100
Re: [PATCH -next] brd: make symbol rd_size static Wei Yongjun <weiyj.lk@gmail.com> - 2016-10-30 13:50 +0100
Re: [PATCH -next] brd: make symbol rd_size static Jan Kara <jack@suse.cz> - 2016-10-30 10:50 +0100
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-10-29 18:20 +0200 |
| Subject | [PATCH -next] brd: make symbol rd_size static |
| Message-ID | <sxEwp-pd-1@gated-at.bofh.it> |
From: Wei Yongjun <weiyongjun1@huawei.com> Fixes the following sparse warning: drivers/block/brd.c:411:15: warning: symbol 'rd_size' was not declared. Should it be static? Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/block/brd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index ad793f3..d1edf42 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -408,7 +408,7 @@ static int rd_nr = CONFIG_BLK_DEV_RAM_COUNT; module_param(rd_nr, int, S_IRUGO); MODULE_PARM_DESC(rd_nr, "Maximum number of brd devices"); -unsigned long rd_size = CONFIG_BLK_DEV_RAM_SIZE; +static unsigned long rd_size = CONFIG_BLK_DEV_RAM_SIZE; module_param(rd_size, ulong, S_IRUGO); MODULE_PARM_DESC(rd_size, "Size of each RAM disk in kbytes.");
[toc] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2016-10-30 05:00 +0100 |
| Message-ID | <sxPrP-7FZ-1@gated-at.bofh.it> |
| In reply to | #1511830 |
On 10/29/2016 10:10 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/block/brd.c:411:15: warning:
> symbol 'rd_size' was not declared. Should it be static?
We just tried this, it's used in arm:
arch/arm/kernel/atags_parse.c
static int __init parse_tag_ramdisk(const struct tag *tag)
{
extern int rd_size, rd_image_start, rd_prompt, rd_doload;
[...]
--
Jens Axboe
[toc] | [prev] | [next] | [standalone]
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-10-30 13:50 +0100 |
| Message-ID | <sxXIK-4Ik-5@gated-at.bofh.it> |
| In reply to | #1512000 |
On 10/30/2016 11:57 AM, Jens Axboe wrote:
> On 10/29/2016 10:10 AM, Wei Yongjun wrote:
>> From: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> Fixes the following sparse warning:
>>
>> drivers/block/brd.c:411:15: warning:
>> symbol 'rd_size' was not declared. Should it be static?
>
> We just tried this, it's used in arm:
>
> arch/arm/kernel/atags_parse.c
>
> static int __init parse_tag_ramdisk(const struct tag *tag)
> {
> extern int rd_size, rd_image_start, rd_prompt, rd_doload;
> [...]
>
Oh, yeah, got it.
Thank you very much.
Regards,
Yongjun Wei
[toc] | [prev] | [next] | [standalone]
| From | Jan Kara <jack@suse.cz> |
|---|---|
| Date | 2016-10-30 10:50 +0100 |
| Message-ID | <sxUUx-2S9-7@gated-at.bofh.it> |
| In reply to | #1511830 |
On Sat 29-10-16 16:10:27, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fixes the following sparse warning: > > drivers/block/brd.c:411:15: warning: > symbol 'rd_size' was not declared. Should it be static? It should not. It is used in arch/arm/. Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web