Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508726 > unrolled thread

Re: [PATCH v2 perf/core] perf script: fix a use after free crash.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 perf/core] perf script: fix a use after free crash. Krister Johansen <kjlx@templeofstupid.com> - 2016-10-26 02:30 +0200
    Re: [PATCH v2 perf/core] perf script: fix a use after free crash. Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-10-26 15:50 +0200

#1508726 — Re: [PATCH v2 perf/core] perf script: fix a use after free crash.

On Tue, Oct 11, 2016 at 02:28:39AM -0700, Krister Johansen wrote:
> If dso__load_kcore frees all of the existing maps, but one has already
> been attached to a callchain cursor node, then we can get a SIGSEGV in
> any function that happens to try to use this invalid cursor.  Use the
> existing map refcount mechanism to forestall cleanup of a map until the
> cursor iterates past the node.

It has been a couple of weeks since I sent out v2 of this patch.  I
understand that folks here have plenty of irons in the fire, but I
wanted to double-check that nobody was waiting on me for additional
information or changes.

Thanks,

-K

[toc] | [next] | [standalone]

#1509444

Em Tue, Oct 25, 2016 at 05:20:10PM -0700, Krister Johansen escreveu:
> On Tue, Oct 11, 2016 at 02:28:39AM -0700, Krister Johansen wrote:
> > If dso__load_kcore frees all of the existing maps, but one has already
> > been attached to a callchain cursor node, then we can get a SIGSEGV in
> > any function that happens to try to use this invalid cursor.  Use the
> > existing map refcount mechanism to forestall cleanup of a map until the
> > cursor iterates past the node.
> 
> It has been a couple of weeks since I sent out v2 of this patch.  I
> understand that folks here have plenty of irons in the fire, but I
> wanted to double-check that nobody was waiting on me for additional
> information or changes.

It was a mix of waiting for more people to review it, or for Masami to
run its refcount debugger on it, ended up falling thru the cracks.

I'll try to process it now.

- Arnaldo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web