Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1509122 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2016-10-26 14:20 +0200 |
| Last post | 2016-10-26 14:20 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 06/15] mfd: tc3589x: improve function-level documentation Lee Jones <lee.jones@linaro.org> - 2016-10-26 14:20 +0200
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-10-26 14:20 +0200 |
| Subject | Re: [PATCH 06/15] mfd: tc3589x: improve function-level documentation |
| Message-ID | <swvlw-3vY-7@gated-at.bofh.it> |
On Sat, 01 Oct 2016, Julia Lawall wrote:
> Use the correct function name in one case and adjust a variable name to
> that of the corresponding function parameter in another case.
>
> Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/mfd/tc3589x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
> index 274bf39..cc9e563 100644
> --- a/drivers/mfd/tc3589x.c
> +++ b/drivers/mfd/tc3589x.c
> @@ -53,7 +53,7 @@ int tc3589x_reg_read(struct tc3589x *tc3589x, u8 reg)
> EXPORT_SYMBOL_GPL(tc3589x_reg_read);
>
> /**
> - * tc3589x_reg_read() - write a single TC3589x register
> + * tc3589x_reg_write() - write a single TC3589x register
> * @tc3589x: Device to write to
> * @reg: Register to read
> * @data: Value to write
> @@ -118,7 +118,7 @@ int tc3589x_block_write(struct tc3589x *tc3589x, u8 reg, u8 length,
> * @tc3589x: Device to write to
> * @reg: Register to write
> * @mask: Mask of bits to set
> - * @values: Value to set
> + * @val: Value to set
> */
> int tc3589x_set_bits(struct tc3589x *tc3589x, u8 reg, u8 mask, u8 val)
> {
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to top | Article view | linux.kernel
csiph-web