Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508817 > unrolled thread

Re: [PATCH] powerpc: process.c: fix Kconfig typo

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] powerpc: process.c: fix Kconfig typo Valentin Rothberg <valentinrothberg@gmail.com> - 2016-10-26 08:30 +0200
    Re: [PATCH] powerpc: process.c: fix Kconfig typo Michael Ellerman <mpe@ellerman.id.au> - 2016-10-26 12:50 +0200
      Re: [PATCH] powerpc: process.c: fix Kconfig typo Valentin Rothberg <valentinrothberg@gmail.com> - 2016-10-26 12:50 +0200
        Re: [PATCH] powerpc: process.c: fix Kconfig typo Michael Ellerman <mpe@ellerman.id.au> - 2016-10-27 02:20 +0200

#1508817 — Re: [PATCH] powerpc: process.c: fix Kconfig typo

On Wed, Oct 26, 2016 at 7:52 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Cyril Bur <cyrilbur@gmail.com> writes:
>
>> On Wed, 2016-10-05 at 07:57 +0200, Valentin Rothberg wrote:
>>> s/ALIVEC/ALTIVEC/
>>>
>>
>> Oops, nice catch
>>
>>> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
>>
>> Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
>
> How did we not notice? Sounds like we need a new selftest.
>
> Looks like this should have:
>
> Fixes: dc16b553c949 ("powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use")
>
>
> And I guess I need to start running checkkconfigsymbols.py on every
> commit.

Happy to find a new user :-)  You can also run the script on a range
of commits via '--diff commitA..commitB', which can safe some time.

Best regards,
 Valentin

> cheers

[toc] | [next] | [standalone]

#1509044

Valentin Rothberg <valentinrothberg@gmail.com> writes:

> On Wed, Oct 26, 2016 at 7:52 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> Cyril Bur <cyrilbur@gmail.com> writes:
>>
>>> On Wed, 2016-10-05 at 07:57 +0200, Valentin Rothberg wrote:
>>>> s/ALIVEC/ALTIVEC/
>>>>
>>>
>>> Oops, nice catch
>>>
>>>> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
>>>
>>> Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
>>
>> How did we not notice? Sounds like we need a new selftest.
>>
>> Looks like this should have:
>>
>> Fixes: dc16b553c949 ("powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use")
>>
>>
>> And I guess I need to start running checkkconfigsymbols.py on every
>> commit.
>
> Happy to find a new user :-)  You can also run the script on a range
> of commits via '--diff commitA..commitB', which can safe some time.

Yeah I just discovered that, very useful.

But my instinct was to do:

$ ./scripts/checkkconfigsymbols.py --diff HEAD^^^..HEAD

Which didn't work, the regexp is a bit tight, fixed by:

diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
index a32e4da4c117..3820f00b066a 100755
--- a/scripts/checkkconfigsymbols.py
+++ b/scripts/checkkconfigsymbols.py
@@ -88,7 +88,7 @@ def parse_options():
     if args.commit and args.diff:
         sys.exit("Please specify only one option at once.")
 
-    if args.diff and not re.match(r"^[\w\-\.]+\.\.[\w\-\.]+$", args.diff):
+    if args.diff and not re.match(r"^[\w\-\.\^]+\.\.[\w\-\.\^]+$", args.diff):
         sys.exit("Please specify valid input in the following format: "
                  "\'commit1..commit2\'")
 


cheers

[toc] | [prev] | [next] | [standalone]

#1509048

On Wed, Oct 26, 2016 at 12:40 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Valentin Rothberg <valentinrothberg@gmail.com> writes:
>
>> On Wed, Oct 26, 2016 at 7:52 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>>> Cyril Bur <cyrilbur@gmail.com> writes:
>>>
>>>> On Wed, 2016-10-05 at 07:57 +0200, Valentin Rothberg wrote:
>>>>> s/ALIVEC/ALTIVEC/
>>>>>
>>>>
>>>> Oops, nice catch
>>>>
>>>>> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
>>>>
>>>> Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
>>>
>>> How did we not notice? Sounds like we need a new selftest.
>>>
>>> Looks like this should have:
>>>
>>> Fixes: dc16b553c949 ("powerpc: Always restore FPU/VEC/VSX if hardware transactional memory in use")
>>>
>>>
>>> And I guess I need to start running checkkconfigsymbols.py on every
>>> commit.
>>
>> Happy to find a new user :-)  You can also run the script on a range
>> of commits via '--diff commitA..commitB', which can safe some time.
>
> Yeah I just discovered that, very useful.
>
> But my instinct was to do:
>
> $ ./scripts/checkkconfigsymbols.py --diff HEAD^^^..HEAD
>
> Which didn't work, the regexp is a bit tight, fixed by:
>
> diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
> index a32e4da4c117..3820f00b066a 100755
> --- a/scripts/checkkconfigsymbols.py
> +++ b/scripts/checkkconfigsymbols.py
> @@ -88,7 +88,7 @@ def parse_options():
>      if args.commit and args.diff:
>          sys.exit("Please specify only one option at once.")
>
> -    if args.diff and not re.match(r"^[\w\-\.]+\.\.[\w\-\.]+$", args.diff):
> +    if args.diff and not re.match(r"^[\w\-\.\^]+\.\.[\w\-\.\^]+$", args.diff):
>          sys.exit("Please specify valid input in the following format: "
>                   "\'commit1..commit2\'")

Looks great.  If you agree, I'll pick this up and send the patch to
Greg (who takes patches for this script)?

Thanks,
 Valentin

[toc] | [prev] | [next] | [standalone]

#1509980

Valentin Rothberg <valentinrothberg@gmail.com> writes:
> On Wed, Oct 26, 2016 at 12:40 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
>> index a32e4da4c117..3820f00b066a 100755
>> --- a/scripts/checkkconfigsymbols.py
>> +++ b/scripts/checkkconfigsymbols.py
>> @@ -88,7 +88,7 @@ def parse_options():
>>      if args.commit and args.diff:
>>          sys.exit("Please specify only one option at once.")
>>
>> -    if args.diff and not re.match(r"^[\w\-\.]+\.\.[\w\-\.]+$", args.diff):
>> +    if args.diff and not re.match(r"^[\w\-\.\^]+\.\.[\w\-\.\^]+$", args.diff):
>>          sys.exit("Please specify valid input in the following format: "
>>                   "\'commit1..commit2\'")
>
> Looks great.  If you agree, I'll pick this up and send the patch to
> Greg (who takes patches for this script)?

That'd be great, thanks.

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web