Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1508879 > unrolled thread
| Started by | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| First post | 2016-10-26 09:40 +0200 |
| Last post | 2016-10-26 19:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] PM / devfreq: Use the resource-managed function for devfreq device Chanwoo Choi <cw00.choi@samsung.com> - 2016-10-26 09:40 +0200
[PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device Chanwoo Choi <cw00.choi@samsung.com> - 2016-10-26 09:40 +0200
Re: [PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device Subhash Jadavani <subhashj@codeaurora.org> - 2016-10-26 19:30 +0200
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-10-26 09:40 +0200 |
| Subject | [PATCH 0/2] PM / devfreq: Use the resource-managed function for devfreq device |
| Message-ID | <swqYy-t9-7@gated-at.bofh.it> |
This patch just uses the resource-managed function when adding the new devfreq deivce. This function handles the memory and delete of devfreq instance automatically. Chanwoo Choi (2): PM / devfreq: rk3399_dmc: Use the resource-managed function to add devfreq dev scsi: ufs: Use the resource-managed function to add devfreq device drivers/devfreq/rk3399_dmc.c | 2 +- drivers/scsi/ufs/ufshcd.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-10-26 09:40 +0200 |
| Subject | [PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device |
| Message-ID | <swqYy-t9-27@gated-at.bofh.it> |
| In reply to | #1508879 |
This patch uses the resource-managed to add the devfreq device.
This function will make it easy to handle the devfreq device.
- struct devfreq *devm_devfreq_add_device(struct device *dev,
struct devfreq_dev_profile *profile,
const char *governor_name,
void *data);
Cc: Vinayak Holikatti <vinholikatti@gmail.com>
Cc: James E.J. Bottomley <jejb@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/scsi/ufs/ufshcd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index f08d41a2d70b..e639071fd3a1 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6198,8 +6198,6 @@ void ufshcd_remove(struct ufs_hba *hba)
scsi_host_put(hba->host);
ufshcd_exit_clk_gating(hba);
- if (ufshcd_is_clkscaling_enabled(hba))
- devfreq_remove_device(hba->devfreq);
ufshcd_hba_exit(hba);
}
EXPORT_SYMBOL_GPL(ufshcd_remove);
@@ -6495,7 +6493,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
}
if (ufshcd_is_clkscaling_enabled(hba)) {
- hba->devfreq = devfreq_add_device(dev, &ufs_devfreq_profile,
+ hba->devfreq = devm_devfreq_add_device(dev, &ufs_devfreq_profile,
"simple_ondemand", NULL);
if (IS_ERR(hba->devfreq)) {
dev_err(hba->dev, "Unable to register with devfreq %ld\n",
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Subhash Jadavani <subhashj@codeaurora.org> |
|---|---|
| Date | 2016-10-26 19:30 +0200 |
| Subject | Re: [PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device |
| Message-ID | <swAbv-6Tj-7@gated-at.bofh.it> |
| In reply to | #1508880 |
On 2016-10-26 00:38, Chanwoo Choi wrote:
> This patch uses the resource-managed to add the devfreq device.
> This function will make it easy to handle the devfreq device.
>
> - struct devfreq *devm_devfreq_add_device(struct device *dev,
> struct devfreq_dev_profile *profile,
> const char *governor_name,
> void *data);
> Cc: Vinayak Holikatti <vinholikatti@gmail.com>
> Cc: James E.J. Bottomley <jejb@linux.vnet.ibm.com>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index f08d41a2d70b..e639071fd3a1 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6198,8 +6198,6 @@ void ufshcd_remove(struct ufs_hba *hba)
> scsi_host_put(hba->host);
>
> ufshcd_exit_clk_gating(hba);
> - if (ufshcd_is_clkscaling_enabled(hba))
> - devfreq_remove_device(hba->devfreq);
> ufshcd_hba_exit(hba);
> }
> EXPORT_SYMBOL_GPL(ufshcd_remove);
> @@ -6495,7 +6493,7 @@ int ufshcd_init(struct ufs_hba *hba, void
> __iomem *mmio_base, unsigned int irq)
> }
>
> if (ufshcd_is_clkscaling_enabled(hba)) {
> - hba->devfreq = devfreq_add_device(dev, &ufs_devfreq_profile,
> + hba->devfreq = devm_devfreq_add_device(dev, &ufs_devfreq_profile,
> "simple_ondemand", NULL);
> if (IS_ERR(hba->devfreq)) {
> dev_err(hba->dev, "Unable to register with devfreq %ld\n",
This change looks good to me but this will have merge conflicts if this
gets in after my patch series " [PATCH v1 00/11] scsi: ufs: bug fixes
patch series #1" (due to "[PATCH v1 06/11] scsi: ufs: suspend clock
scaling for failed runtime_resume"). so if you can, please pull in my
patch series and rebase your change on top of it and send it out again.
Thanks,
Subhash
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web