Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1508397 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-10-25 18:00 +0200 |
| Last post | 2016-10-25 18:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] [net-next] net: ip, diag: include net/inet_sock.h Arnd Bergmann <arnd@arndb.de> - 2016-10-25 18:00 +0200
Re: [PATCH] [net-next] net: ip, diag: include net/inet_sock.h Cyrill Gorcunov <gorcunov@gmail.com> - 2016-10-25 18:10 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-10-25 18:00 +0200 |
| Subject | [PATCH] [net-next] net: ip, diag: include net/inet_sock.h |
| Message-ID | <swciX-7zc-9@gated-at.bofh.it> |
The newly added raw_diag.c fails to build in some configurations
unless we include this header:
In file included from net/ipv4/raw_diag.c:6:0:
include/net/raw.h:71:21: error: field 'inet' has incomplete type
net/ipv4/raw_diag.c: In function 'raw_diag_dump':
net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk'
Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
net/ipv4/raw_diag.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/raw_diag.c b/net/ipv4/raw_diag.c
index ef3bea061b75..be930908bcf9 100644
--- a/net/ipv4/raw_diag.c
+++ b/net/ipv4/raw_diag.c
@@ -3,6 +3,7 @@
#include <linux/inet_diag.h>
#include <linux/sock_diag.h>
+#include <net/inet_sock.h>
#include <net/raw.h>
#include <net/rawv6.h>
--
2.9.0
[toc] | [next] | [standalone]
| From | Cyrill Gorcunov <gorcunov@gmail.com> |
|---|---|
| Date | 2016-10-25 18:10 +0200 |
| Message-ID | <swcsx-7SW-9@gated-at.bofh.it> |
| In reply to | #1508397 |
On Tue, Oct 25, 2016 at 05:53:22PM +0200, Arnd Bergmann wrote:
> The newly added raw_diag.c fails to build in some configurations
> unless we include this header:
>
> In file included from net/ipv4/raw_diag.c:6:0:
> include/net/raw.h:71:21: error: field 'inet' has incomplete type
> net/ipv4/raw_diag.c: In function 'raw_diag_dump':
> net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk'
>
> Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank you! And sorry for this, it didn't trigger on my testing.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web