Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1510557 > unrolled thread
| Started by | Borislav Petkov <bp@alien8.de> |
|---|---|
| First post | 2016-10-27 20:20 +0200 |
| Last post | 2016-10-28 11:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] kvm/x86: Show WRMSR data is in hex Borislav Petkov <bp@alien8.de> - 2016-10-27 20:20 +0200
Re: [PATCH] kvm/x86: Show WRMSR data is in hex Paolo Bonzini <pbonzini@redhat.com> - 2016-10-28 11:40 +0200
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-10-27 20:20 +0200 |
| Subject | [PATCH] kvm/x86: Show WRMSR data is in hex |
| Message-ID | <swXrr-5ri-7@gated-at.bofh.it> |
From: Borislav Petkov <bp@suse.de>
Add the "0x" prefix to the error messages format to make it unambiguous
about what kind of value we're talking about.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>
---
arch/x86/kvm/x86.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 7f9fa2d8f4e4..46cd7870d751 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -2262,7 +2262,7 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
/* Drop writes to this legacy MSR -- see rdmsr
* counterpart for further detail.
*/
- vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data %llx\n", msr, data);
+ vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data 0x%llx\n", msr, data);
break;
case MSR_AMD64_OSVW_ID_LENGTH:
if (!guest_cpuid_has_osvw(vcpu))
@@ -2280,11 +2280,11 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
if (kvm_pmu_is_valid_msr(vcpu, msr))
return kvm_pmu_set_msr(vcpu, msr_info);
if (!ignore_msrs) {
- vcpu_unimpl(vcpu, "unhandled wrmsr: 0x%x data %llx\n",
+ vcpu_unimpl(vcpu, "unhandled wrmsr: 0x%x data 0x%llx\n",
msr, data);
return 1;
} else {
- vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data %llx\n",
+ vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data 0x%llx\n",
msr, data);
break;
}
--
2.10.0
[toc] | [next] | [standalone]
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Date | 2016-10-28 11:40 +0200 |
| Message-ID | <sxbNL-6sc-27@gated-at.bofh.it> |
| In reply to | #1510557 |
On 27/10/2016 20:14, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Add the "0x" prefix to the error messages format to make it unambiguous
> about what kind of value we're talking about.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Radim Krčmář" <rkrcmar@redhat.com>
> ---
> arch/x86/kvm/x86.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 7f9fa2d8f4e4..46cd7870d751 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -2262,7 +2262,7 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
> /* Drop writes to this legacy MSR -- see rdmsr
> * counterpart for further detail.
> */
> - vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data %llx\n", msr, data);
> + vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data 0x%llx\n", msr, data);
> break;
> case MSR_AMD64_OSVW_ID_LENGTH:
> if (!guest_cpuid_has_osvw(vcpu))
> @@ -2280,11 +2280,11 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
> if (kvm_pmu_is_valid_msr(vcpu, msr))
> return kvm_pmu_set_msr(vcpu, msr_info);
> if (!ignore_msrs) {
> - vcpu_unimpl(vcpu, "unhandled wrmsr: 0x%x data %llx\n",
> + vcpu_unimpl(vcpu, "unhandled wrmsr: 0x%x data 0x%llx\n",
> msr, data);
> return 1;
> } else {
> - vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data %llx\n",
> + vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data 0x%llx\n",
> msr, data);
> break;
> }
>
Applied to kvm/master, thanks.
Paolo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web