Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1509299 > unrolled thread

[PATCH 4/5] misc: sgi-gru: print a hex number after a 0x prefix

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 4/5] misc: sgi-gru: print a hex number after a 0x prefix Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-10-26 15:00 +0200
    Re: [PATCH 4/5] misc: sgi-gru: print a hex number after a 0x prefix Dimitri Sivanich <sivanich@sgi.com> - 2016-10-26 23:00 +0200
      Re: [PATCH 4/5] misc: sgi-gru: print a hex number after a 0x prefix Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-10-27 08:10 +0200

#1509299 — [PATCH 4/5] misc: sgi-gru: print a hex number after a 0x prefix

It makes the result hard to interpret correctly if a base 10 number is
prefixed by 0x. So change to a hex number.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/misc/sgi-gru/grumain.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index 1525870f460a..cd9c1210a845 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -283,8 +283,9 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
 	spin_lock(&gru->gs_asid_lock);
 	BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
 	asids->mt_ctxbitmap ^= ctxbitmap;
-	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
-		gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
+	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
+		gru->gs_gid, gts, gms, (unsigned)gts->ts_ctxnum,
+		gms->ms_asidmap[0]);
 	spin_unlock(&gru->gs_asid_lock);
 	spin_unlock(&gms->ms_asid_lock);
 }
-- 
2.9.3

[toc] | [next] | [standalone]

#1509808

On Wed, Oct 26, 2016 at 02:56:57PM +0200, Uwe Kleine-König wrote:
> It makes the result hard to interpret correctly if a base 10 number is
> prefixed by 0x. So change to a hex number.
>

Would like to have this be a decimal number.

Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
---
 drivers/misc/sgi-gru/grumain.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index 1525870..33741ad 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
 	spin_lock(&gru->gs_asid_lock);
 	BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
 	asids->mt_ctxbitmap ^= ctxbitmap;
-	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
+	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum %d, asidmap 0x%lx\n",
 		gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
 	spin_unlock(&gru->gs_asid_lock);
 	spin_unlock(&gms->ms_asid_lock);

[toc] | [prev] | [next] | [standalone]

#1510063

On Wed, Oct 26, 2016 at 08:47:46AM -0500, Dimitri Sivanich wrote:
> On Wed, Oct 26, 2016 at 02:56:57PM +0200, Uwe Kleine-König wrote:
> > It makes the result hard to interpret correctly if a base 10 number is
> > prefixed by 0x. So change to a hex number.
> >
> 
> Would like to have this be a decimal number.

Then I assume you will care yourself for this patch and akpm will drop
it from his queue.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web