Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1507789 > unrolled thread

[PATCH 00/12] Additional iProc PCIe host support/fixes

Started byRay Jui <ray.jui@broadcom.com>
First post2016-10-25 00:20 +0200
Last post2016-10-25 01:00 +0200
Articles 10 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/12] Additional iProc PCIe host support/fixes Ray Jui <ray.jui@broadcom.com> - 2016-10-25 00:20 +0200
    [PATCH 02/12] PCI: iproc: Do not reset PAXC when initializing the driver Ray Jui <ray.jui@broadcom.com> - 2016-10-25 00:20 +0200
    [PATCH 05/12] PCI: iproc: Update iProc PCIe DT binding Ray Jui <ray.jui@broadcom.com> - 2016-10-25 00:20 +0200
    [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding Ray Jui <ray.jui@broadcom.com> - 2016-10-25 00:30 +0200
      Re: [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding Scott Branden <scott.branden@broadcom.com> - 2016-10-25 00:30 +0200
        Re: [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding Ray Jui <ray.jui@broadcom.com> - 2016-10-25 00:30 +0200
    Re: [PATCH 00/12] Additional iProc PCIe host support/fixes Scott Branden <scott.branden@broadcom.com> - 2016-10-25 00:40 +0200
      Re: [PATCH 00/12] Additional iProc PCIe host support/fixes Ray Jui <ray.jui@broadcom.com> - 2016-10-25 00:40 +0200
    Re: [PATCH 00/12] Additional iProc PCIe host support/fixes Bjorn Helgaas <helgaas@kernel.org> - 2016-10-25 01:00 +0200
      Re: [PATCH 00/12] Additional iProc PCIe host support/fixes Ray Jui <ray.jui@broadcom.com> - 2016-10-25 01:00 +0200

#1507789 — [PATCH 00/12] Additional iProc PCIe host support/fixes

FromRay Jui <ray.jui@broadcom.com>
Date2016-10-25 00:20 +0200
Subject[PATCH 00/12] Additional iProc PCIe host support/fixes
Message-ID<svVL4-5iq-7@gated-at.bofh.it>
This patch series contains various changes and fixes to the iProc PCIe
host driver. It also adds support for the next generation of PAXB and
PAXC based host controllers

This patch series was developed based on v4.9-rc1 and tested on both NS2
SVK and Cygnus wireless audio platform

repo: https://github.com/Broadcom/arm64-linux.git
branch: iproc-pcie-v1

Ray Jui (12):
  PCI: iproc: Improve core register population
  PCI: iproc: Do not reset PAXC when initializing the driver
  PCI: iproc: Add BCMA type
  PCI: iproc: Fix exception with multi-function devices
  PCI: iproc: Update iProc PCIe DT binding
  PCI: iproc: Add PAXC v2 support
  PCI: iproc: Update iProc PCIe DT binding
  PCI: iproc: Making outbound mapping code more generic
  PCI: iproc: Update iProc PCIe DT binding
  PCI: iproc: Add inbound DMA mapping support
  PCI: iproc: Update iProc PCIe DT binding
  PCI: iproc: Add support for the next-gen PAXB controller

 .../devicetree/bindings/pci/brcm,iproc-pcie.txt    |  43 +-
 drivers/pci/host/pcie-iproc-bcma.c                 |   1 +
 drivers/pci/host/pcie-iproc-msi.c                  |   1 +
 drivers/pci/host/pcie-iproc-platform.c             |  19 +-
 drivers/pci/host/pcie-iproc.c                      | 942 ++++++++++++++++++---
 drivers/pci/host/pcie-iproc.h                      |  45 +-
 6 files changed, 916 insertions(+), 135 deletions(-)

-- 
2.1.4

[toc] | [next] | [standalone]

#1507790 — [PATCH 02/12] PCI: iproc: Do not reset PAXC when initializing the driver

FromRay Jui <ray.jui@broadcom.com>
Date2016-10-25 00:20 +0200
Subject[PATCH 02/12] PCI: iproc: Do not reset PAXC when initializing the driver
Message-ID<svVL4-5iq-37@gated-at.bofh.it>
In reply to#1507789
During initialization, the current iProc PCIe host driver resets PAXC
and the downstream internal endpoint device that PAXC connects to. If
the endpoint device is already loaded with firmware and has started
running from the bootloader stage, this downstream reset causes the
endpoint device to stop working

Signed-off-by: Ray Jui <raj.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
---
 drivers/pci/host/pcie-iproc.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c
index a9b9cd8..3f4884a 100644
--- a/drivers/pci/host/pcie-iproc.c
+++ b/drivers/pci/host/pcie-iproc.c
@@ -243,16 +243,13 @@ static void iproc_pcie_reset(struct iproc_pcie *pcie)
 {
 	u32 val;
 
-	if (pcie->ep_is_internal) {
-		val = iproc_pcie_read_reg(pcie, IPROC_PCIE_CLK_CTRL);
-		val &= ~PAXC_RESET_MASK;
-		iproc_pcie_write_reg(pcie, IPROC_PCIE_CLK_CTRL, val);
-		udelay(100);
-		val |= PAXC_RESET_MASK;
-		iproc_pcie_write_reg(pcie, IPROC_PCIE_CLK_CTRL, val);
-		udelay(100);
+	/*
+	 * PAXC and the internal emulated endpoint device downstream should not
+	 * be reset. If firmware has been loaded on the endpoint device at an
+	 * earlier boot stage, reset here causes issues
+	 */
+	if (pcie->ep_is_internal)
 		return;
-	}
 
 	/*
 	 * Select perst_b signal as reset source. Put the device into reset,
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1507791 — [PATCH 05/12] PCI: iproc: Update iProc PCIe DT binding

FromRay Jui <ray.jui@broadcom.com>
Date2016-10-25 00:20 +0200
Subject[PATCH 05/12] PCI: iproc: Update iProc PCIe DT binding
Message-ID<svVL4-5iq-35@gated-at.bofh.it>
In reply to#1507789
Add new compatible string "brcm,iproc-pcie-paxc-v2" to the iProc
PCIe device tree binding document. "brcm,iproc-pcie-paxc-v2" is for the
second generation of the Broadcom iProc PCIe PAXC host controller

Also updated the binding document with more detailed description of
each compatible string and compatible SoCs

Finally, added description of optional property "msi-map", for use with
MSI controllers with sideband data

Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
---
 .../devicetree/bindings/pci/brcm,iproc-pcie.txt    | 31 ++++++++++++++++------
 1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
index 01b88f4..071bbc2 100644
--- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
@@ -1,10 +1,15 @@
 * Broadcom iProc PCIe controller with the platform bus interface
 
 Required properties:
-- compatible: Must be "brcm,iproc-pcie" for PAXB, or "brcm,iproc-pcie-paxc"
-  for PAXC.  PAXB-based root complex is used for external endpoint devices.
-  PAXC-based root complex is connected to emulated endpoint devices
-  internal to the ASIC
+- compatible:
+      "brcm,iproc-pcie" for the first generation of PAXB based controller,
+used in SoCs including NSP, Cygnus, NS2, and Pegasus
+      "brcm,iproc-pcie-paxc" for the first generation of PAXC based
+controller, used in NS2
+      "brcm,iproc-pcie-paxc-v2" for the second generation of PAXC based
+controller, used in Stingray
+  PAXB-based root complex is used for external endpoint devices. PAXC-based
+root complex is connected to emulated endpoint devices internal to the ASIC
 - reg: base address and length of the PCIe controller I/O register space
 - #interrupt-cells: set to <1>
 - interrupt-map-mask and interrupt-map, standard PCI properties to define the
@@ -19,6 +24,7 @@ Required properties:
 Optional properties:
 - phys: phandle of the PCIe PHY device
 - phy-names: must be "pcie-phy"
+- dma-coherent: present if DMA operations are coherent
 
 - brcm,pcie-ob: Some iProc SoCs do not have the outbound address mapping done
 by the ASIC after power on reset. In this case, SW needs to configure it
@@ -41,10 +47,19 @@ For older platforms without MSI integrated in the GIC, iProc PCIe core provides
 an event queue based MSI support.  The iProc MSI uses host memories to store
 MSI posted writes in the event queues
 
-- msi-parent: Link to the device node of the MSI controller.  On newer iProc
-platforms, the MSI controller may be gicv2m or gicv3-its.  On older iProc
-platforms without MSI support in its interrupt controller, one may use the
-event queue based MSI support integrated within the iProc PCIe core.
+On newer iProc platforms, gicv2m or gicv3-its based MSI support should be used
+
+- msi-map: Maps a Requester ID to an MSI controller and associated MSI
+sideband data
+
+- msi-parent: Link to the device node of the MSI controller, used when no MSI
+sideband data is passed between the iProc PCIe controller and the MSI
+controller
+
+Refer to the following binding documents for more detailed description on
+the use of 'msi-map' and 'msi-parent':
+  Documentation/devicetree/bindings/pci/pci-msi.txt
+  Documentation/devicetree/bindings/interrupt-controller/msi.txt
 
 When the iProc event queue based MSI is used, one needs to define the
 following properties in the MSI device node:
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1507793 — [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding

FromRay Jui <ray.jui@broadcom.com>
Date2016-10-25 00:30 +0200
Subject[PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding
Message-ID<svVUJ-5lu-7@gated-at.bofh.it>
In reply to#1507789
Remove the following outbound related device tree properties:
brcm,pcie-ob-window-size
brcm,pcie-ob-oarr-size

The above two prperties are a bit duplicated in functions. In addition,
the next generation iProc PCIe controller has outbound mapping window that
supports more than just two sizes, which cannot be properly supported by
these properties

A better solution is to make the driver outbound mapping logic slightly
more inteligent so it can figure out how to configure the outbound mapping
based on the 'ranges' specified in device tree and the number and sizes
of the outbound mapping windows that a particular revision of the iProc
PCIe controller can support

Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
---
 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
index 071bbc2..f827b8d 100644
--- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
@@ -35,11 +35,6 @@ effective:
 Required:
 - brcm,pcie-ob-axi-offset: The offset from the AXI address to the internal
 address used by the iProc PCIe core (not the PCIe address)
-- brcm,pcie-ob-window-size: The outbound address mapping window size (in MB)
-
-Optional:
-- brcm,pcie-ob-oarr-size: Some iProc SoCs need the OARR size bit to be set to
-increase the outbound window size
 
 MSI support (optional):
 
@@ -95,9 +90,7 @@ Example:
 		phy-names = "pcie-phy";
 
 		brcm,pcie-ob;
-		brcm,pcie-ob-oarr-size;
 		brcm,pcie-ob-axi-offset = <0x00000000>;
-		brcm,pcie-ob-window-size = <256>;
 
 		msi-parent = <&msi0>;
 
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1507795 — Re: [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding

FromScott Branden <scott.branden@broadcom.com>
Date2016-10-25 00:30 +0200
SubjectRe: [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding
Message-ID<svVUK-5lu-19@gated-at.bofh.it>
In reply to#1507793
2 spelling typos

On 16-10-24 03:17 PM, Ray Jui wrote:
> Remove the following outbound related device tree properties:
> brcm,pcie-ob-window-size
> brcm,pcie-ob-oarr-size
>
> The above two prperties are a bit duplicated in functions. In addition,
properties typo
> the next generation iProc PCIe controller has outbound mapping window that
> supports more than just two sizes, which cannot be properly supported by
> these properties
>
> A better solution is to make the driver outbound mapping logic slightly
> more inteligent so it can figure out how to configure the outbound mapping
intelligent typo
> based on the 'ranges' specified in device tree and the number and sizes
> of the outbound mapping windows that a particular revision of the iProc
> PCIe controller can support
>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
>  Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> index 071bbc2..f827b8d 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
> @@ -35,11 +35,6 @@ effective:
>  Required:
>  - brcm,pcie-ob-axi-offset: The offset from the AXI address to the internal
>  address used by the iProc PCIe core (not the PCIe address)
> -- brcm,pcie-ob-window-size: The outbound address mapping window size (in MB)
> -
> -Optional:
> -- brcm,pcie-ob-oarr-size: Some iProc SoCs need the OARR size bit to be set to
> -increase the outbound window size
>
>  MSI support (optional):
>
> @@ -95,9 +90,7 @@ Example:
>  		phy-names = "pcie-phy";
>
>  		brcm,pcie-ob;
> -		brcm,pcie-ob-oarr-size;
>  		brcm,pcie-ob-axi-offset = <0x00000000>;
> -		brcm,pcie-ob-window-size = <256>;
>
>  		msi-parent = <&msi0>;
>
>

[toc] | [prev] | [next] | [standalone]

#1507800 — Re: [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding

FromRay Jui <ray.jui@broadcom.com>
Date2016-10-25 00:30 +0200
SubjectRe: [PATCH 07/12] PCI: iproc: Update iProc PCIe DT binding
Message-ID<svVUK-5lu-29@gated-at.bofh.it>
In reply to#1507795
Thanks! Will address both typos in the next revision. Waiting for 
feedback from Bjorn before sending out the next revision.

Ray

On 10/24/2016 3:24 PM, Scott Branden wrote:
> 2 spelling typos
>
> On 16-10-24 03:17 PM, Ray Jui wrote:
>> Remove the following outbound related device tree properties:
>> brcm,pcie-ob-window-size
>> brcm,pcie-ob-oarr-size
>>
>> The above two prperties are a bit duplicated in functions. In addition,
> properties typo
>> the next generation iProc PCIe controller has outbound mapping window
>> that
>> supports more than just two sizes, which cannot be properly supported by
>> these properties
>>
>> A better solution is to make the driver outbound mapping logic slightly
>> more inteligent so it can figure out how to configure the outbound
>> mapping
> intelligent typo
>> based on the 'ranges' specified in device tree and the number and sizes
>> of the outbound mapping windows that a particular revision of the iProc
>> PCIe controller can support
>>
>> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>>  Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> index 071bbc2..f827b8d 100644
>> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt
>> @@ -35,11 +35,6 @@ effective:
>>  Required:
>>  - brcm,pcie-ob-axi-offset: The offset from the AXI address to the
>> internal
>>  address used by the iProc PCIe core (not the PCIe address)
>> -- brcm,pcie-ob-window-size: The outbound address mapping window size
>> (in MB)
>> -
>> -Optional:
>> -- brcm,pcie-ob-oarr-size: Some iProc SoCs need the OARR size bit to
>> be set to
>> -increase the outbound window size
>>
>>  MSI support (optional):
>>
>> @@ -95,9 +90,7 @@ Example:
>>          phy-names = "pcie-phy";
>>
>>          brcm,pcie-ob;
>> -        brcm,pcie-ob-oarr-size;
>>          brcm,pcie-ob-axi-offset = <0x00000000>;
>> -        brcm,pcie-ob-window-size = <256>;
>>
>>          msi-parent = <&msi0>;
>>
>>

[toc] | [prev] | [next] | [standalone]

#1507804

FromScott Branden <scott.branden@broadcom.com>
Date2016-10-25 00:40 +0200
Message-ID<svW4p-5oE-17@gated-at.bofh.it>
In reply to#1507789
Looks fine other than spelling mistakes in some commit messages.

Acked-by: Scott Branden <scott.branden@broadcom.com>

On 16-10-24 03:17 PM, Ray Jui wrote:
> This patch series contains various changes and fixes to the iProc PCIe
> host driver. It also adds support for the next generation of PAXB and
> PAXC based host controllers
>
> This patch series was developed based on v4.9-rc1 and tested on both NS2
> SVK and Cygnus wireless audio platform
>
> repo: https://github.com/Broadcom/arm64-linux.git
> branch: iproc-pcie-v1
>
> Ray Jui (12):
>   PCI: iproc: Improve core register population
>   PCI: iproc: Do not reset PAXC when initializing the driver
>   PCI: iproc: Add BCMA type
>   PCI: iproc: Fix exception with multi-function devices
>   PCI: iproc: Update iProc PCIe DT binding
>   PCI: iproc: Add PAXC v2 support
>   PCI: iproc: Update iProc PCIe DT binding
>   PCI: iproc: Making outbound mapping code more generic
>   PCI: iproc: Update iProc PCIe DT binding
>   PCI: iproc: Add inbound DMA mapping support
>   PCI: iproc: Update iProc PCIe DT binding
>   PCI: iproc: Add support for the next-gen PAXB controller
>
>  .../devicetree/bindings/pci/brcm,iproc-pcie.txt    |  43 +-
>  drivers/pci/host/pcie-iproc-bcma.c                 |   1 +
>  drivers/pci/host/pcie-iproc-msi.c                  |   1 +
>  drivers/pci/host/pcie-iproc-platform.c             |  19 +-
>  drivers/pci/host/pcie-iproc.c                      | 942 ++++++++++++++++++---
>  drivers/pci/host/pcie-iproc.h                      |  45 +-
>  6 files changed, 916 insertions(+), 135 deletions(-)
>

[toc] | [prev] | [next] | [standalone]

#1507806

FromRay Jui <ray.jui@broadcom.com>
Date2016-10-25 00:40 +0200
Message-ID<svW4p-5oE-25@gated-at.bofh.it>
In reply to#1507804

On 10/24/2016 3:30 PM, Scott Branden wrote:
> Looks fine other than spelling mistakes in some commit messages.
>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
>

Thanks, Scott. I will address those in the next revision of patchset. 
But would like to get some comments from Bjorn before sending out the 
next patchset.


> On 16-10-24 03:17 PM, Ray Jui wrote:
>> This patch series contains various changes and fixes to the iProc PCIe
>> host driver. It also adds support for the next generation of PAXB and
>> PAXC based host controllers
>>
>> This patch series was developed based on v4.9-rc1 and tested on both NS2
>> SVK and Cygnus wireless audio platform
>>
>> repo: https://github.com/Broadcom/arm64-linux.git
>> branch: iproc-pcie-v1
>>
>> Ray Jui (12):
>>   PCI: iproc: Improve core register population
>>   PCI: iproc: Do not reset PAXC when initializing the driver
>>   PCI: iproc: Add BCMA type
>>   PCI: iproc: Fix exception with multi-function devices
>>   PCI: iproc: Update iProc PCIe DT binding
>>   PCI: iproc: Add PAXC v2 support
>>   PCI: iproc: Update iProc PCIe DT binding
>>   PCI: iproc: Making outbound mapping code more generic
>>   PCI: iproc: Update iProc PCIe DT binding
>>   PCI: iproc: Add inbound DMA mapping support
>>   PCI: iproc: Update iProc PCIe DT binding
>>   PCI: iproc: Add support for the next-gen PAXB controller
>>
>>  .../devicetree/bindings/pci/brcm,iproc-pcie.txt    |  43 +-
>>  drivers/pci/host/pcie-iproc-bcma.c                 |   1 +
>>  drivers/pci/host/pcie-iproc-msi.c                  |   1 +
>>  drivers/pci/host/pcie-iproc-platform.c             |  19 +-
>>  drivers/pci/host/pcie-iproc.c                      | 942
>> ++++++++++++++++++---
>>  drivers/pci/host/pcie-iproc.h                      |  45 +-
>>  6 files changed, 916 insertions(+), 135 deletions(-)
>>

[toc] | [prev] | [next] | [standalone]

#1507814

FromBjorn Helgaas <helgaas@kernel.org>
Date2016-10-25 01:00 +0200
Message-ID<svWnM-5vy-31@gated-at.bofh.it>
In reply to#1507789
Hi Ray,

On Mon, Oct 24, 2016 at 03:17:00PM -0700, Ray Jui wrote:
> This patch series contains various changes and fixes to the iProc PCIe
> host driver. It also adds support for the next generation of PAXB and
> PAXC based host controllers
> 
> This patch series was developed based on v4.9-rc1 and tested on both NS2
> SVK and Cygnus wireless audio platform
> 
> repo: https://github.com/Broadcom/arm64-linux.git
> branch: iproc-pcie-v1
> 
> Ray Jui (12):
>   PCI: iproc: Improve core register population
>   PCI: iproc: Do not reset PAXC when initializing the driver
>   PCI: iproc: Add BCMA type
>   PCI: iproc: Fix exception with multi-function devices
>   PCI: iproc: Update iProc PCIe DT binding
>   PCI: iproc: Add PAXC v2 support
>   PCI: iproc: Update iProc PCIe DT binding
>   PCI: iproc: Making outbound mapping code more generic
>   PCI: iproc: Update iProc PCIe DT binding
>   PCI: iproc: Add inbound DMA mapping support
>   PCI: iproc: Update iProc PCIe DT binding
>   PCI: iproc: Add support for the next-gen PAXB controller

I'll look at these more soon, but there are four patches above with
identical titles ("PCI: iproc: Update iProc PCIe DT binding").  The
"iProc PCIe" part is a little redundant; can you remove that and
instead include a hint about what each patch is about, e.g.,
"add optional dma-ranges", "remove outbound window properties", etc?

>  .../devicetree/bindings/pci/brcm,iproc-pcie.txt    |  43 +-
>  drivers/pci/host/pcie-iproc-bcma.c                 |   1 +
>  drivers/pci/host/pcie-iproc-msi.c                  |   1 +
>  drivers/pci/host/pcie-iproc-platform.c             |  19 +-
>  drivers/pci/host/pcie-iproc.c                      | 942 ++++++++++++++++++---
>  drivers/pci/host/pcie-iproc.h                      |  45 +-
>  6 files changed, 916 insertions(+), 135 deletions(-)
> 
> -- 
> 2.1.4
>

[toc] | [prev] | [next] | [standalone]

#1507816

FromRay Jui <ray.jui@broadcom.com>
Date2016-10-25 01:00 +0200
Message-ID<svWnM-5vy-37@gated-at.bofh.it>
In reply to#1507814
Hi Bjorn,

On 10/24/2016 3:52 PM, Bjorn Helgaas wrote:
> Hi Ray,
>
> On Mon, Oct 24, 2016 at 03:17:00PM -0700, Ray Jui wrote:
>> This patch series contains various changes and fixes to the iProc PCIe
>> host driver. It also adds support for the next generation of PAXB and
>> PAXC based host controllers
>>
>> This patch series was developed based on v4.9-rc1 and tested on both NS2
>> SVK and Cygnus wireless audio platform
>>
>> repo: https://github.com/Broadcom/arm64-linux.git
>> branch: iproc-pcie-v1
>>
>> Ray Jui (12):
>>   PCI: iproc: Improve core register population
>>   PCI: iproc: Do not reset PAXC when initializing the driver
>>   PCI: iproc: Add BCMA type
>>   PCI: iproc: Fix exception with multi-function devices
>>   PCI: iproc: Update iProc PCIe DT binding
>>   PCI: iproc: Add PAXC v2 support
>>   PCI: iproc: Update iProc PCIe DT binding
>>   PCI: iproc: Making outbound mapping code more generic
>>   PCI: iproc: Update iProc PCIe DT binding
>>   PCI: iproc: Add inbound DMA mapping support
>>   PCI: iproc: Update iProc PCIe DT binding
>>   PCI: iproc: Add support for the next-gen PAXB controller
>
> I'll look at these more soon, but there are four patches above with
> identical titles ("PCI: iproc: Update iProc PCIe DT binding").  The
> "iProc PCIe" part is a little redundant; can you remove that and
> instead include a hint about what each patch is about, e.g.,
> "add optional dma-ranges", "remove outbound window properties", etc?
>

Yes, I'll certainly do that in the next revision of the patchset.

Thanks,

Ray

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web