Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1507651 > unrolled thread
| Started by | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| First post | 2016-10-24 21:20 +0200 |
| Last post | 2016-10-27 00:20 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/3] phy: sun4i: check PHY id when poking unknown bit of pmu Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-24 21:20 +0200
Re: [PATCH 1/3] phy: sun4i: check PHY id when poking unknown bit of pmu Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-27 00:20 +0200
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-10-24 21:20 +0200 |
| Subject | Re: [PATCH 1/3] phy: sun4i: check PHY id when poking unknown bit of pmu |
| Message-ID | <svSWS-3rd-41@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Mon, Oct 24, 2016 at 11:59:30AM +0800, Icenowy Zheng wrote: > Allwinner SoC's PHY 0, when used as OTG controller, have no pmu part. > The code that poke some unknown bit of PMU for H3/A64 didn't check > the PHY, and will cause kernel oops when PHY 0 is used. > > Fixes: b3e0d141ca9f (phy: sun4i: add support for A64 usb phy) > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> Cc'ing stable would be nice. Apart from that, Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-10-27 00:20 +0200 |
| Message-ID | <swEIa-1vJ-7@gated-at.bofh.it> |
| In reply to | #1507651 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Tue, Oct 25, 2016 at 11:32:44AM +0800, Icenowy Zheng wrote: > > > > On Mon, Oct 24, 2016 at 11:59:30AM +0800, Icenowy Zheng wrote: > > > >> Allwinner SoC's PHY 0, when used as OTG controller, have no pmu part. > >> The code that poke some unknown bit of PMU for H3/A64 didn't check > >> the PHY, and will cause kernel oops when PHY 0 is used. > >> > >> Fixes: b3e0d141ca9f (phy: sun4i: add support for A64 usb phy) > >> > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> > > > > Cc'ing stable would be nice. > > Yes... As it's also used by H3... > > > > > Apart from that, Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > If I change it to check whether phy->pmu is null, will you keep the ACK? Yep, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web