Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1507167 > unrolled thread
| Started by | Stefan Richter <stefanr@s5r6.in-berlin.de> |
|---|---|
| First post | 2016-10-24 14:50 +0200 |
| Last post | 2016-10-25 05:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] ethernet: fix min/max MTU typos Stefan Richter <stefanr@s5r6.in-berlin.de> - 2016-10-24 14:50 +0200
Re: [PATCH net-next] ethernet: fix min/max MTU typos Jarod Wilson <jarod@redhat.com> - 2016-10-25 05:10 +0200
| From | Stefan Richter <stefanr@s5r6.in-berlin.de> |
|---|---|
| Date | 2016-10-24 14:50 +0200 |
| Subject | [PATCH net-next] ethernet: fix min/max MTU typos |
| Message-ID | <svMRr-7EB-17@gated-at.bofh.it> |
Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
CC: Jarod Wilson <jarod@redhat.com>
CC: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/net/ethernet/broadcom/sb1250-mac.c | 2 +-
drivers/net/ethernet/ibm/ibmveth.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c
index cb312e4c89f4..435a2e4739d1 100644
--- a/drivers/net/ethernet/broadcom/sb1250-mac.c
+++ b/drivers/net/ethernet/broadcom/sb1250-mac.c
@@ -2219,7 +2219,7 @@ static int sbmac_init(struct platform_device *pldev, long long base)
dev->netdev_ops = &sbmac_netdev_ops;
dev->watchdog_timeo = TX_TIMEOUT;
- dev->max_mtu = 0;
+ dev->min_mtu = 0;
dev->max_mtu = ENET_PACKET_SIZE;
netif_napi_add(dev, &sc->napi, sbmac_poll, 16);
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 29c05d0d79a9..4a81c892fc31 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1549,7 +1549,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
}
netdev->min_mtu = IBMVETH_MIN_MTU;
- netdev->min_mtu = ETH_MAX_MTU;
+ netdev->max_mtu = ETH_MAX_MTU;
memcpy(netdev->dev_addr, mac_addr_p, ETH_ALEN);
--
Stefan Richter
-======----- =-=- ==---
http://arcgraph.de/sr/
[toc] | [next] | [standalone]
| From | Jarod Wilson <jarod@redhat.com> |
|---|---|
| Date | 2016-10-25 05:10 +0200 |
| Message-ID | <sw0hH-8lF-9@gated-at.bofh.it> |
| In reply to | #1507167 |
On Mon, Oct 24, 2016 at 02:42:26PM +0200, Stefan Richter wrote:
> Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
> CC: Jarod Wilson <jarod@redhat.com>
> CC: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Wuf. Thank you, Stefan. Way too many bleeding eyeball hours staring at all
those changes.
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web