Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505321 > unrolled thread

Re: [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] clk: Register clkdev after setup of fixed-rate and  fixed-factor clocks Stephen Boyd <sboyd@codeaurora.org> - 2016-10-21 01:10 +0200
    Re: [PATCH] clk: Register clkdev after setup of fixed-rate and  fixed-factor clocks Xiaolong Zhang <xiaolong.zhang@spreadtrum.com> - 2016-10-22 10:40 +0200
      Re: [PATCH] clk: Register clkdev after setup of fixed-rate and  fixed-factor clocks Stephen Boyd <sboyd@codeaurora.org> - 2016-10-25 22:50 +0200

#1505321 — Re: [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks

On 10/11, Orson Zhai wrote:
> From: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
> 
> When common kernel setups fixed clock, of_clk_provider will be registerred.
> But there is no clkdev being registerred at the same time. This will make
> it difficult to get the clock by using clk_get(NULL, con_id).
> 
> Add clkdev register for fixed-rate and fixed-factor clock and ignore
> the error if any.
> 
> Signed-off-by: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
> Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com>
> ---

Why are we using clkdev lookups for clks populated from DT?
Shouldn't we be able to point to them from the consumers that
would also be in DT? I'm a little lost.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [next] | [standalone]

#1506398

On 四, 10月 20, 2016 at 04:01:03下午 -0700, Stephen Boyd wrote:
> On 10/11, Orson Zhai wrote:
> > From: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
> > 
> > When common kernel setups fixed clock, of_clk_provider will be registerred.
> > But there is no clkdev being registerred at the same time. This will make
> > it difficult to get the clock by using clk_get(NULL, con_id).
> > 
> > Add clkdev register for fixed-rate and fixed-factor clock and ignore
> > the error if any.
> > 
> > Signed-off-by: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
> > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com>
> > ---
> 
> Why are we using clkdev lookups for clks populated from DT?
> Shouldn't we be able to point to them from the consumers that
> would also be in DT? I'm a little lost.
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
The clk_get interface allows the first argument as NULL. We just assure
consumers can get the clock from DT or by clock name.

[toc] | [prev] | [next] | [standalone]

#1508618

On 10/22, Xiaolong Zhang wrote:
> On 四, 10月 20, 2016 at 04:01:03下午 -0700, Stephen Boyd wrote:
> > On 10/11, Orson Zhai wrote:
> > > From: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
> > > 
> > > When common kernel setups fixed clock, of_clk_provider will be registerred.
> > > But there is no clkdev being registerred at the same time. This will make
> > > it difficult to get the clock by using clk_get(NULL, con_id).
> > > 
> > > Add clkdev register for fixed-rate and fixed-factor clock and ignore
> > > the error if any.
> > > 
> > > Signed-off-by: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
> > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com>
> > > ---
> > 
> > Why are we using clkdev lookups for clks populated from DT?
> > Shouldn't we be able to point to them from the consumers that
> > would also be in DT? I'm a little lost.
> > 
> The clk_get interface allows the first argument as NULL. We just assure
> consumers can get the clock from DT or by clock name.

Ok. The first argument to clk_get() really shouldn't be NULL. It
should be the device pointer for the device that is associated
with the clk you want to get. The clock name (second argument to
clk_get()) should be device specific and not some globally unique
identifier. It seems that you're using the clk_get() API
incorrectly.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web