Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1504911 > unrolled thread
| Started by | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| First post | 2016-10-20 16:00 +0200 |
| Last post | 2016-10-21 12:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v3 0/6] pinctrl: sunxi: Generic bindings rework Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-20 16:00 +0200
[PATCH v3 1/6] pinctrl: sunxi: Deal with configless pins Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-20 16:00 +0200
Re: [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner,pull property Jean-Francois Moine <moinejf@free.fr> - 2016-10-20 17:40 +0200
Re: [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner,pull property Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-21 12:50 +0200
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-10-20 16:00 +0200 |
| Subject | [PATCH v3 0/6] pinctrl: sunxi: Generic bindings rework |
| Message-ID | <sulTj-8b6-21@gated-at.bofh.it> |
Hi, This patch set reworks the Allwinner pinctrl driver to support the generic pin configuration and multiplexing bindings. In the process, we also covered some lasting issues that were found: we were ignoring the case where no pull-up was set, and while our binding was saying that the allwinner,drive and allwinner,pull properties were optional, the code was not able to deal with the case where they were not present. Changes from v2: - Added Rob, Linus and Chen-Yu's acked-by - Removed unused variable - Dropped the patches already applied by Linus Changes from v1: - Realloced the pinctrl_map array - Detailed the generic properties we support - Directly return the parsing functions return code - Called kfree on the pinconfig directly - Added Chen-Yu Acked-by - Changed the patch 2 commit log as suggested Maxime Ripard (6): pinctrl: sunxi: Deal with configless pins pinctrl: sunxi: Support generic binding dt-bindings: pinctrl: Deprecate sunxi pinctrl bindings ARM: sunxi: Remove useless allwinner,drive property ARM: sunxi: Remove useless allwinner,pull property ARM: sunxi: Convert pinctrl nodes to generic bindings Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt | 16 ++++- arch/arm/boot/dts/ntc-gr8-evb.dts | 24 ++---- arch/arm/boot/dts/ntc-gr8.dtsi | 104 +++++++++------------------ arch/arm/boot/dts/sun4i-a10-a1000.dts | 12 +-- arch/arm/boot/dts/sun4i-a10-ba10-tvbox.dts | 2 +- arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 14 +--- arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 14 +--- arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts | 38 +++------- arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 6 +-- arch/arm/boot/dts/sun4i-a10-hackberry.dts | 12 +-- arch/arm/boot/dts/sun4i-a10-hyundai-a7hd.dts | 16 +--- arch/arm/boot/dts/sun4i-a10-inet1.dts | 26 ++----- arch/arm/boot/dts/sun4i-a10-inet97fv2.dts | 14 +--- arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 29 +++----- arch/arm/boot/dts/sun4i-a10-jesurun-q5.dts | 12 +-- arch/arm/boot/dts/sun4i-a10-marsboard.dts | 13 +-- arch/arm/boot/dts/sun4i-a10-mini-xplus.dts | 2 +- arch/arm/boot/dts/sun4i-a10-mk802.dts | 18 +---- arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 27 ++----- arch/arm/boot/dts/sun4i-a10-pcduino.dts | 19 +---- arch/arm/boot/dts/sun4i-a10-pcduino2.dts | 6 +-- arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 32 +++----- arch/arm/boot/dts/sun4i-a10.dtsi | 169 +++++++++++++++----------------------------- arch/arm/boot/dts/sun5i-a10s-auxtek-t003.dts | 18 ++--- arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts | 29 +++----- arch/arm/boot/dts/sun5i-a10s-mk802.dts | 19 +---- arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 36 +++------ arch/arm/boot/dts/sun5i-a10s-r7-tv-dongle.dts | 20 ++--- arch/arm/boot/dts/sun5i-a10s-wobo-i5.dts | 21 +---- arch/arm/boot/dts/sun5i-a10s.dtsi | 61 ++++++---------- arch/arm/boot/dts/sun5i-a13-empire-electronix-d709.dts | 23 ++---- arch/arm/boot/dts/sun5i-a13-hsg-h702.dts | 22 ++---- arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 40 ++++------ arch/arm/boot/dts/sun5i-a13-olinuxino.dts | 36 +++------ arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 17 +--- arch/arm/boot/dts/sun5i-a13.dtsi | 24 ++---- arch/arm/boot/dts/sun5i-r8-chip.dts | 12 +-- arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi | 33 +++------ arch/arm/boot/dts/sun5i.dtsi | 57 +++++---------- arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 6 +-- arch/arm/boot/dts/sun6i-a31-colombus.dts | 22 ++---- arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 23 ++---- arch/arm/boot/dts/sun6i-a31-i7.dts | 19 +---- arch/arm/boot/dts/sun6i-a31-m9.dts | 19 +---- arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 19 +---- arch/arm/boot/dts/sun6i-a31.dtsi | 136 ++++++++++++++--------------------- arch/arm/boot/dts/sun6i-a31s-primo81.dts | 20 ++--- arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 13 +-- arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts | 29 +++----- arch/arm/boot/dts/sun6i-a31s-yones-toptech-bs1078-v2.dts | 9 +-- arch/arm/boot/dts/sun6i-reference-design-tablet.dtsi | 14 +--- arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 27 ++----- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 26 ++----- arch/arm/boot/dts/sun7i-a20-bananapro.dts | 37 +++------- arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 13 +-- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 38 +++------- arch/arm/boot/dts/sun7i-a20-hummingbird.dts | 24 ++---- arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts | 26 ++----- arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 7 +-- arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 30 +++----- arch/arm/boot/dts/sun7i-a20-m3.dts | 6 +-- arch/arm/boot/dts/sun7i-a20-mk808c.dts | 12 +-- arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 32 +++----- arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 27 ++----- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts | 6 +-- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 33 +++------ arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 28 +++---- arch/arm/boot/dts/sun7i-a20-orangepi-mini.dts | 45 ++++-------- arch/arm/boot/dts/sun7i-a20-orangepi.dts | 38 +++------- arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 25 ++---- arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 21 +---- arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 25 ++---- arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts | 13 +-- arch/arm/boot/dts/sun7i-a20.dtsi | 277 ++++++++++++++++++++++++++---------------------------------------------- arch/arm/boot/dts/sun8i-a23-a33.dtsi | 95 ++++++++++--------------- arch/arm/boot/dts/sun8i-a23-evb.dts | 7 +-- arch/arm/boot/dts/sun8i-a23-polaroid-mid2407pxe03.dts | 8 +-- arch/arm/boot/dts/sun8i-a23-polaroid-mid2809pxe04.dts | 8 +-- arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 9 +-- arch/arm/boot/dts/sun8i-a33-olinuxino.dts | 18 +---- arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts | 11 +-- arch/arm/boot/dts/sun8i-a33.dtsi | 6 +-- arch/arm/boot/dts/sun8i-a83t.dtsi | 21 +---- arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 18 +---- arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 12 +-- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 26 ++----- arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 18 +---- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 18 +---- arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts | 4 +- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 18 +---- arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 10 +-- arch/arm/boot/dts/sun8i-h3.dtsi | 92 +++++++++--------------- arch/arm/boot/dts/sun8i-q8-common.dtsi | 9 +-- arch/arm/boot/dts/sun8i-r16-parrot.dts | 36 +++------ arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 26 ++----- arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 15 +--- arch/arm/boot/dts/sun9i-a80-optimus.dts | 33 +++------ arch/arm/boot/dts/sun9i-a80.dtsi | 54 +++++--------- arch/arm/boot/dts/sunxi-common-regulators.dtsi | 24 ++---- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 99 +++++++++++++++++++++----- 100 files changed, 1176 insertions(+), 1757 deletions(-) -- git-series 0.8.10
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-10-20 16:00 +0200 |
| Subject | [PATCH v3 1/6] pinctrl: sunxi: Deal with configless pins |
| Message-ID | <sum30-8m4-21@gated-at.bofh.it> |
| In reply to | #1504911 |
Even though the our binding had the assumption that the allwinner,pull and
allwinner,drive properties were optional, the code never took that into
account.
Fix that.
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
---
drivers/pinctrl/sunxi/pinctrl-sunxi.c | 51 ++++++++++++++++++++--------
1 file changed, 37 insertions(+), 14 deletions(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index c44bf1320e08..12650904bd96 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -217,20 +217,29 @@ static unsigned long *sunxi_pctrl_build_pin_config(struct device_node *node,
{
unsigned long *pinconfig;
unsigned int configlen = 0, idx = 0;
+ int ret;
if (sunxi_pctrl_has_drive_prop(node))
configlen++;
if (sunxi_pctrl_has_bias_prop(node))
configlen++;
+ /*
+ * If we don't have any configuration, bail out
+ */
+ if (!configlen)
+ return NULL;
+
pinconfig = kzalloc(configlen * sizeof(*pinconfig), GFP_KERNEL);
if (!pinconfig)
- return NULL;
+ return ERR_PTR(-ENOMEM);
if (sunxi_pctrl_has_drive_prop(node)) {
int drive = sunxi_pctrl_parse_drive_prop(node);
- if (drive < 0)
+ if (drive < 0) {
+ ret = drive;
goto err_free;
+ }
pinconfig[idx++] = pinconf_to_config_packed(PIN_CONFIG_DRIVE_STRENGTH,
drive);
@@ -238,8 +247,10 @@ static unsigned long *sunxi_pctrl_build_pin_config(struct device_node *node,
if (sunxi_pctrl_has_bias_prop(node)) {
int pull = sunxi_pctrl_parse_bias_prop(node);
- if (pull < 0)
+ if (pull < 0) {
+ ret = pull;
goto err_free;
+ }
pinconfig[idx++] = pinconf_to_config_packed(pull, 0);
}
@@ -250,7 +261,7 @@ static unsigned long *sunxi_pctrl_build_pin_config(struct device_node *node,
err_free:
kfree(pinconfig);
- return NULL;
+ return ERR_PTR(ret);
}
static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
@@ -284,7 +295,10 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
/*
* We have two maps for each pin: one for the function, one
- * for the configuration (bias, strength, etc)
+ * for the configuration (bias, strength, etc).
+ *
+ * We might be slightly overshooting, since we might not have
+ * any configuration.
*/
nmaps = npins * 2;
*map = kmalloc(nmaps * sizeof(struct pinctrl_map), GFP_KERNEL);
@@ -292,8 +306,8 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
return -ENOMEM;
pinconfig = sunxi_pctrl_build_pin_config(node, &configlen);
- if (!pinconfig) {
- ret = -EINVAL;
+ if (IS_ERR(pinconfig)) {
+ ret = PTR_ERR(pinconfig);
goto err_free_map;
}
@@ -320,15 +334,24 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
i++;
- (*map)[i].type = PIN_MAP_TYPE_CONFIGS_GROUP;
- (*map)[i].data.configs.group_or_pin = group;
- (*map)[i].data.configs.configs = pinconfig;
- (*map)[i].data.configs.num_configs = configlen;
-
- i++;
+ if (pinconfig) {
+ (*map)[i].type = PIN_MAP_TYPE_CONFIGS_GROUP;
+ (*map)[i].data.configs.group_or_pin = group;
+ (*map)[i].data.configs.configs = pinconfig;
+ (*map)[i].data.configs.num_configs = configlen;
+ i++;
+ }
}
- *num_maps = nmaps;
+ *num_maps = i;
+
+ /*
+ * We know have the number of maps we need, we can resize our
+ * map array
+ */
+ *map = krealloc(*map, i * sizeof(struct pinctrl_map), GFP_KERNEL);
+ if (!map)
+ return -ENOMEM;
return 0;
--
git-series 0.8.10
[toc] | [prev] | [next] | [standalone]
| From | Jean-Francois Moine <moinejf@free.fr> |
|---|---|
| Date | 2016-10-20 17:40 +0200 |
| Subject | Re: [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner,pull property |
| Message-ID | <sunBL-ZF-11@gated-at.bofh.it> |
| In reply to | #1504911 |
On Thu, 20 Oct 2016 15:49:06 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > The allwinner,pull property set to NO_PULL was really considered our > default (and wasn't even changing the default value in the code). > > Remove these properties to make it obvious that we do not set anything in > such a case. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Acked-by: Chen-Yu Tsai <wens@csie.org> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > --- > arch/arm/boot/dts/ntc-gr8-evb.dts | 4 +- > arch/arm/boot/dts/ntc-gr8.dtsi | 14 +----- > arch/arm/boot/dts/sun4i-a10-a1000.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts | 4 +- > arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-hackberry.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-inet1.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-jesurun-q5.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-marsboard.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-mk802.dts | 3 +- > arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-pcduino.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-pcduino2.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 3 +- > arch/arm/boot/dts/sun4i-a10.dtsi | 24 +-------- > arch/arm/boot/dts/sun5i-a10s-auxtek-t003.dts | 1 +- > arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-mk802.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-r7-tv-dongle.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-wobo-i5.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s.dtsi | 7 +-- > arch/arm/boot/dts/sun5i-a13-hsg-h702.dts | 1 +- > arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 3 +- > arch/arm/boot/dts/sun5i-a13-olinuxino.dts | 2 +- > arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 1 +- > arch/arm/boot/dts/sun5i-a13.dtsi | 3 +- > arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +- > arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi | 2 +- > arch/arm/boot/dts/sun5i.dtsi | 7 +-- > arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 1 +- > arch/arm/boot/dts/sun6i-a31-colombus.dts | 1 +- > arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-i7.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-m9.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 2 +- > arch/arm/boot/dts/sun6i-a31.dtsi | 13 +---- > arch/arm/boot/dts/sun6i-a31s-primo81.dts | 1 +- > arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 1 +- > arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-bananapro.dts | 5 +-- > arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 +-- > arch/arm/boot/dts/sun7i-a20-hummingbird.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-m3.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-mk808c.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-orangepi-mini.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-orangepi.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts | 1 +- > arch/arm/boot/dts/sun7i-a20.dtsi | 37 +------------ > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 10 +--- > arch/arm/boot/dts/sun8i-a23-polaroid-mid2407pxe03.dts | 1 +- > arch/arm/boot/dts/sun8i-a23-polaroid-mid2809pxe04.dts | 1 +- > arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 1 +- > arch/arm/boot/dts/sun8i-a33-olinuxino.dts | 3 +- > arch/arm/boot/dts/sun8i-a33.dtsi | 1 +- > arch/arm/boot/dts/sun8i-a83t.dtsi | 3 +- > arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 2 +- > arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 4 +- > arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 1 +- > arch/arm/boot/dts/sun8i-h3.dtsi | 12 +---- > arch/arm/boot/dts/sun8i-r16-parrot.dts | 3 +- > arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 2 +- > arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 1 +- > arch/arm/boot/dts/sun9i-a80-optimus.dts | 4 +- > arch/arm/boot/dts/sun9i-a80.dtsi | 6 +-- > arch/arm/boot/dts/sunxi-common-regulators.dtsi | 4 +- > 85 files changed, 0 insertions(+), 302 deletions(-) [snip] Is it really usefull to change all these files while in a previous patch you were writing: > The generic pin configuration and multiplexing should be preferred now, > even though we still support the old one. ? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-10-21 12:50 +0200 |
| Subject | Re: [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner,pull property |
| Message-ID | <suFyF-4mN-9@gated-at.bofh.it> |
| In reply to | #1505041 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Thu, Oct 20, 2016 at 05:38:48PM +0200, Jean-Francois Moine wrote: > On Thu, 20 Oct 2016 15:49:06 +0200 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > The allwinner,pull property set to NO_PULL was really considered our > > default (and wasn't even changing the default value in the code). > > > > Remove these properties to make it obvious that we do not set anything in > > such a case. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Acked-by: Chen-Yu Tsai <wens@csie.org> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > --- > > arch/arm/boot/dts/ntc-gr8-evb.dts | 4 +- > > arch/arm/boot/dts/ntc-gr8.dtsi | 14 +----- > > arch/arm/boot/dts/sun4i-a10-a1000.dts | 2 +- > > arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 1 +- > > arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts | 4 +- > > arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 1 +- > > arch/arm/boot/dts/sun4i-a10-hackberry.dts | 2 +- > > arch/arm/boot/dts/sun4i-a10-inet1.dts | 2 +- > > arch/arm/boot/dts/sun4i-a10-jesurun-q5.dts | 2 +- > > arch/arm/boot/dts/sun4i-a10-marsboard.dts | 1 +- > > arch/arm/boot/dts/sun4i-a10-mk802.dts | 3 +- > > arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 2 +- > > arch/arm/boot/dts/sun4i-a10-pcduino.dts | 2 +- > > arch/arm/boot/dts/sun4i-a10-pcduino2.dts | 1 +- > > arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 3 +- > > arch/arm/boot/dts/sun4i-a10.dtsi | 24 +-------- > > arch/arm/boot/dts/sun5i-a10s-auxtek-t003.dts | 1 +- > > arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts | 2 +- > > arch/arm/boot/dts/sun5i-a10s-mk802.dts | 2 +- > > arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 2 +- > > arch/arm/boot/dts/sun5i-a10s-r7-tv-dongle.dts | 2 +- > > arch/arm/boot/dts/sun5i-a10s-wobo-i5.dts | 2 +- > > arch/arm/boot/dts/sun5i-a10s.dtsi | 7 +-- > > arch/arm/boot/dts/sun5i-a13-hsg-h702.dts | 1 +- > > arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 3 +- > > arch/arm/boot/dts/sun5i-a13-olinuxino.dts | 2 +- > > arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 1 +- > > arch/arm/boot/dts/sun5i-a13.dtsi | 3 +- > > arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +- > > arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi | 2 +- > > arch/arm/boot/dts/sun5i.dtsi | 7 +-- > > arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 1 +- > > arch/arm/boot/dts/sun6i-a31-colombus.dts | 1 +- > > arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 2 +- > > arch/arm/boot/dts/sun6i-a31-i7.dts | 2 +- > > arch/arm/boot/dts/sun6i-a31-m9.dts | 2 +- > > arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 2 +- > > arch/arm/boot/dts/sun6i-a31.dtsi | 13 +---- > > arch/arm/boot/dts/sun6i-a31s-primo81.dts | 1 +- > > arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 1 +- > > arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts | 3 +- > > arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 3 +- > > arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +- > > arch/arm/boot/dts/sun7i-a20-bananapro.dts | 5 +-- > > arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 1 +- > > arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 +-- > > arch/arm/boot/dts/sun7i-a20-hummingbird.dts | 4 +- > > arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts | 4 +- > > arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 1 +- > > arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 2 +- > > arch/arm/boot/dts/sun7i-a20-m3.dts | 1 +- > > arch/arm/boot/dts/sun7i-a20-mk808c.dts | 2 +- > > arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 4 +- > > arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 2 +- > > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts | 1 +- > > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 3 +- > > arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 1 +- > > arch/arm/boot/dts/sun7i-a20-orangepi-mini.dts | 4 +- > > arch/arm/boot/dts/sun7i-a20-orangepi.dts | 4 +- > > arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 3 +- > > arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 2 +- > > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 3 +- > > arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts | 1 +- > > arch/arm/boot/dts/sun7i-a20.dtsi | 37 +------------ > > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 10 +--- > > arch/arm/boot/dts/sun8i-a23-polaroid-mid2407pxe03.dts | 1 +- > > arch/arm/boot/dts/sun8i-a23-polaroid-mid2809pxe04.dts | 1 +- > > arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 1 +- > > arch/arm/boot/dts/sun8i-a33-olinuxino.dts | 3 +- > > arch/arm/boot/dts/sun8i-a33.dtsi | 1 +- > > arch/arm/boot/dts/sun8i-a83t.dtsi | 3 +- > > arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 3 +- > > arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 2 +- > > arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 4 +- > > arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 3 +- > > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 3 +- > > arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 3 +- > > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 1 +- > > arch/arm/boot/dts/sun8i-h3.dtsi | 12 +---- > > arch/arm/boot/dts/sun8i-r16-parrot.dts | 3 +- > > arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 2 +- > > arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 1 +- > > arch/arm/boot/dts/sun9i-a80-optimus.dts | 4 +- > > arch/arm/boot/dts/sun9i-a80.dtsi | 6 +-- > > arch/arm/boot/dts/sunxi-common-regulators.dtsi | 4 +- > > 85 files changed, 0 insertions(+), 302 deletions(-) > [snip] > > Is it really usefull to change all these files while in a previous > patch you were writing: > > The generic pin configuration and multiplexing should be preferred now, > > even though we still support the old one. > ? I assume you wanted to comment on the sixth patch. Yes, it's useful, because that way we avoid using a deprecated binding, that we would have to mix the newer binding which would be completely inconsistent, and that way we use the generic binding that everyone uses everywhere. The backward compatibility is just here to avoid breaking the ABI. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web