Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1504944 > unrolled thread

Re: [PATCH v4 2/9] clk: sunxi-ng: Remove the use of rational computations

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 2/9] clk: sunxi-ng: Remove the use of rational computations Chen-Yu Tsai <wens@csie.org> - 2016-10-20 16:40 +0200
    Re: [PATCH v4 2/9] clk: sunxi-ng: Remove the use of rational  computations Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-20 19:30 +0200

#1504944 — Re: [PATCH v4 2/9] clk: sunxi-ng: Remove the use of rational computations

On Tue, Oct 11, 2016 at 10:28 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> While the rational library works great, it doesn't really allow us to add
> more constraints, like the minimum.
>
> Remove that in order to be able to deal with the constraints we'll need.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  drivers/clk/sunxi-ng/Kconfig    |  3 +--
>  drivers/clk/sunxi-ng/ccu_nkm.c  | 31 +++++++++-----------
>  drivers/clk/sunxi-ng/ccu_nkmp.c | 45 +++++++++++++---------------
>  drivers/clk/sunxi-ng/ccu_nm.c   | 54 +++++++++++++++++++++++++---------
>  4 files changed, 78 insertions(+), 55 deletions(-)
>

[...]

> diff --git a/drivers/clk/sunxi-ng/ccu_nkmp.c b/drivers/clk/sunxi-ng/ccu_nkmp.c
> index 9769dee99511..4b457d8cce11 100644
> --- a/drivers/clk/sunxi-ng/ccu_nkmp.c
> +++ b/drivers/clk/sunxi-ng/ccu_nkmp.c
> @@ -9,16 +9,15 @@
>   */
>
>  #include <linux/clk-provider.h>
> -#include <linux/rational.h>
>
>  #include "ccu_gate.h"
>  #include "ccu_nkmp.h"
>
>  struct _ccu_nkmp {
> -       unsigned long   n, max_n;
> -       unsigned long   k, max_k;
> -       unsigned long   m, max_m;
> -       unsigned long   p, max_p;
> +       unsigned long   n, min_n, max_n;
> +       unsigned long   k, min_k, max_k;
> +       unsigned long   m, min_m, max_m;
> +       unsigned long   p, min_p, max_p;

Wrong patch? Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>

[toc] | [next] | [standalone]

#1505114 — Re: [PATCH v4 2/9] clk: sunxi-ng: Remove the use of rational computations

[Multipart message — attachments visible in raw view] — view raw

On Thu, Oct 20, 2016 at 10:30:36PM +0800, Chen-Yu Tsai wrote:
> On Tue, Oct 11, 2016 at 10:28 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > While the rational library works great, it doesn't really allow us to add
> > more constraints, like the minimum.
> >
> > Remove that in order to be able to deal with the constraints we'll need.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  drivers/clk/sunxi-ng/Kconfig    |  3 +--
> >  drivers/clk/sunxi-ng/ccu_nkm.c  | 31 +++++++++-----------
> >  drivers/clk/sunxi-ng/ccu_nkmp.c | 45 +++++++++++++---------------
> >  drivers/clk/sunxi-ng/ccu_nm.c   | 54 +++++++++++++++++++++++++---------
> >  4 files changed, 78 insertions(+), 55 deletions(-)
> >
> 
> [...]
> 
> > diff --git a/drivers/clk/sunxi-ng/ccu_nkmp.c b/drivers/clk/sunxi-ng/ccu_nkmp.c
> > index 9769dee99511..4b457d8cce11 100644
> > --- a/drivers/clk/sunxi-ng/ccu_nkmp.c
> > +++ b/drivers/clk/sunxi-ng/ccu_nkmp.c
> > @@ -9,16 +9,15 @@
> >   */
> >
> >  #include <linux/clk-provider.h>
> > -#include <linux/rational.h>
> >
> >  #include "ccu_gate.h"
> >  #include "ccu_nkmp.h"
> >
> >  struct _ccu_nkmp {
> > -       unsigned long   n, max_n;
> > -       unsigned long   k, max_k;
> > -       unsigned long   m, max_m;
> > -       unsigned long   p, max_p;
> > +       unsigned long   n, min_n, max_n;
> > +       unsigned long   k, min_k, max_k;
> > +       unsigned long   m, min_m, max_m;
> > +       unsigned long   p, min_p, max_p;
> 
> Wrong patch? Otherwise,
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>

Indeed, fixed and applied.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web