Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1504836 > unrolled thread
| Started by | Suganath Prabu S <suganath-prabu.subramani@broadcom.com> |
|---|---|
| First post | 2016-10-20 14:30 +0200 |
| Last post | 2016-10-25 16:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device. Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2016-10-20 14:30 +0200
Re: [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device. Hannes Reinecke <hare@suse.de> - 2016-10-24 16:50 +0200
Re: [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device. Tomas Henzl <thenzl@redhat.com> - 2016-10-25 16:40 +0200
| From | Suganath Prabu S <suganath-prabu.subramani@broadcom.com> |
|---|---|
| Date | 2016-10-20 14:30 +0200 |
| Subject | [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device. |
| Message-ID | <sukDU-7vO-31@gated-at.bofh.it> |
Return value and Device_handle Arguments passed in correct order to match with its format string. Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com> Signed-off-by: Sathya Prakash <sathya.prakash@broadcom.com> Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com> --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 209a969..282ca40 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -2837,7 +2837,7 @@ _scsih_internal_device_block(struct scsi_device *sdev, if (r == -EINVAL) sdev_printk(KERN_WARNING, sdev, "device_block failed with return(%d) for handle(0x%04x)\n", - sas_device_priv_data->sas_target->handle, r); + r, sas_device_priv_data->sas_target->handle); } /** @@ -2867,20 +2867,20 @@ _scsih_internal_device_unblock(struct scsi_device *sdev, sdev_printk(KERN_WARNING, sdev, "device_unblock failed with return(%d) for handle(0x%04x) " "performing a block followed by an unblock\n", - sas_device_priv_data->sas_target->handle, r); + r, sas_device_priv_data->sas_target->handle); sas_device_priv_data->block = 1; r = scsi_internal_device_block(sdev); if (r) sdev_printk(KERN_WARNING, sdev, "retried device_block " "failed with return(%d) for handle(0x%04x)\n", - sas_device_priv_data->sas_target->handle, r); + r, sas_device_priv_data->sas_target->handle); sas_device_priv_data->block = 0; r = scsi_internal_device_unblock(sdev, SDEV_RUNNING); if (r) sdev_printk(KERN_WARNING, sdev, "retried device_unblock" " failed with return(%d) for handle(0x%04x)\n", - sas_device_priv_data->sas_target->handle, r); + r, sas_device_priv_data->sas_target->handle); } } -- 1.8.3.1
[toc] | [next] | [standalone]
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Date | 2016-10-24 16:50 +0200 |
| Subject | Re: [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device. |
| Message-ID | <svOJA-qi-45@gated-at.bofh.it> |
| In reply to | #1504836 |
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: > Return value and Device_handle Arguments passed in correct order > to match with its format string. > > Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com> > Signed-off-by: Sathya Prakash <sathya.prakash@broadcom.com> > Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com> > --- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index 209a969..282ca40 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -2837,7 +2837,7 @@ _scsih_internal_device_block(struct scsi_device *sdev, > if (r == -EINVAL) > sdev_printk(KERN_WARNING, sdev, > "device_block failed with return(%d) for handle(0x%04x)\n", > - sas_device_priv_data->sas_target->handle, r); > + r, sas_device_priv_data->sas_target->handle); > } > > /** > @@ -2867,20 +2867,20 @@ _scsih_internal_device_unblock(struct scsi_device *sdev, > sdev_printk(KERN_WARNING, sdev, > "device_unblock failed with return(%d) for handle(0x%04x) " > "performing a block followed by an unblock\n", > - sas_device_priv_data->sas_target->handle, r); > + r, sas_device_priv_data->sas_target->handle); > sas_device_priv_data->block = 1; > r = scsi_internal_device_block(sdev); > if (r) > sdev_printk(KERN_WARNING, sdev, "retried device_block " > "failed with return(%d) for handle(0x%04x)\n", > - sas_device_priv_data->sas_target->handle, r); > + r, sas_device_priv_data->sas_target->handle); > > sas_device_priv_data->block = 0; > r = scsi_internal_device_unblock(sdev, SDEV_RUNNING); > if (r) > sdev_printk(KERN_WARNING, sdev, "retried device_unblock" > " failed with return(%d) for handle(0x%04x)\n", > - sas_device_priv_data->sas_target->handle, r); > + r, sas_device_priv_data->sas_target->handle); > } > } > > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [next] | [standalone]
| From | Tomas Henzl <thenzl@redhat.com> |
|---|---|
| Date | 2016-10-25 16:40 +0200 |
| Subject | Re: [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device. |
| Message-ID | <swb3s-6RL-1@gated-at.bofh.it> |
| In reply to | #1504836 |
On 20.10.2016 14:20, Suganath Prabu S wrote: > Return value and Device_handle Arguments passed in correct order > to match with its format string. > > Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com> > Signed-off-by: Sathya Prakash <sathya.prakash@broadcom.com> > Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com> > --- Reviewed-by: Tomas Henzl <thenzl@redhat.com> Tomas
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web