Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1504239 > unrolled thread

[PATCH 4.7 0/2] 4.7.9-stable review

Back to article view | Back to linux.kernel

Contents

  [PATCH 4.7 0/2] 4.7.9-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-19 20:40 +0200
    [PATCH 4.7 1/2] Make __xfs_xattr_put_listen preperly report errors. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-19 20:40 +0200
    Re: [PATCH 4.7 0/2] 4.7.9-stable review Shuah Khan <shuah.kh@samsung.com> - 2016-10-20 00:30 +0200
    Re: [PATCH 4.7 0/2] 4.7.9-stable review Guenter Roeck <linux@roeck-us.net> - 2016-10-20 03:50 +0200

#1504239 — [PATCH 4.7 0/2] 4.7.9-stable review

This is the start of the stable review cycle for the 4.7.9 release.
There are 2 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Fri Oct 21 18:28:47 UTC 2016.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.7.9-rc1.gz
or in the git tree and branch at:
  git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.7.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 4.7.9-rc1

Linus Torvalds <torvalds@linux-foundation.org>
    mm: remove gup_flags FOLL_WRITE games from __get_user_pages()

Artem Savkov <asavkov@redhat.com>
    Make __xfs_xattr_put_listen preperly report errors.


-------------

Diffstat:

 Makefile           |  4 ++--
 fs/xfs/xfs_xattr.c |  1 +
 include/linux/mm.h |  1 +
 mm/gup.c           | 14 ++++++++++++--
 4 files changed, 16 insertions(+), 4 deletions(-)

[toc] | [next] | [standalone]

#1504243 — [PATCH 4.7 1/2] Make __xfs_xattr_put_listen preperly report errors.

4.7-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Artem Savkov <asavkov@redhat.com>

commit 791cc43b36eb1f88166c8505900cad1b43c7fe1a upstream.

Commit 2a6fba6 "xfs: only return -errno or success from attr ->put_listent"
changes the returnvalue of __xfs_xattr_put_listen to 0 in case when there is
insufficient space in the buffer assuming that setting context->count to -1
would be enough, but all of the ->put_listent callers only check seen_enough.
This results in a failed assertion:
XFS: Assertion failed: context->count >= 0, file: fs/xfs/xfs_xattr.c, line: 175
in insufficient buffer size case.

This is only reproducible with at least 2 xattrs and only when the buffer
gets depleted before the last one.

Furthermore if buffersize is such that it is enough to hold the last xattr's
name, but not enough to hold the sum of preceeding xattr names listxattr won't
fail with ERANGE, but will suceed returning last xattr's name without the
first character. The first character end's up overwriting data stored at
(context->alist - 1).

Signed-off-by: Artem Savkov <asavkov@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/xfs/xfs_xattr.c |    1 +
 1 file changed, 1 insertion(+)

--- a/fs/xfs/xfs_xattr.c
+++ b/fs/xfs/xfs_xattr.c
@@ -147,6 +147,7 @@ __xfs_xattr_put_listent(
 	arraytop = context->count + prefix_len + namelen + 1;
 	if (arraytop > context->firstu) {
 		context->count = -1;	/* insufficient space */
+		context->seen_enough = 1;
 		return 0;
 	}
 	offset = (char *)context->alist + context->count;

[toc] | [prev] | [next] | [standalone]

#1504367

On 10/19/2016 12:31 PM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.7.9 release.
> There are 2 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Fri Oct 21 18:28:47 UTC 2016.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.7.9-rc1.gz
> or in the git tree and branch at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.7.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 

Compiled and booted on my test system. No dmesg regressions.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com

[toc] | [prev] | [next] | [standalone]

#1504454

On 10/19/2016 11:31 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.7.9 release.
> There are 2 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri Oct 21 18:28:47 UTC 2016.
> Anything received after that time might be too late.
>

Build results:
	total: 149 pass: 149 fail: 0
Qemu test results:
	total: 110 pass: 110 fail: 0

Details are available at http://kerneltests.org/builders.

Guenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web