Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506147 > unrolled thread

[RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

Started byBjorn Andersson <bjorn.andersson@linaro.org>
First post2016-10-21 19:00 +0200
Last post2016-10-22 08:30 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-10-21 19:00 +0200
    Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops  from DT Stephen Boyd <sboyd@codeaurora.org> - 2016-10-21 19:40 +0200
      Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops  from DT Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-10-21 20:00 +0200
      RE: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops  from DT Sriram Dash <sriram.dash@nxp.com> - 2016-10-22 08:30 +0200

#1506147 — [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

FromBjorn Andersson <bjorn.andersson@linaro.org>
Date2016-10-21 19:00 +0200
Subject[RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT
Message-ID<suLkK-8jc-43@gated-at.bofh.it>
hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent
memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated manually
it will not have any dma_mem or dma_ops assigned, which makes the
dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch solves
this by assigning the dma_mem and dma_ops based on the parent's DeviceTree
node.

Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---

Hi Peter,

After (once more) debugging why USB doesn't work up on the 64-bit Qualcomm
systems I realized that we never concluded on this patch. Unfortunately I can't
find it in my mailbox either, so resending it to restart the discussion.

Regards,
Bjorn

 drivers/usb/chipidea/core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 69426e644d17..6218d83cca25 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -62,6 +62,7 @@
 #include <linux/usb/chipidea.h>
 #include <linux/usb/of.h>
 #include <linux/of.h>
+#include <linux/of_device.h>
 #include <linux/phy.h>
 #include <linux/regulator/consumer.h>
 #include <linux/usb/ehci_def.h>
@@ -837,6 +838,9 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
 	pdev->dev.dma_parms = dev->dma_parms;
 	dma_set_coherent_mask(&pdev->dev, dev->coherent_dma_mask);
 
+	if (IS_ENABLED(CONFIG_OF) && dev->of_node)
+		of_dma_configure(&pdev->dev, dev->of_node);
+
 	ret = platform_device_add_resources(pdev, res, nres);
 	if (ret)
 		goto err;
-- 
2.5.0

[toc] | [next] | [standalone]

#1506180 — Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

FromStephen Boyd <sboyd@codeaurora.org>
Date2016-10-21 19:40 +0200
SubjectRe: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT
Message-ID<suLXt-kW-49@gated-at.bofh.it>
In reply to#1506147
On 10/21, Bjorn Andersson wrote:
> hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent
> memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated manually
> it will not have any dma_mem or dma_ops assigned, which makes the
> dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch solves
> this by assigning the dma_mem and dma_ops based on the parent's DeviceTree
> node.
> 
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> 
> Hi Peter,
> 
> After (once more) debugging why USB doesn't work up on the 64-bit Qualcomm
> systems I realized that we never concluded on this patch. Unfortunately I can't
> find it in my mailbox either, so resending it to restart the discussion.
> 

I thought we were going to go down the route that Arnd has been
pushing[1]? That should work, but I haven't tried it yet and
there are some more fixes on top from Sriram. I think Sriram is
taking over the patch now?

[1] https://patchwork.kernel.org/patch/9319527/

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1506192 — Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

FromBjorn Andersson <bjorn.andersson@linaro.org>
Date2016-10-21 20:00 +0200
SubjectRe: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT
Message-ID<suMgT-so-11@gated-at.bofh.it>
In reply to#1506180
On Fri 21 Oct 10:38 PDT 2016, Stephen Boyd wrote:

> On 10/21, Bjorn Andersson wrote:
> > hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent
> > memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated manually
> > it will not have any dma_mem or dma_ops assigned, which makes the
> > dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch solves
> > this by assigning the dma_mem and dma_ops based on the parent's DeviceTree
> > node.
> > 
> > Cc: Stephen Boyd <sboyd@codeaurora.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > 
> > Hi Peter,
> > 
> > After (once more) debugging why USB doesn't work up on the 64-bit Qualcomm
> > systems I realized that we never concluded on this patch. Unfortunately I can't
> > find it in my mailbox either, so resending it to restart the discussion.
> > 
> 
> I thought we were going to go down the route that Arnd has been
> pushing[1]? That should work, but I haven't tried it yet and
> there are some more fixes on top from Sriram. I think Sriram is
> taking over the patch now?
> 
> [1] https://patchwork.kernel.org/patch/9319527/

Thanks for the pointer, I've heard about it but couldn't find it.

It does make me further wonder about the multi-device model of these
drivers, but I agree with you that it looks like the patch would
solve our issue.

Regards,
Bjorn

[toc] | [prev] | [next] | [standalone]

#1506387 — RE: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

FromSriram Dash <sriram.dash@nxp.com>
Date2016-10-22 08:30 +0200
SubjectRE: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT
Message-ID<suXYB-8ei-1@gated-at.bofh.it>
In reply to#1506180
>From: Stephen Boyd [mailto:sboyd@codeaurora.org]
>On 10/21, Bjorn Andersson wrote:
>> hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating
>> coherent memory on behalf of ci_hdrc driver. But as the ci_hdrc is
>> instantiated manually it will not have any dma_mem or dma_ops
>> assigned, which makes the
>> dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch
>> solves this by assigning the dma_mem and dma_ops based on the parent's
>> DeviceTree node.
>>
>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>>
>> Hi Peter,
>>
>> After (once more) debugging why USB doesn't work up on the 64-bit
>> Qualcomm systems I realized that we never concluded on this patch.
>> Unfortunately I can't find it in my mailbox either, so resending it to restart the
>discussion.
>>
>
>I thought we were going to go down the route that Arnd has been pushing[1]? That
>should work, but I haven't tried it yet and there are some more fixes on top from
>Sriram. I think Sriram is taking over the patch now?
>

Yes Stephen. I am incorporating the idea from Arnd and working on those patches.

Regards,
Sriram

>[1] https://patchwork.kernel.org/patch/9319527/
>
>--
>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
>Foundation Collaborative Project

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web