Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501231 > unrolled thread
| Started by | Hoan Tran <hotran@apm.com> |
|---|---|
| First post | 2016-10-15 01:30 +0200 |
| Last post | 2016-10-21 23:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mailbox: PCC: Fix return value of pcc_mbox_request_channel() Hoan Tran <hotran@apm.com> - 2016-10-15 01:30 +0200
Re: [PATCH] mailbox: PCC: Fix return value of pcc_mbox_request_channel() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-10-21 23:30 +0200
| From | Hoan Tran <hotran@apm.com> |
|---|---|
| Date | 2016-10-15 01:30 +0200 |
| Subject | [PATCH] mailbox: PCC: Fix return value of pcc_mbox_request_channel() |
| Message-ID | <ssk5j-82w-3@gated-at.bofh.it> |
When CONFIG_PCC is disabled, pcc_mbox_request_channel() needs to
return ERR_PTR(-ENODEV), not a NULL pointer, as the callers of
this function use IS_ERR() to check for error code.
Signed-off-by: Duc Dang <dhdang@apm.com>
Signed-off-by: Hoan Tran <hotran@apm.com>
---
include/acpi/pcc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
index 17a940a..8caa79c 100644
--- a/include/acpi/pcc.h
+++ b/include/acpi/pcc.h
@@ -21,7 +21,7 @@ extern struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
static inline struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
int subspace_id)
{
- return NULL;
+ return ERR_PTR(-ENODEV);
}
static inline void pcc_mbox_free_channel(struct mbox_chan *chan) { }
#endif
--
1.9.1
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-10-21 23:30 +0200 |
| Message-ID | <suPy2-2Jv-23@gated-at.bofh.it> |
| In reply to | #1501231 |
On Friday, October 14, 2016 04:20:21 PM Hoan Tran wrote:
> When CONFIG_PCC is disabled, pcc_mbox_request_channel() needs to
> return ERR_PTR(-ENODEV), not a NULL pointer, as the callers of
> this function use IS_ERR() to check for error code.
>
> Signed-off-by: Duc Dang <dhdang@apm.com>
> Signed-off-by: Hoan Tran <hotran@apm.com>
> ---
> include/acpi/pcc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
> index 17a940a..8caa79c 100644
> --- a/include/acpi/pcc.h
> +++ b/include/acpi/pcc.h
> @@ -21,7 +21,7 @@ extern struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
> static inline struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
> int subspace_id)
> {
> - return NULL;
> + return ERR_PTR(-ENODEV);
> }
> static inline void pcc_mbox_free_channel(struct mbox_chan *chan) { }
> #endif
>
Applied.
Thanks,
Rafael
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web