Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506314 > unrolled thread

[RFC v2 0/2] Ignore capability registers when it comes to speeds and use DT binding instead.

Started byZach Brown <zach.brown@ni.com>
First post2016-10-21 23:40 +0200
Last post2016-10-21 23:40 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [RFC v2 0/2] Ignore capability registers when it comes to speeds and use DT binding instead. Zach Brown <zach.brown@ni.com> - 2016-10-21 23:40 +0200
    [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set. Zach Brown <zach.brown@ni.com> - 2016-10-21 23:40 +0200
      Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes  to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is  set. Adrian Hunter <adrian.hunter@intel.com> - 2016-10-24 09:40 +0200
        Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes  to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is  set. Adrian Hunter <adrian.hunter@intel.com> - 2016-10-25 13:40 +0200
    [RFC v2 1/2] mmc: sdhci: Add device tree property sdhci-cap-speed-modes-broken Zach Brown <zach.brown@ni.com> - 2016-10-21 23:40 +0200

#1506314 — [RFC v2 0/2] Ignore capability registers when it comes to speeds and use DT binding instead.

FromZach Brown <zach.brown@ni.com>
Date2016-10-21 23:40 +0200
Subject[RFC v2 0/2] Ignore capability registers when it comes to speeds and use DT binding instead.
Message-ID<suPHH-2MQ-9@gated-at.bofh.it>
The first patch add documentation about a new devicetree property
sdhci-cap-speed-modes-broken.

The second patch makes the sdhci use the DT binding instead of the caps
register for determining which speed modes are supported by the controller.

This RFC is an alternative to another patch[1] set I sent up.

[1]
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1251944.html

v2:
 * Removed separate OF parsing function, relying on mmc_of_parse to be called
   before read_caps
 * Moved check of sdhci-cap-speed-modes-broken into sdhci_read_caps.
 * Added SDHCI_SUPPORT_HS400 to list of bits to clear in sdhci cap1, not sure
   that's all of the them now, but I think so.

Zach Brown (2):
  mmc: sdhci: Add device tree property sdhci-cap-speed-modes-broken
  mmc: sdhci: Ignore capability register when it comes to speeds and use
    DT     binding instead when sdhci-cap-speed-modes-broken is set.

 Documentation/devicetree/bindings/mmc/mmc.txt |  3 +++
 drivers/mmc/host/sdhci.c                      | 10 ++++++++++
 2 files changed, 13 insertions(+)

--
2.7.4

[toc] | [next] | [standalone]

#1506317 — [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.

FromZach Brown <zach.brown@ni.com>
Date2016-10-21 23:40 +0200
Subject[RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.
Message-ID<suPHH-2MQ-15@gated-at.bofh.it>
In reply to#1506314
When the sdhci-cap-speed-modes-broken DT property is set, the driver
will ignore the bits of the capability registers that correspond to
speed modes.

Signed-off-by: Zach Brown <zach.brown@ni.com>
---
 drivers/mmc/host/sdhci.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1e25b01..59c62d3 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -22,6 +22,7 @@
 #include <linux/scatterlist.h>
 #include <linux/regulator/consumer.h>
 #include <linux/pm_runtime.h>
+#include <linux/of.h>
 
 #include <linux/leds.h>
 
@@ -3013,10 +3014,19 @@ void __sdhci_read_caps(struct sdhci_host *host, u16 *ver, u32 *caps, u32 *caps1)
 
 	host->caps = caps ? *caps : sdhci_readl(host, SDHCI_CAPABILITIES);
 
+	if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
+				  "sdhci-cap-speed-modes-broken"))
+		host->caps &= ~SDHCI_CAN_DO_HISPD;
+
 	if (host->version < SDHCI_SPEC_300)
 		return;
 
 	host->caps1 = caps1 ? *caps1 : sdhci_readl(host, SDHCI_CAPABILITIES_1);
+
+	if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
+				  "sdhci-cap-speed-modes-broken"))
+		host->caps1 &= ~(SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_SDR104 |
+				 SDHCI_SUPPORT_DDR50 | SDHCI_SUPPORT_HS400);
 }
 EXPORT_SYMBOL_GPL(__sdhci_read_caps);
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1506961 — Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.

FromAdrian Hunter <adrian.hunter@intel.com>
Date2016-10-24 09:40 +0200
SubjectRe: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.
Message-ID<svI1s-4up-11@gated-at.bofh.it>
In reply to#1506317
On 22/10/16 00:35, Zach Brown wrote:
> When the sdhci-cap-speed-modes-broken DT property is set, the driver
> will ignore the bits of the capability registers that correspond to
> speed modes.
> 
> Signed-off-by: Zach Brown <zach.brown@ni.com>
> ---
>  drivers/mmc/host/sdhci.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 1e25b01..59c62d3 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -22,6 +22,7 @@
>  #include <linux/scatterlist.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/of.h>
>  
>  #include <linux/leds.h>
>  
> @@ -3013,10 +3014,19 @@ void __sdhci_read_caps(struct sdhci_host *host, u16 *ver, u32 *caps, u32 *caps1)
>  
>  	host->caps = caps ? *caps : sdhci_readl(host, SDHCI_CAPABILITIES);
>  
> +	if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
> +				  "sdhci-cap-speed-modes-broken"))

It rather begs the question: if you are going to do something sdhci
specific, why not just read the whole of the caps register from DT?

> +		host->caps &= ~SDHCI_CAN_DO_HISPD;
> +
>  	if (host->version < SDHCI_SPEC_300)
>  		return;
>  
>  	host->caps1 = caps1 ? *caps1 : sdhci_readl(host, SDHCI_CAPABILITIES_1);
> +
> +	if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
> +				  "sdhci-cap-speed-modes-broken"))

Why read it twice?

> +		host->caps1 &= ~(SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_SDR104 |
> +				 SDHCI_SUPPORT_DDR50 | SDHCI_SUPPORT_HS400);
>  }
>  EXPORT_SYMBOL_GPL(__sdhci_read_caps);
>  
>

[toc] | [prev] | [next] | [standalone]

#1508220 — Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.

FromAdrian Hunter <adrian.hunter@intel.com>
Date2016-10-25 13:40 +0200
SubjectRe: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.
Message-ID<sw8ff-4ZX-7@gated-at.bofh.it>
In reply to#1506961
On 24/10/16 18:48, Zach Brown wrote:
> On Mon, Oct 24, 2016 at 10:34:46AM +0300, Adrian Hunter wrote:
>> On 22/10/16 00:35, Zach Brown wrote:
>>> When the sdhci-cap-speed-modes-broken DT property is set, the driver
>>> will ignore the bits of the capability registers that correspond to
>>> speed modes.
>>>
>>> Signed-off-by: Zach Brown <zach.brown@ni.com>
>>> ---
>>>  drivers/mmc/host/sdhci.c | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>>> index 1e25b01..59c62d3 100644
>>> --- a/drivers/mmc/host/sdhci.c
>>> +++ b/drivers/mmc/host/sdhci.c
>>> @@ -22,6 +22,7 @@
>>>  #include <linux/scatterlist.h>
>>>  #include <linux/regulator/consumer.h>
>>>  #include <linux/pm_runtime.h>
>>> +#include <linux/of.h>
>>>
>>>  #include <linux/leds.h>
>>>
>>> @@ -3013,10 +3014,19 @@ void __sdhci_read_caps(struct sdhci_host *host, u16 *ver, u32 *caps, u32 *caps1)
>>>
>>>  	host->caps = caps ? *caps : sdhci_readl(host, SDHCI_CAPABILITIES);
>>>
>>> +	if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
>>> +				  "sdhci-cap-speed-modes-broken"))
>>
>> It rather begs the question: if you are going to do something sdhci
>> specific, why not just read the whole of the caps register from DT?
>>
> 
> Throwing out the whole of the caps register seems like overkill. Also

What about 2 values: one for the 64-bit caps register and one for a 64-bit
mask of bits to override.  That way you can select which bits to override
and what to override them to.

> there are some things set by the caps that are not available in the DT.
> For example, SDHCI_CAN_64BIT is set by the cap register and is used in
> sdhci_setup_host to set host->flags SDHCI_USE_64_BIT_DMA.

Not sure what you mean.

[toc] | [prev] | [next] | [standalone]

#1506320 — [RFC v2 1/2] mmc: sdhci: Add device tree property sdhci-cap-speed-modes-broken

FromZach Brown <zach.brown@ni.com>
Date2016-10-21 23:40 +0200
Subject[RFC v2 1/2] mmc: sdhci: Add device tree property sdhci-cap-speed-modes-broken
Message-ID<suPHI-2MQ-31@gated-at.bofh.it>
In reply to#1506314
On some systems the sdhci capabilty registers are incorrect for one
reason or another.

The sdhci-cap-speed-modes-broken property will let the driver know that
the sdhci capability registers should not be relied on for speed modes.
Instead the driver should check the mmc generic DT bindings.

Signed-off-by: Zach Brown <zach.brown@ni.com>
---
 Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
index 8a37782..671d6c0 100644
--- a/Documentation/devicetree/bindings/mmc/mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/mmc.txt
@@ -52,6 +52,9 @@ Optional properties:
 - no-sdio: controller is limited to send sdio cmd during initialization
 - no-sd: controller is limited to send sd cmd during initialization
 - no-mmc: controller is limited to send mmc cmd during initialization
+- sdhci-cap-speed-modes-broken: One or more of the bits in the sdhci
+  capabilities registers representing speed modes are incorrect. All the bits
+  representing speed modes should be ignored.
 
 *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
 polarity properties, we have to fix the meaning of the "normal" and "inverted"
-- 
2.7.4

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web