Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501847 > unrolled thread
| Started by | Tobias Klauser <tklauser@distanz.ch> |
|---|---|
| First post | 2016-10-17 12:20 +0200 |
| Last post | 2016-10-25 05:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] padata: Remove unused but set variables Tobias Klauser <tklauser@distanz.ch> - 2016-10-17 12:20 +0200
Re: [PATCH] padata: Remove unused but set variables Steffen Klassert <steffen.klassert@secunet.com> - 2016-10-21 11:10 +0200
Re: [PATCH] padata: Remove unused but set variables Herbert Xu <herbert@gondor.apana.org.au> - 2016-10-25 05:40 +0200
| From | Tobias Klauser <tklauser@distanz.ch> |
|---|---|
| Date | 2016-10-17 12:20 +0200 |
| Subject | [PATCH] padata: Remove unused but set variables |
| Message-ID | <stdbr-2aY-13@gated-at.bofh.it> |
Remove the unused but set variable pinst in padata_parallel_worker to
fix the following warning when building with 'W=1':
kernel/padata.c: In function ‘padata_parallel_worker’:
kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable]
Also remove the now unused variable pd which is only used to set pinst.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
kernel/padata.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 7848f0566403..05316c9f32da 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -64,15 +64,11 @@ static int padata_cpu_hash(struct parallel_data *pd)
static void padata_parallel_worker(struct work_struct *parallel_work)
{
struct padata_parallel_queue *pqueue;
- struct parallel_data *pd;
- struct padata_instance *pinst;
LIST_HEAD(local_list);
local_bh_disable();
pqueue = container_of(parallel_work,
struct padata_parallel_queue, work);
- pd = pqueue->pd;
- pinst = pd->pinst;
spin_lock(&pqueue->parallel.lock);
list_replace_init(&pqueue->parallel.list, &local_list);
--
2.9.0
[toc] | [next] | [standalone]
| From | Steffen Klassert <steffen.klassert@secunet.com> |
|---|---|
| Date | 2016-10-21 11:10 +0200 |
| Message-ID | <suDZT-3tk-1@gated-at.bofh.it> |
| In reply to | #1501847 |
On Mon, Oct 17, 2016 at 12:16:08PM +0200, Tobias Klauser wrote: > Remove the unused but set variable pinst in padata_parallel_worker to > fix the following warning when building with 'W=1': > > kernel/padata.c: In function ‘padata_parallel_worker’: > kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable] > > Also remove the now unused variable pd which is only used to set pinst. > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Acked-by: Steffen Klassert <steffen.klassert@secunet.com> Thanks!
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-10-25 05:40 +0200 |
| Message-ID | <sw0KK-8uY-11@gated-at.bofh.it> |
| In reply to | #1505601 |
Steffen Klassert <steffen.klassert@secunet.com> wrote: > On Mon, Oct 17, 2016 at 12:16:08PM +0200, Tobias Klauser wrote: >> Remove the unused but set variable pinst in padata_parallel_worker to >> fix the following warning when building with 'W=1': >> >> kernel/padata.c: In function ‘padata_parallel_worker’: >> kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable] >> >> Also remove the now unused variable pd which is only used to set pinst. >> >> Signed-off-by: Tobias Klauser <tklauser@distanz.ch> > > Acked-by: Steffen Klassert <steffen.klassert@secunet.com> Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web