Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1503854 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-10-19 17:20 +0200 |
| Last post | 2016-10-19 17:20 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] dmaengine: omap-dma: initialize can_pause to false Colin King <colin.king@canonical.com> - 2016-10-19 17:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-10-19 17:20 +0200 |
| Subject | [PATCH] dmaengine: omap-dma: initialize can_pause to false |
| Message-ID | <su0ca-2v4-59@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com> can_pause is not initialized so it contains garbage. Fix this by setting it to false. Found using static analysis with cppcheck. Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/dma/omap-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c index fd6b9e6..15eb802 100644 --- a/drivers/dma/omap-dma.c +++ b/drivers/dma/omap-dma.c @@ -1286,7 +1286,7 @@ static int omap_dma_pause(struct dma_chan *chan) struct omap_dmadev *od = to_omap_dma_dev(chan->device); unsigned long flags; int ret = -EINVAL; - bool can_pause; + bool can_pause = false; spin_lock_irqsave(&od->irq_lock, flags); -- 2.9.3
Back to top | Article view | linux.kernel
csiph-web