Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503807 > unrolled thread

[PATCH 17/37] staging:r8188eu: update pkt->data synchronously with rx_data

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 17/37] staging:r8188eu: update pkt->data synchronously with rx_data Ivan Safonov <insafonov@gmail.com> - 2016-10-19 17:10 +0200
    Re: [PATCH 17/37] staging:r8188eu: update pkt->data synchronously  with rx_data Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-20 11:10 +0200
      Re: [PATCH 17/37] staging:r8188eu: update pkt->data synchronously  with rx_data Ivan Safonov <insafonov@gmail.com> - 2016-10-20 15:20 +0200

#1503807 — [PATCH 17/37] staging:r8188eu: update pkt->data synchronously with rx_data

To replace rx_data with pkt->data.
Now pkt->data is equal to rx_data.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
---
 drivers/staging/rtl8188eu/include/rtw_recv.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h
index e661635..143e637 100644
--- a/drivers/staging/rtl8188eu/include/rtw_recv.h
+++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
@@ -266,6 +266,7 @@ static inline u8 *recvframe_pull(struct recv_frame *precvframe, uint sz)
 
 	if (precvframe == NULL)
 		return NULL;
+	skb_pull(precvframe->pkt, sz);
 	precvframe->rx_data += sz;
 	if (precvframe->rx_data > precvframe->rx_tail) {
 		precvframe->rx_data -= sz;
-- 
2.7.3

[toc] | [next] | [standalone]

#1504679 — Re: [PATCH 17/37] staging:r8188eu: update pkt->data synchronously with rx_data

On Wed, Oct 19, 2016 at 10:07:45PM +0700, Ivan Safonov wrote:
> To replace rx_data with pkt->data.
> Now pkt->data is equal to rx_data.
> 

I'm not smart enough to tell on my own...  Is this a bugfix?

regards,
dan carpenter

[toc] | [prev] | [next] | [standalone]

#1504881 — Re: [PATCH 17/37] staging:r8188eu: update pkt->data synchronously with rx_data

On 10/20/2016 04:03 PM, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 10:07:45PM +0700, Ivan Safonov wrote:
>> To replace rx_data with pkt->data.
>> Now pkt->data is equal to rx_data.
>>
>
> I'm not smart enough to tell on my own...  Is this a bugfix?

It is not bugfix, only variable replacement.
recv_frame structure duplicates sk_buff. Most of the ieee80211_* 
functions require a pointer to sk_buff. Therefore, easier to use sk_buff 
instead of recv_frame structure.

>
> regards,
> dan carpenter
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web