Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1503659 > unrolled thread
| Started by | Brian Masney <masneyb@onstation.org> |
|---|---|
| First post | 2016-10-19 16:30 +0200 |
| Last post | 2016-10-22 19:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros Brian Masney <masneyb@onstation.org> - 2016-10-19 16:30 +0200
Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-19 16:30 +0200
Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros Jonathan Cameron <jic23@kernel.org> - 2016-10-22 19:30 +0200
| From | Brian Masney <masneyb@onstation.org> |
|---|---|
| Date | 2016-10-19 16:30 +0200 |
| Subject | Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros |
| Message-ID | <su02u-2rf-43@gated-at.bofh.it> |
On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote: > What does illuminance0_ mean? Can we remove that? I left the names of the existing sysfs attributes intact to not break any existing users of the driver. I'm not sure why the original author named it that way. Brian
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-10-19 16:30 +0200 |
| Message-ID | <su02w-2rf-127@gated-at.bofh.it> |
| In reply to | #1503659 |
On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote: > On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote: > > What does illuminance0_ mean? Can we remove that? > > I left the names of the existing sysfs attributes intact to not break > any existing users of the driver. I'm not sure why the original author > named it that way. Ah... Then I defer to your judgement. regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-10-22 19:30 +0200 |
| Message-ID | <sv8hj-6mb-1@gated-at.bofh.it> |
| In reply to | #1503689 |
On 19/10/16 14:11, Dan Carpenter wrote: > On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote: >> On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote: >>> What does illuminance0_ mean? Can we remove that? >> >> I left the names of the existing sysfs attributes intact to not break >> any existing users of the driver. I'm not sure why the original author >> named it that way. > > Ah... Then I defer to your judgement. Will normally be constructed as this via the info_mask stuff. Needed to ensure it's obvious which channel we are referring to in multichannel devices. Convention usually means we use this when something is very channel specific even if it's the only channel. (feels odd otherwise ;) Looks ugly here because of the rather contrived nature of the macros. I'm not keen on that side of them, but then we should hardly ever need to use them anyway so I'm not that bothered! Jonathan > > regards, > dan carpenter > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web