Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502799 > unrolled thread

[PATCH] drm/sun4i: Add a few formats

Started byMaxime Ripard <maxime.ripard@free-electrons.com>
First post2016-10-18 10:50 +0200
Last post2016-10-25 02:50 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm/sun4i: Add a few formats Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-18 10:50 +0200
    Re: [PATCH] drm/sun4i: Add a few formats Chen-Yu Tsai <wens@csie.org> - 2016-10-21 05:20 +0200
      Re: [PATCH] drm/sun4i: Add a few formats Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-24 21:30 +0200
        Re: [PATCH] drm/sun4i: Add a few formats Chen-Yu Tsai <wens@csie.org> - 2016-10-25 02:50 +0200

#1502799 — [PATCH] drm/sun4i: Add a few formats

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-10-18 10:50 +0200
Subject[PATCH] drm/sun4i: Add a few formats
Message-ID<styfT-7GN-5@gated-at.bofh.it>
The planes can do more than what was previously exposed. Add support for
them.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/gpu/drm/sun4i/sun4i_backend.c | 20 ++++++++++++++++++++
 drivers/gpu/drm/sun4i/sun4i_layer.c   |  6 ++++++
 2 files changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index afb7ddf660ef..b184a476a480 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -96,6 +96,22 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
 		*mode = SUN4I_BACKEND_LAY_FBFMT_ARGB8888;
 		break;
 
+	case DRM_FORMAT_ARGB4444:
+		*mode = SUN4I_BACKEND_LAY_FBFMT_ARGB4444;
+		break;
+
+	case DRM_FORMAT_ARGB1555:
+		*mode = SUN4I_BACKEND_LAY_FBFMT_ARGB1555;
+		break;
+
+	case DRM_FORMAT_RGBA5551:
+		*mode = SUN4I_BACKEND_LAY_FBFMT_RGBA5551;
+		break;
+
+	case DRM_FORMAT_RGBA4444:
+		*mode = SUN4I_BACKEND_LAY_FBFMT_RGBA4444;
+		break;
+
 	case DRM_FORMAT_XRGB8888:
 		*mode = SUN4I_BACKEND_LAY_FBFMT_XRGB8888;
 		break;
@@ -104,6 +120,10 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
 		*mode = SUN4I_BACKEND_LAY_FBFMT_RGB888;
 		break;
 
+	case DRM_FORMAT_RGB565:
+		*mode = SUN4I_BACKEND_LAY_FBFMT_RGB565;
+		break;
+
 	default:
 		return -EINVAL;
 	}
diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
index f0035bf5efea..5d53c977bca5 100644
--- a/drivers/gpu/drm/sun4i/sun4i_layer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
@@ -73,12 +73,18 @@ static const struct drm_plane_funcs sun4i_backend_layer_funcs = {
 static const uint32_t sun4i_backend_layer_formats_primary[] = {
 	DRM_FORMAT_ARGB8888,
 	DRM_FORMAT_RGB888,
+	DRM_FORMAT_RGB565,
 	DRM_FORMAT_XRGB8888,
 };
 
 static const uint32_t sun4i_backend_layer_formats_overlay[] = {
 	DRM_FORMAT_ARGB8888,
+	DRM_FORMAT_ARGB4444,
+	DRM_FORMAT_ARGB1555,
+	DRM_FORMAT_RGBA5551,
+	DRM_FORMAT_RGBA4444,
 	DRM_FORMAT_RGB888,
+	DRM_FORMAT_RGB565,
 	DRM_FORMAT_XRGB8888,
 };
 
-- 
2.9.3

[toc] | [next] | [standalone]

#1505441

FromChen-Yu Tsai <wens@csie.org>
Date2016-10-21 05:20 +0200
Message-ID<suyxb-8lc-17@gated-at.bofh.it>
In reply to#1502799
On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The planes can do more than what was previously exposed. Add support for
> them.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  drivers/gpu/drm/sun4i/sun4i_backend.c | 20 ++++++++++++++++++++
>  drivers/gpu/drm/sun4i/sun4i_layer.c   |  6 ++++++
>  2 files changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
> index afb7ddf660ef..b184a476a480 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_backend.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
> @@ -96,6 +96,22 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
>                 *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB8888;
>                 break;
>
> +       case DRM_FORMAT_ARGB4444:
> +               *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB4444;
> +               break;
> +
> +       case DRM_FORMAT_ARGB1555:
> +               *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB1555;
> +               break;
> +
> +       case DRM_FORMAT_RGBA5551:
> +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGBA5551;
> +               break;
> +
> +       case DRM_FORMAT_RGBA4444:
> +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGBA4444;

The A20 manual only lists ARGB4444, not RGBA4444. There might be
some discrepancy here. We can deal with them

Also there are some more formats missing from the list, could you
add them as well?

> +               break;
> +
>         case DRM_FORMAT_XRGB8888:
>                 *mode = SUN4I_BACKEND_LAY_FBFMT_XRGB8888;
>                 break;
> @@ -104,6 +120,10 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
>                 *mode = SUN4I_BACKEND_LAY_FBFMT_RGB888;
>                 break;
>
> +       case DRM_FORMAT_RGB565:
> +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGB565;
> +               break;
> +
>         default:
>                 return -EINVAL;
>         }
> diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
> index f0035bf5efea..5d53c977bca5 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_layer.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
> @@ -73,12 +73,18 @@ static const struct drm_plane_funcs sun4i_backend_layer_funcs = {
>  static const uint32_t sun4i_backend_layer_formats_primary[] = {
>         DRM_FORMAT_ARGB8888,
>         DRM_FORMAT_RGB888,
> +       DRM_FORMAT_RGB565,
>         DRM_FORMAT_XRGB8888,
>  };
>
>  static const uint32_t sun4i_backend_layer_formats_overlay[] = {
>         DRM_FORMAT_ARGB8888,
> +       DRM_FORMAT_ARGB4444,
> +       DRM_FORMAT_ARGB1555,
> +       DRM_FORMAT_RGBA5551,
> +       DRM_FORMAT_RGBA4444,
>         DRM_FORMAT_RGB888,
> +       DRM_FORMAT_RGB565,
>         DRM_FORMAT_XRGB8888,

Could you explain in the commit log why these 2 aren't the same?

Thanks
ChenYu

>  };
>
> --
> 2.9.3
>

[toc] | [prev] | [next] | [standalone]

#1507653

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-10-24 21:30 +0200
Message-ID<svT6x-3uO-11@gated-at.bofh.it>
In reply to#1505441

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Fri, Oct 21, 2016 at 11:15:32AM +0800, Chen-Yu Tsai wrote:
> On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > The planes can do more than what was previously exposed. Add support for
> > them.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  drivers/gpu/drm/sun4i/sun4i_backend.c | 20 ++++++++++++++++++++
> >  drivers/gpu/drm/sun4i/sun4i_layer.c   |  6 ++++++
> >  2 files changed, 26 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
> > index afb7ddf660ef..b184a476a480 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
> > @@ -96,6 +96,22 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
> >                 *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB8888;
> >                 break;
> >
> > +       case DRM_FORMAT_ARGB4444:
> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB4444;
> > +               break;
> > +
> > +       case DRM_FORMAT_ARGB1555:
> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB1555;
> > +               break;
> > +
> > +       case DRM_FORMAT_RGBA5551:
> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGBA5551;
> > +               break;
> > +
> > +       case DRM_FORMAT_RGBA4444:
> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGBA4444;
> 
> The A20 manual only lists ARGB4444, not RGBA4444. There might be
> some discrepancy here. We can deal with them

Hmm, yes, that's weird. But I guess this would be part of porting it
to the A20.

> Also there are some more formats missing from the list, could you
> add them as well?

Which one do you refer to?

> > +               break;
> > +
> >         case DRM_FORMAT_XRGB8888:
> >                 *mode = SUN4I_BACKEND_LAY_FBFMT_XRGB8888;
> >                 break;
> > @@ -104,6 +120,10 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
> >                 *mode = SUN4I_BACKEND_LAY_FBFMT_RGB888;
> >                 break;
> >
> > +       case DRM_FORMAT_RGB565:
> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGB565;
> > +               break;
> > +
> >         default:
> >                 return -EINVAL;
> >         }
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
> > index f0035bf5efea..5d53c977bca5 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
> > @@ -73,12 +73,18 @@ static const struct drm_plane_funcs sun4i_backend_layer_funcs = {
> >  static const uint32_t sun4i_backend_layer_formats_primary[] = {
> >         DRM_FORMAT_ARGB8888,
> >         DRM_FORMAT_RGB888,
> > +       DRM_FORMAT_RGB565,
> >         DRM_FORMAT_XRGB8888,
> >  };
> >
> >  static const uint32_t sun4i_backend_layer_formats_overlay[] = {
> >         DRM_FORMAT_ARGB8888,
> > +       DRM_FORMAT_ARGB4444,
> > +       DRM_FORMAT_ARGB1555,
> > +       DRM_FORMAT_RGBA5551,
> > +       DRM_FORMAT_RGBA4444,
> >         DRM_FORMAT_RGB888,
> > +       DRM_FORMAT_RGB565,
> >         DRM_FORMAT_XRGB8888,
> 
> Could you explain in the commit log why these 2 aren't the same?

Yep, I will.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1507894

FromChen-Yu Tsai <wens@csie.org>
Date2016-10-25 02:50 +0200
Message-ID<svY6e-6Ei-21@gated-at.bofh.it>
In reply to#1507653
On Mon, Oct 24, 2016 at 10:40 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> On Fri, Oct 21, 2016 at 11:15:32AM +0800, Chen-Yu Tsai wrote:
>> On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > The planes can do more than what was previously exposed. Add support for
>> > them.
>> >
>> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> > ---
>> >  drivers/gpu/drm/sun4i/sun4i_backend.c | 20 ++++++++++++++++++++
>> >  drivers/gpu/drm/sun4i/sun4i_layer.c   |  6 ++++++
>> >  2 files changed, 26 insertions(+)
>> >
>> > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
>> > index afb7ddf660ef..b184a476a480 100644
>> > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c
>> > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
>> > @@ -96,6 +96,22 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
>> >                 *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB8888;
>> >                 break;
>> >
>> > +       case DRM_FORMAT_ARGB4444:
>> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB4444;
>> > +               break;
>> > +
>> > +       case DRM_FORMAT_ARGB1555:
>> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB1555;
>> > +               break;
>> > +
>> > +       case DRM_FORMAT_RGBA5551:
>> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGBA5551;
>> > +               break;
>> > +
>> > +       case DRM_FORMAT_RGBA4444:
>> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGBA4444;
>>
>> The A20 manual only lists ARGB4444, not RGBA4444. There might be
>> some discrepancy here. We can deal with them
>
> Hmm, yes, that's weird. But I guess this would be part of porting it
> to the A20.
>
>> Also there are some more formats missing from the list, could you
>> add them as well?
>
> Which one do you refer to?

RGB556 and RGB655.

>
>> > +               break;
>> > +
>> >         case DRM_FORMAT_XRGB8888:
>> >                 *mode = SUN4I_BACKEND_LAY_FBFMT_XRGB8888;
>> >                 break;
>> > @@ -104,6 +120,10 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
>> >                 *mode = SUN4I_BACKEND_LAY_FBFMT_RGB888;
>> >                 break;
>> >
>> > +       case DRM_FORMAT_RGB565:
>> > +               *mode = SUN4I_BACKEND_LAY_FBFMT_RGB565;
>> > +               break;
>> > +
>> >         default:
>> >                 return -EINVAL;
>> >         }
>> > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
>> > index f0035bf5efea..5d53c977bca5 100644
>> > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c
>> > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
>> > @@ -73,12 +73,18 @@ static const struct drm_plane_funcs sun4i_backend_layer_funcs = {
>> >  static const uint32_t sun4i_backend_layer_formats_primary[] = {
>> >         DRM_FORMAT_ARGB8888,
>> >         DRM_FORMAT_RGB888,
>> > +       DRM_FORMAT_RGB565,
>> >         DRM_FORMAT_XRGB8888,
>> >  };
>> >
>> >  static const uint32_t sun4i_backend_layer_formats_overlay[] = {
>> >         DRM_FORMAT_ARGB8888,
>> > +       DRM_FORMAT_ARGB4444,
>> > +       DRM_FORMAT_ARGB1555,
>> > +       DRM_FORMAT_RGBA5551,
>> > +       DRM_FORMAT_RGBA4444,
>> >         DRM_FORMAT_RGB888,
>> > +       DRM_FORMAT_RGB565,
>> >         DRM_FORMAT_XRGB8888,
>>
>> Could you explain in the commit log why these 2 aren't the same?
>
> Yep, I will.

Cool! Thanks.

ChenYu

>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web